Message ID | 20231127010955.605-1-yang.lee@linux.alibaba.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp2777582vqx; Sun, 26 Nov 2023 17:10:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IEqxZ23oXmX/4bzpO+KSug+D5gIZ241WPX1VljXDYkPXYBZqZtxsk+Jprq6qHnlOLzNDWMJ X-Received: by 2002:a05:6e02:20ee:b0:35b:110f:8127 with SMTP id q14-20020a056e0220ee00b0035b110f8127mr10368678ilv.26.1701047409193; Sun, 26 Nov 2023 17:10:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701047409; cv=none; d=google.com; s=arc-20160816; b=Abui4pxI5JPe4KbkSpM9fyRhwIDKxW+dNXFcBY86lV7enFiPcu1zaKk5ooJdFSowWY tIwlcohsBA6kRVjZmd0xJt//BgywmdQLZG0GOolYt4+zuGiD8SdC9FAg9n5HkqfsaiC5 gzITopH9EkWEahbdsfSFfL7tq8yVG+iw6m2+QQd46go1VaOHkP9FqDX+6hW6Vm3KPBLf /rj/WwMS8XsaRv2jjDDJSEDe42jdx/E3cHCzZgv/HLTGx885p8l72206s0/zGqAIHP3A OuwBq/NGLJmGr9ga5/VBX2Un5Tdov1BDkTthrFWBwk1PYV4skCLeUEUqm0jOYmDtqj5w E55Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=GYBnZ7uIfzwTB59/kamoIbXffO4RyA1ewPG+BKEOxdg=; fh=G9ux7nDI1sLcHtPJYC2/MWoQIuYauZpXWmQNWVNCNaU=; b=sJuGHwlGuoqDPSRLFeGoOUBTOjiamPj9CyN8zMnaKgVLmOn4y/U9wxQtooqBjcQb/a da6UmfHyf1RXPb16hMw+uNkS/Vso7zeaavh/2szup9C/jKWqufY1ZIhWMMEBmSD9/Ti9 xCHmEYH5aotvoqt1yBeKnWHCTrFP5wVjlE47JOr7QKYQLgegkQA33hBEbzsEepigrTm4 3rATua3pkZ/5+BU37vJIL02bPOSavvytiMeo539A2wLlanFNQN/TtO0RV3QkwkB6cw2O OSEhS4Ex2T2ijrlhCs7U07V5dkMIFFmoqF4eZkjmRZ2PHVi5BwXqsWyPsDY/OPbVX8ZI Zthg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id s3-20020a656443000000b005b9b68add7csi8817146pgv.881.2023.11.26.17.10.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 17:10:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 18041804B026; Sun, 26 Nov 2023 17:10:03 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229495AbjK0BJy (ORCPT <rfc822;kernel.ruili@gmail.com> + 99 others); Sun, 26 Nov 2023 20:09:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjK0BJx (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 26 Nov 2023 20:09:53 -0500 Received: from out30-97.freemail.mail.aliyun.com (out30-97.freemail.mail.aliyun.com [115.124.30.97]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 984E210F; Sun, 26 Nov 2023 17:09:59 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0Vx7PjLT_1701047396; Received: from localhost(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0Vx7PjLT_1701047396) by smtp.aliyun-inc.com; Mon, 27 Nov 2023 09:09:57 +0800 From: Yang Li <yang.lee@linux.alibaba.com> To: mchehab@kernel.org, jackson.lee@chipsnmedia.com, nas.chung@chipsnmedia.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li <yang.lee@linux.alibaba.com>, Abaci Robot <abaci@linux.alibaba.com> Subject: [PATCH -next] media: chips-media: Remove surplus dev_err() when using platform_get_irq() Date: Mon, 27 Nov 2023 09:09:55 +0800 Message-Id: <20231127010955.605-1-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Sun, 26 Nov 2023 17:10:03 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783677488183424569 X-GMAIL-MSGID: 1783677488183424569 |
Series |
[-next] media: chips-media: Remove surplus dev_err() when using platform_get_irq()
|
|
Commit Message
Yang Li
Nov. 27, 2023, 1:09 a.m. UTC
There is no need to call the dev_err() function directly to print a
custom message when handling an error from either the platform_get_irq()
or platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7636
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/media/platform/chips-media/wave5/wave5-vpu.c | 1 -
1 file changed, 1 deletion(-)
Comments
Hey Yang, Thanks for the patch! The commit subject line should point to the respective driver and you can drop the brackets, so: `media: chips-media: wave5: Remove surplus dev_err when using platform_get_irq` Greetings, Sebastian On 27.11.2023 09:09, Yang Li wrote: >There is no need to call the dev_err() function directly to print a >custom message when handling an error from either the platform_get_irq() >or platform_get_irq_byname() functions as both are going to display an >appropriate error message in case of a failure. > >Reported-by: Abaci Robot <abaci@linux.alibaba.com> >Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7636 >Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> >--- > drivers/media/platform/chips-media/wave5/wave5-vpu.c | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpu.c b/drivers/media/platform/chips-media/wave5/wave5-vpu.c >index bfe4caa79cc9..3f7c622e8d58 100644 >--- a/drivers/media/platform/chips-media/wave5/wave5-vpu.c >+++ b/drivers/media/platform/chips-media/wave5/wave5-vpu.c >@@ -209,7 +209,6 @@ static int wave5_vpu_probe(struct platform_device *pdev) > > dev->irq = platform_get_irq(pdev, 0); > if (dev->irq < 0) { >- dev_err(&pdev->dev, "failed to get irq resource\n"); > ret = -ENXIO; > goto err_enc_unreg; > } >-- >2.20.1.7.g153144c > >
diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpu.c b/drivers/media/platform/chips-media/wave5/wave5-vpu.c index bfe4caa79cc9..3f7c622e8d58 100644 --- a/drivers/media/platform/chips-media/wave5/wave5-vpu.c +++ b/drivers/media/platform/chips-media/wave5/wave5-vpu.c @@ -209,7 +209,6 @@ static int wave5_vpu_probe(struct platform_device *pdev) dev->irq = platform_get_irq(pdev, 0); if (dev->irq < 0) { - dev_err(&pdev->dev, "failed to get irq resource\n"); ret = -ENXIO; goto err_enc_unreg; }