From patchwork Sun Nov 26 23:51:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Marangi X-Patchwork-Id: 169921 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp2746680vqx; Sun, 26 Nov 2023 15:52:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IHR+4yicDUjwf40ywgehW0JmsCSscUzTtz8RqHoUPb26lc+3b8O4zBLHSJmiay+xQz96qVK X-Received: by 2002:a17:902:eacb:b0:1cf:a043:a44a with SMTP id p11-20020a170902eacb00b001cfa043a44amr9089561pld.4.1701042725171; Sun, 26 Nov 2023 15:52:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701042725; cv=none; d=google.com; s=arc-20160816; b=sgV5jQWwWKfvTLQqWmNgNxUKr6B1R0eMEdEt5iKS+sKHHMgXdGbFmmdr1EMHEKA1BD wb3Nlpp7BNqLE3wXJJD9XUbm9mnSlg/kw294cmWKjg91mWm94MbyqL24EaznFRzykCun /Z9yfG3Uxdaf0BdaPl2FqGF3IwK7cej0+PI2Hk/LQoTP/qk9/Oo4VMwQ36hC0EwVT616 nWUu0KWh2FrnLUod4eLkeSKG5pmYhViOgd2gyBKn3WGQwx4sgRCscnt+92rxaTya9nPT W8o/bnjtiXYXiTKeS5eT2QgBOMA7TtJxp4255jNvLlVfklY5aOJIYQKSr+ArxU+upckw 7tuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=Afqq+Hb2PFb58HdScLJ0dW+5Ky8jYx/Z5oemC8zCj40=; fh=qVBUraGgBy8kGTTVhUjEciNSIcfnkQdrmodHaoEX+PI=; b=h1OyDUCi0EyZ+BUR1RZUk/sQfkZ6Ptn2Ky5/ETpHAyxW2RQtRidjM8HF4W0ZAOPDrh Us2hXfcBYB5BZPlVA8la2bqho/94WyymLO1H3m06ZNVD9o/gdkDXdLSSwD90e9C4c5dI 6eKFWr/FTQ3ZGB1Tiu1W6YO0DGlpcGK/ujBomcAvR4n08FAqzjJ/tSfTWtXOlIhi5n3j Hb5/EriQhpY4Javb0e7SQZ6GHMPTUyZ9IGKCy0SDhY1l7Wj8z37P2q8mIf6pZb0DfsfA K0+0MHT5m9DtZDAaNfd1hKyZYJdhmS86RqigsbAi7sVoF3fN/Wlx8qyxlafPGBxf7XsZ aTkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Uz5+1sSV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id q8-20020a17090311c800b001cc407388a8si8840148plh.337.2023.11.26.15.52.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 15:52:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Uz5+1sSV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 968948063153; Sun, 26 Nov 2023 15:52:00 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229667AbjKZXvw (ORCPT + 99 others); Sun, 26 Nov 2023 18:51:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbjKZXvu (ORCPT ); Sun, 26 Nov 2023 18:51:50 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31D28ED; Sun, 26 Nov 2023 15:51:57 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-4079ed65582so24907595e9.1; Sun, 26 Nov 2023 15:51:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701042715; x=1701647515; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Afqq+Hb2PFb58HdScLJ0dW+5Ky8jYx/Z5oemC8zCj40=; b=Uz5+1sSVEUO/fu6npO79SuXh5Bzgh0DGCBfRWxpiRfXuZLnyoKcaXYre0W1ebYS9KM DqgvvQccfNrbByL9OXZssuP28SAaTnODP4kg2AOPdydjB0lv82W4TkoZtkWWH28KL352 +GeI8YqDrex/+mblw84NvFqSxG+gRmfi0Bs20du2whO6x3CzEeplF8gojCCGzvOFoppn Z52//5dmqzl7VRpTf9FvctcoW9J+4RYVyw2yHQnAvUjRUxkzRJLy0f9JApRpbZuhQb0O 4J3HSLtrDdEkNciYw7Vlk7TAnWoc+UBv0XK+CWCBQx2icDbLxQTfHcHPX9scSkih/+xZ fepw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701042715; x=1701647515; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Afqq+Hb2PFb58HdScLJ0dW+5Ky8jYx/Z5oemC8zCj40=; b=Pdmp18heg4LV6nfSK6wfwfBv3taTGZ42YhyHADdwlfWRkEmNlvbrDYfmuKsJGB22h3 Yz1wURt3ZcSQoRZ/HrkKX96grv/C6LVC/Q6nmRj1x8amtmD1ordQvPUq4KUpJzrvuTP9 GWFL4dVGJVxMwcOLb+KuOzRU46NWnpCEt045sOKM0pzK9blpP7efshOInApsGUyvQnwE +s2sHW5zON3Fl9KmYzTMT67+90tyaOZxVdAisUclTzSSW29MI9sIu2E3sgpvxDos7L2D +TWduZLB1Yw2ywPU8sPPObcCp74VqWCNgRXeDvjeeIQfHdsY7yGEUH2fN+WolMJWr5zM 9u4w== X-Gm-Message-State: AOJu0Yz7kweiFtbQ+Jkfnb7n1Xv9zV2wGg/G/3Cn1jiCmYQulwuJg7lb arF93pzYojvdSTvEKK5VLBA= X-Received: by 2002:a05:600c:78f:b0:40b:3725:4228 with SMTP id z15-20020a05600c078f00b0040b37254228mr7265523wmo.18.1701042715461; Sun, 26 Nov 2023 15:51:55 -0800 (PST) Received: from localhost.localdomain (93-34-89-13.ip49.fastwebnet.it. [93.34.89.13]) by smtp.googlemail.com with ESMTPSA id m4-20020a05600c4f4400b0040b3dbb5c93sm1202151wmq.1.2023.11.26.15.51.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 15:51:54 -0800 (PST) From: Christian Marangi To: Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , David Epping , "Russell King (Oracle)" , Harini Katakam , Christian Marangi , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [net-next PATCH v2 2/4] net: phy: move mmd_phy_indirect to generic header Date: Mon, 27 Nov 2023 00:51:39 +0100 Message-Id: <20231126235141.17996-2-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231126235141.17996-1-ansuelsmth@gmail.com> References: <20231126235141.17996-1-ansuelsmth@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sun, 26 Nov 2023 15:52:00 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783672576578908578 X-GMAIL-MSGID: 1783672576578908578 Move mmd_phy_indirect function from phy-core to generic phy.h to permit future usage for PHY package read/write_mmd. Signed-off-by: Christian Marangi --- drivers/net/phy/phy-core.c | 14 -------------- include/linux/phy.h | 14 ++++++++++++++ 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/net/phy/phy-core.c b/drivers/net/phy/phy-core.c index 966c93cbe616..b4f80847eefd 100644 --- a/drivers/net/phy/phy-core.c +++ b/drivers/net/phy/phy-core.c @@ -526,20 +526,6 @@ int phy_speed_down_core(struct phy_device *phydev) return 0; } -static void mmd_phy_indirect(struct mii_bus *bus, int phy_addr, int devad, - u16 regnum) -{ - /* Write the desired MMD Devad */ - __mdiobus_write(bus, phy_addr, MII_MMD_CTRL, devad); - - /* Write the desired MMD register address */ - __mdiobus_write(bus, phy_addr, MII_MMD_DATA, regnum); - - /* Select the Function : DATA with no post increment */ - __mdiobus_write(bus, phy_addr, MII_MMD_CTRL, - devad | MII_MMD_CTRL_NOINCR); -} - /** * __phy_read_mmd - Convenience function for reading a register * from an MMD on a given PHY. diff --git a/include/linux/phy.h b/include/linux/phy.h index 51702e349d83..a63d45880b1a 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -1316,6 +1316,20 @@ static inline int __phy_modify_changed(struct phy_device *phydev, u32 regnum, regnum, mask, set); } +static inline void mmd_phy_indirect(struct mii_bus *bus, int phy_addr, int devad, + u16 regnum) +{ + /* Write the desired MMD Devad */ + __mdiobus_write(bus, phy_addr, MII_MMD_CTRL, devad); + + /* Write the desired MMD register address */ + __mdiobus_write(bus, phy_addr, MII_MMD_DATA, regnum); + + /* Select the Function : DATA with no post increment */ + __mdiobus_write(bus, phy_addr, MII_MMD_CTRL, + devad | MII_MMD_CTRL_NOINCR); +} + /* * phy_read_mmd - Convenience function for reading a register * from an MMD on a given PHY.