| Message ID | 20231126162009.17934-1-sven@svenpeter.dev |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp2562562vqx;
Sun, 26 Nov 2023 08:20:37 -0800 (PST)
X-Google-Smtp-Source:
AGHT+IEFfkx6/nIGtIGK3Rjl7pPtlQ2OBf6BoFFyn3pt6j3vvG8UUgxU5LXtxAusDvccv2CaI05d
X-Received: by 2002:a17:90a:f2d2:b0:27d:348:94a8 with SMTP id
gt18-20020a17090af2d200b0027d034894a8mr9194697pjb.6.1701015637244;
Sun, 26 Nov 2023 08:20:37 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1701015637; cv=none;
d=google.com; s=arc-20160816;
b=G5O0jOjo8pBuYX7UPcr1voLHznx0uo0r5VxB73egrXtUUisn2P/u1/M6kCx9ZZFRq8
DhH7rovmoY1QtmRl/tU63uiyQ3qQcsFFeEzUfibLv/v7vvKK8KCBrrWpQGTI1NKVBpgT
BFhAWOltH3a+kM4fP9t3Nsn+uFAqr2jb8fRuoIAj90ud7E1qHKt2+LvUApe17xJ3hbG2
xekT097neiZubGL3uW74HEODkSd/dZBYrtap2hOQ5lM5StdzzzTFySFvWqF+juDtiZfn
NxKHt2GIMRxfNoiPyc48xEeX0xUBu4YqZw9FhH8Zzus18/zA4wVqIp5WrjLbS446VLn+
hS+g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:feedback-id:dkim-signature
:dkim-signature;
bh=QyP8UlmkQUxctXvsLY+u2IDuION9oeAKPUhsirOlXLA=;
fh=ofg8jqsj5x5rk/ONO3/ipICl3KMw16QfOqMJEz29IQA=;
b=W1091KSqfg1kEu6cJPsvDIhei/VGri5BSa42nG8cys8o+khkn5ng06UyHF/FeprHv8
3+nC3EhDOR6OcLhYXj+grLd9BijDcYwI75Ck43uD8Ft6pSYEyjzkggfhE3cEWutNRMfj
NsqdW8q7xiRjonnvxLV5dg5ujV9T4dTEChTN8gRnqgLHJ8T+IdgAk5LFxmnj1CT0ErNm
DlDr0WmaYzacIM6nZfeKg1ax29tgji41GN+iJskvylmaajpRRyTIb7tkeRjEBl3SqCsI
2eckKBxUnI7XtSlkEJpKo+0LJSBfF0uTXKXFXrTlBeirbCgLSqM4KV4zFnJdLqgjhZDa
87Jg==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@svenpeter.dev header.s=fm1 header.b=mz9yoPop;
dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=pYW6R4XC;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:4 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=svenpeter.dev
Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4])
by mx.google.com with ESMTPS id
h3-20020a17090a130300b002806cdeecc6si8503201pja.35.2023.11.26.08.20.36
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 26 Nov 2023 08:20:37 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:4 as permitted sender)
client-ip=2620:137:e000::3:4;
Authentication-Results: mx.google.com;
dkim=pass header.i=@svenpeter.dev header.s=fm1 header.b=mz9yoPop;
dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=pYW6R4XC;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:4 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=svenpeter.dev
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by howler.vger.email (Postfix) with ESMTP id 0DD7E80608D8;
Sun, 26 Nov 2023 08:20:26 -0800 (PST)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230097AbjKZQUR (ORCPT <rfc822;kernel.ruili@gmail.com>
+ 99 others); Sun, 26 Nov 2023 11:20:17 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55278 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229456AbjKZQUP (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Sun, 26 Nov 2023 11:20:15 -0500
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
[66.111.4.25])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D36ED3
for <linux-kernel@vger.kernel.org>;
Sun, 26 Nov 2023 08:20:22 -0800 (PST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
by mailout.nyi.internal (Postfix) with ESMTP id 093F35C0162;
Sun, 26 Nov 2023 11:20:19 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
by compute2.internal (MEProxy); Sun, 26 Nov 2023 11:20:19 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svenpeter.dev;
h=cc:cc:content-transfer-encoding:content-type:date:date:from
:from:in-reply-to:message-id:mime-version:reply-to:sender
:subject:subject:to:to; s=fm1; t=1701015619; x=1701102019; bh=Qy
P8UlmkQUxctXvsLY+u2IDuION9oeAKPUhsirOlXLA=; b=mz9yoPopTnP5Pp9VMl
d2z+GxcdEHJ0tmL5X3c0HKcOBIgBBPogGES9smTlQf/Y7YpXCFNuyR/cbd4eblDR
U6itJOlmN29E0epnkGmKfcmml1kGtIIC8knv6lWDBXqAyizfMmZZ8uixkEfL9s0l
gz64qKje4FM0BruZ0MVm/5QhsyanRTIhxhKBvMRD0t46o+qW88VhK6tOT1V8nhgi
NLeR2JdE2uT0WNdG6vPoFqDD+9uRIQTDDM19javDpLi8/BW3yD9a35v/LmdOCh+s
GmtmzU+bP2ys02U4p/7K2B8wDTEsX3PfdUs0GrgusNVLm+cGbN0qyt8614odS95O
qWqA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:date:date:feedback-id:feedback-id:from:from
:in-reply-to:message-id:mime-version:reply-to:sender:subject
:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm1; t=1701015619; x=1701102019; bh=QyP8UlmkQUxct
XvsLY+u2IDuION9oeAKPUhsirOlXLA=; b=pYW6R4XCzRWd0vTqOJWtxZ77G2Xa0
tiANXLIVKppJ2E10z+/38o4klXtIPbKRjbPZi0unsaPsdbWSkXKDPre2IDOZMDca
3fMLyDSrRIdACt1SgcX6EPjR0nfz6GpRo0+KhEsos1aOIq+mwzrrF1IfPsMgU/Il
Yl8JMJPkrG/dBGxFcUjkinRSPBoW+jCImanE7oeCzAwFjNv2KAgh7Cx44BwZ9/3Z
ufgv2gtu5LCLod4X9+evU0B0azE0ziOhagcQNvM+MbNC/hxFh1X3IB5qZWRU/EUW
dKzARYnqNs7VRYa86/mEFocyApbgQik8UTYqlJu27PmINuvmOk6wIaHQQ==
X-ME-Sender: <xms:QnBjZV5cDDVJbvYPtkQ9ryzJUBGmbD2Swxwsv6tnrPl-J-IJ84LjAQ>
<xme:QnBjZS7k3aPMObtfVzaI_FLh7lerL1ppTkFc_zxCsNTVROm982brmjmpy70tFUk1b
EwBe4F6TzWiM3VkB74>
X-ME-Received:
<xmr:QnBjZcfTQ1ZYM3ZMwgmcFK02dJPttc8k5NWhdDdABE61PbtFU-gOoh70BYyH6DhOJBXz0cFJsFZn5rRrzkmDXqlVzYtDyXF7Qa_v-IC8OhLGXEZ4HMHvyGM_Y-ls3uw>
X-ME-Proxy-Cause:
gggruggvucftvghtrhhoucdtuddrgedvkedrudehledgledtucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomhepufhvvghnucfr
vghtvghruceoshhvvghnsehsvhgvnhhpvghtvghrrdguvghvqeenucggtffrrghtthgvrh
hnpeeludffieehueevtdffvedtueelleejuddugfettdevhfefffdvgffhjeehgfelleen
ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsvhgvnh
esshhvvghnphgvthgvrhdruggvvh
X-ME-Proxy: <xmx:QnBjZeJhfb2l1cvB8aiiCBBqvgCMwubJsyjh2Xg_Ow7bx5LS9IHGFw>
<xmx:QnBjZZJ978hMrfxgmqD292uDOHG4gqeCceuXFraHAFZ8EMgsLww9MQ>
<xmx:QnBjZXw_SJi0LXt1FRu8hOt0eZVit57-2ptaaCBAQ4rFAkl2M1B0uw>
<xmx:Q3BjZQ88uzyYXxa_Wgbci8FNl3bKjHQRDhLuFwi9nEQcCcUWFenojA>
Feedback-ID: i51094778:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
26 Nov 2023 11:20:16 -0500 (EST)
From: Sven Peter <sven@svenpeter.dev>
To: Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>
Cc: Alyssa Rosenzweig <alyssa@rosenzweig.io>, asahi@lists.linux.dev,
linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: [PATCH] iommu: dart: Use readl instead of readl_relaxed for
consistency
Date: Sun, 26 Nov 2023 17:20:09 +0100
Message-Id: <20231126162009.17934-1-sven@svenpeter.dev>
X-Mailer: git-send-email 2.39.3 (Apple Git-145)
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]);
Sun, 26 Nov 2023 08:20:26 -0800 (PST)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1783644172795123989
X-GMAIL-MSGID: 1783644172795123989
|
| Series |
iommu: dart: Use readl instead of readl_relaxed for consistency
|
|
Commit Message
Sven Peter
Nov. 26, 2023, 4:20 p.m. UTC
While the readl_relaxed in apple_dart_suspend is correct the rest of the
driver uses the non-relaxed variants everywhere and the single
readl_relaxed is inconsistent and possibly confusing.
Signed-off-by: Sven Peter <sven@svenpeter.dev>
---
drivers/iommu/apple-dart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
r-b On Sun, Nov 26, 2023 at 05:20:09PM +0100, Sven Peter wrote: > While the readl_relaxed in apple_dart_suspend is correct the rest of the > driver uses the non-relaxed variants everywhere and the single > readl_relaxed is inconsistent and possibly confusing. > > Signed-off-by: Sven Peter <sven@svenpeter.dev> > --- > drivers/iommu/apple-dart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c > index 59cf256bf40f..c7f047ce0a7a 100644 > --- a/drivers/iommu/apple-dart.c > +++ b/drivers/iommu/apple-dart.c > @@ -1272,7 +1272,7 @@ static __maybe_unused int apple_dart_suspend(struct device *dev) > unsigned int sid, idx; > > for (sid = 0; sid < dart->num_streams; sid++) { > - dart->save_tcr[sid] = readl_relaxed(dart->regs + DART_TCR(dart, sid)); > + dart->save_tcr[sid] = readl(dart->regs + DART_TCR(dart, sid)); > for (idx = 0; idx < dart->hw->ttbr_count; idx++) > dart->save_ttbr[sid][idx] = > readl(dart->regs + DART_TTBR(dart, sid, idx)); > -- > 2.34.1 >
On Sun, Nov 26, 2023 at 11:20 AM Sven Peter <sven@svenpeter.dev> wrote: > > While the readl_relaxed in apple_dart_suspend is correct the rest of the > driver uses the non-relaxed variants everywhere and the single > readl_relaxed is inconsistent and possibly confusing. > > Signed-off-by: Sven Peter <sven@svenpeter.dev> > --- > drivers/iommu/apple-dart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c > index 59cf256bf40f..c7f047ce0a7a 100644 > --- a/drivers/iommu/apple-dart.c > +++ b/drivers/iommu/apple-dart.c > @@ -1272,7 +1272,7 @@ static __maybe_unused int apple_dart_suspend(struct device *dev) > unsigned int sid, idx; > > for (sid = 0; sid < dart->num_streams; sid++) { > - dart->save_tcr[sid] = readl_relaxed(dart->regs + DART_TCR(dart, sid)); > + dart->save_tcr[sid] = readl(dart->regs + DART_TCR(dart, sid)); > for (idx = 0; idx < dart->hw->ttbr_count; idx++) > dart->save_ttbr[sid][idx] = > readl(dart->regs + DART_TTBR(dart, sid, idx)); > -- > 2.34.1 > > Reviewed-by: Neal Gompa <neal@gompa.dev>
On 2023/11/27 1:20, Sven Peter wrote: > While the readl_relaxed in apple_dart_suspend is correct the rest of the > driver uses the non-relaxed variants everywhere and the single > readl_relaxed is inconsistent and possibly confusing. > > Signed-off-by: Sven Peter <sven@svenpeter.dev> > --- > drivers/iommu/apple-dart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c > index 59cf256bf40f..c7f047ce0a7a 100644 > --- a/drivers/iommu/apple-dart.c > +++ b/drivers/iommu/apple-dart.c > @@ -1272,7 +1272,7 @@ static __maybe_unused int apple_dart_suspend(struct device *dev) > unsigned int sid, idx; > > for (sid = 0; sid < dart->num_streams; sid++) { > - dart->save_tcr[sid] = readl_relaxed(dart->regs + DART_TCR(dart, sid)); > + dart->save_tcr[sid] = readl(dart->regs + DART_TCR(dart, sid)); > for (idx = 0; idx < dart->hw->ttbr_count; idx++) > dart->save_ttbr[sid][idx] = > readl(dart->regs + DART_TTBR(dart, sid, idx)); Acked-by: Hector Martin <marcan@marcan.st> - Hector
On Sun, Nov 26, 2023 at 05:20:09PM +0100, Sven Peter wrote: > While the readl_relaxed in apple_dart_suspend is correct the rest of the > driver uses the non-relaxed variants everywhere and the single > readl_relaxed is inconsistent and possibly confusing. > > Signed-off-by: Sven Peter <sven@svenpeter.dev> > --- > drivers/iommu/apple-dart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. In the future, can you please use "iommu/apple-dart:" as the prefix for you patch subject-lines? That fits better into the overall convention in the iommu-tree, thanks. Regards, Joerg
diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c index 59cf256bf40f..c7f047ce0a7a 100644 --- a/drivers/iommu/apple-dart.c +++ b/drivers/iommu/apple-dart.c @@ -1272,7 +1272,7 @@ static __maybe_unused int apple_dart_suspend(struct device *dev) unsigned int sid, idx; for (sid = 0; sid < dart->num_streams; sid++) { - dart->save_tcr[sid] = readl_relaxed(dart->regs + DART_TCR(dart, sid)); + dart->save_tcr[sid] = readl(dart->regs + DART_TCR(dart, sid)); for (idx = 0; idx < dart->hw->ttbr_count; idx++) dart->save_ttbr[sid][idx] = readl(dart->regs + DART_TTBR(dart, sid, idx));