From patchwork Sun Nov 26 15:44:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 169884 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp2546906vqx; Sun, 26 Nov 2023 07:55:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IHl71sB/oLfQdWpm5vA1Nxd3jPrKfuPTXgqq0ks+y63Rp4FBxvpaTE+hy0dT7FnEMXDz5lK X-Received: by 2002:a05:6a20:54a7:b0:18b:92b3:7c80 with SMTP id i39-20020a056a2054a700b0018b92b37c80mr13085180pzk.22.1701014100993; Sun, 26 Nov 2023 07:55:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701014100; cv=none; d=google.com; s=arc-20160816; b=TmwGVohInzYfqUDuYYqEyW6r4/b4c6VkCTPbUfvT87qPeCCKd2K7RdDN42ctl0PSvN NuFEHS0pvyaelbp8bm9DWitg8ugU8OdOdfy20t1kAf9e0sDBDj/WuiNTPteKEX4ITIIe 9Wj9i3KTC9MDbOY3D6sef4CkwqMIPNdNx6lUDyjRyV6M+tEJlJNjpH1C3DnSWpW2Ganb JpuijIH344cgr1pap75+zm94vbTEp4Yp5ebPNpYQKT+m663yIIoXtpFFDLjMJpEidZAb TDbZTURghjw1mPwDOkFaW6kX+tyJ5JJAUsqLZwOnK5D6OUDX1EVNLTilSpN4TdWmfz7w 0lrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Frvwetq2uP6wtxuP9UX1ctUqElygA7huby/aEqYEpm0=; fh=m6aHy4GVWeiYcahcFfIzqNn3pzsQZUVlVWbThwuybpU=; b=higw/xI0MRvTdHCyJzcD9yU2JO1IbHnMS7F+bMyNOBLUK9U1SyoUXFKtDrxKSub7I5 GlEXp7uyR7P+bpIsQusuJ0usFCR3u804mS7zRxZ0/yh1a04PInpt43sAUEBeRulPcxT6 OYiW7eo7Xas9HzUlTBXJxeA1uZdqXFShzfZT9Mf1dk5kbqIi/iNEPq5GJLF7HLnoTY3O KmVNQFaJL8ipMNVlvU9PEM6xGIo/WhB6r9QK+gG0Sd58O88I7SHXtKHXBdG2N+s3OiYO n2CzBN8WN6EkI9koGz7x4hNDaTbpcbUp8vjEEm4iwCo97C9om+n1KkJ3DNsBx8UPGCrn DZqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=bDRBqyHT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id a187-20020a624dc4000000b006c3212b57aasi7441101pfb.325.2023.11.26.07.55.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 07:55:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=bDRBqyHT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 073F780B19E5; Sun, 26 Nov 2023 07:54:55 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229489AbjKZPyn (ORCPT + 99 others); Sun, 26 Nov 2023 10:54:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230453AbjKZPqk (ORCPT ); Sun, 26 Nov 2023 10:46:40 -0500 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2B521A5 for ; Sun, 26 Nov 2023 07:46:44 -0800 (PST) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a08e4352992so278697566b.1 for ; Sun, 26 Nov 2023 07:46:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1701013603; x=1701618403; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Frvwetq2uP6wtxuP9UX1ctUqElygA7huby/aEqYEpm0=; b=bDRBqyHTyF+fHdoboWSuZZQfp6AcYc1IJ8ii28CCzvKa2krnfgE91PhZCo2OK3ioMV tXy08MhS8+Ds69186bFuAKpBtuk93ANCQDwJ/QtDwUlRKKGH88zXFnnGxQicUOsSnd+F rOungMdmME4OOyHxXtoy5IDaWATP2q/JtCAUY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701013603; x=1701618403; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Frvwetq2uP6wtxuP9UX1ctUqElygA7huby/aEqYEpm0=; b=GxpFrZ99BhggkcZKh3qnV44rlnuQApy0RVg2ctccaXfzjEhcYRSruqCU2wOjVV0mDk t8zHjqTIRsCvm/+BD80kOodft1u8m7INVRFwH9Qd8n9lG66iCAPkGMsDuO8BDkL2of/I romnMjM4HrBw1+6kqzRPTa0y2IpUnkqCKNTBof8gQ1tqiCKNw3ITu156tbXexnYfbdQY zNSl09HSZQGOAZfmDbLsdZQDulRl/iOJtwQTvtkJFOYD7Kg+iu5wHDHGrJOoYcshzT0k MkjWUOzLXe8mH7fqjdsrEOSYXS/hKahjv20DNXunJhhy55IWiceglF2xPfyU2afQSphD ZQFA== X-Gm-Message-State: AOJu0YwSbzCjJZRVLXbRwnhqWWiwQhJ5KrrRG77U7IfFVIJrkBvYF07U QCKEveuwnpIniDC/YMWYil/asXrEUdTzTE2g48BWrg== X-Received: by 2002:a17:906:25e:b0:a0d:35b:89a9 with SMTP id 30-20020a170906025e00b00a0d035b89a9mr1819881ejl.46.1701013603021; Sun, 26 Nov 2023 07:46:43 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-95-244-100-54.retail.telecomitalia.it. [95.244.100.54]) by smtp.gmail.com with ESMTPSA id h24-20020a170906591800b009fdc684a79esm4656158ejq.124.2023.11.26.07.46.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 07:46:41 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , michael@amarulasolutions.com, Dario Binacchi , Andrzej Hajda , Daniel Vetter , David Airlie , Inki Dae , Jagan Teki , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Maarten Lankhorst , Marek Szyprowski , Maxime Ripard , Neil Armstrong , Robert Foss , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v2 03/11] drm: bridge: samsung-dsim: enter display mode in the enable() callback Date: Sun, 26 Nov 2023 16:44:55 +0100 Message-ID: <20231126154605.15767-4-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231126154605.15767-1-dario.binacchi@amarulasolutions.com> References: <20231126154605.15767-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Sun, 26 Nov 2023 07:54:55 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783642561919437582 X-GMAIL-MSGID: 1783642561919437582 The synaptics-r63353 (panel-bridge) can only be configured in command mode. So, samsung-dsim (bridge) must not be in display mode during the prepare()/unprepare() of the panel-bridge. Setting the "pre_enable_prev_first" flag to true allows the prepare() of the panel-bridge to be called between the pre_enabled() and enabled() of the bridge. So, the bridge can enter display mode only in the enabled(). The unprepare() of the panel-bridge is instead called between the disable() and post_disable() of the bridge. So, the disable() must exit the display mode (i .e. enter command mode) to allow the panel-bridge to receive DSI commands. samsung_dsim_atomic_pre_enable -> command mode r63353_panel_prepare -> send DSI commands samsung_dsim_atomic_enable -> enter display mode samsung_dsim_atomic_disable -> exit display mode (command mode) r63353_panel_unprepare -> send DSI commands samsung_dsim_atomic_post_disable Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/gpu/drm/bridge/samsung-dsim.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index be5914caa17d..15bf05b2bbe4 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -1494,7 +1494,6 @@ static void samsung_dsim_atomic_pre_enable(struct drm_bridge *bridge, return; samsung_dsim_set_display_mode(dsi); - samsung_dsim_set_display_enable(dsi, true); } } @@ -1507,6 +1506,7 @@ static void samsung_dsim_atomic_enable(struct drm_bridge *bridge, samsung_dsim_set_display_mode(dsi); samsung_dsim_set_display_enable(dsi, true); } else { + samsung_dsim_set_display_enable(dsi, true); samsung_dsim_set_stop_state(dsi, false); } @@ -1524,6 +1524,8 @@ static void samsung_dsim_atomic_disable(struct drm_bridge *bridge, if (!samsung_dsim_hw_is_exynos(dsi->plat_data->hw_type)) samsung_dsim_set_stop_state(dsi, true); + samsung_dsim_set_display_enable(dsi, false); + dsi->state &= ~DSIM_STATE_VIDOUT_AVAILABLE; } @@ -1532,7 +1534,8 @@ static void samsung_dsim_atomic_post_disable(struct drm_bridge *bridge, { struct samsung_dsim *dsi = bridge_to_dsi(bridge); - samsung_dsim_set_display_enable(dsi, false); + if (!samsung_dsim_hw_is_exynos(dsi->plat_data->hw_type)) + samsung_dsim_set_stop_state(dsi, true); dsi->state &= ~DSIM_STATE_ENABLED; pm_runtime_put_sync(dsi->dev);