From patchwork Sun Nov 26 00:37:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Marangi X-Patchwork-Id: 169812 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp2231356vqx; Sat, 25 Nov 2023 16:38:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IGzay2Kct48gs5dO/qysLXHrQrzX42HxHdK+7olDlCTfDP3dlmna26B0ou0cOG8c60N58Q2 X-Received: by 2002:a05:6a20:d48e:b0:18a:db41:bd0a with SMTP id im14-20020a056a20d48e00b0018adb41bd0amr11068144pzb.39.1700959105703; Sat, 25 Nov 2023 16:38:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700959105; cv=none; d=google.com; s=arc-20160816; b=O+rqRL6+PgEyt4ZFMkiUiLXmU5e0DrGK+bzyNGO/kJLYkE9hdePHypCCG+dFQJzbi4 e0Xk6rjgPKjaF8KNpbDGFwm9SIYLue0e1bpdBiiXX0jGktcvf/D2IUENKEFnDuWbk9M7 uOhxNTMZJH75R1FxuBY7GSvKOFw3XeJlZ+uDXpxjBrLLfvXmjfahib+Kq27XHRHkHF/l 65G6HutSuz/zhSZq/40tvWCzLPI//u5qW+YXh8hgBGfnP7SHq3c7fz77ak2zaQI00vJW Q+TUm4cy712o6/9c5ORFqK+FC4JqOXWNAJ70wqU5sItPg/gvABK5fITlDOXvWXcPrz0X /yNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=1uPUXkFTFTY3wjyppF4kZdPmBYcUNyv8eWABZcZLvEU=; fh=J3u6k9w1tTJVXqrAQN6TvigFxEzuC6yecz+ZMTbdd1Q=; b=mu/abmx39LmcMiCjtbFK4V44J6HMWegYNEdE7VAnzYJ5neUVanXppm2Bs7Oebqhzjg LUMmGRqZCJhyWQYnVY4GWXy+rLxiqOHeyzok9pQT2ADDq7U9mpUAxgauGoTGig02jnLI XGLmItBoLrCNJ92gFUBAC6TpYthM6/D+eNFe0fi9VbZZBDzFS2vYg0FlawViwDxN44qO Nk+KFfQAjyyV18G4yQZeEpi5rJGo9Fi4x5Eu0gyGsatSsrSQtPmv0WBg596zHpnY4c+2 MegJ2OMkGgLQe8lKTQMmX4GPWYF5YMmIYMT3ZIIVHV4v4W9eDR9L/IdzDIG6Ha6xUXr9 lLCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=dqCtQy9x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id p21-20020a63f455000000b005898e5f41f8si6805139pgk.53.2023.11.25.16.38.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Nov 2023 16:38:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=dqCtQy9x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 62C6F80697FB; Sat, 25 Nov 2023 16:38:23 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230229AbjKZAh6 (ORCPT + 99 others); Sat, 25 Nov 2023 19:37:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229920AbjKZAhx (ORCPT ); Sat, 25 Nov 2023 19:37:53 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18E6C182; Sat, 25 Nov 2023 16:37:59 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-332d2b6a84cso2118174f8f.0; Sat, 25 Nov 2023 16:37:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700959077; x=1701563877; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=1uPUXkFTFTY3wjyppF4kZdPmBYcUNyv8eWABZcZLvEU=; b=dqCtQy9xgG5eo3lWyOVCPujrfXvDkvzHwAlLoMtWgFom2c5zBciE+6ta28FmYAnjJj 7ynfMKXA5WCJBakigtwReQJoECIGerjMcZsngMUdoC+iDWpsh5Fy1y6Iu8yqiW1A6yA+ SCQjcp7F/Hxm9v+YwG8Jlkm3BNAntfTrlDFzqR+rvjiPXHkAiGeuxIXGhhuYTmzPC4wY qUY84+Cc4N23AvCdwRhh7Hbmmu0Hn/expUrGqZsDLbbGSNiiebgLxXTZtM1r0Bpgxgj2 Ha6+ObIxcvBeElM0cvgodvjm4qwj3YPOrKPlFMSHWmRH89SlL8I7eDBoulU5xDhqhlpG 4/8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700959077; x=1701563877; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1uPUXkFTFTY3wjyppF4kZdPmBYcUNyv8eWABZcZLvEU=; b=a41u3qlvnBbMgnr1tRXZFw2JMupn7d9Pm3z7AON4cVrjfosrojSiZIfzNsgQZY0I4g LFS1O42slvIBLdq3bPUyAVf271N3i+0nNOK7DdFgrVqf81jYGBHB3ioACt+n1PcuZ8U6 TGP/bA1wnmxXoEkFF8M9V5y4bS8TMm0ijQSbrfqT8xZg+JRVd77cR1b94ZUtK7zB8bLS 4CPrsLumBvNUFUOWb3ZE1k94RjBLbCCFUPI5Bc2C4kqMsPw3aA/k5QVdlU1dHSYVCT23 qk4Se03QM5EfarHwHIv82PYBT4DXkTlW9qi/SUt0NbySwWxjAtiNf9sfMzt2LYfdjd1l g3nA== X-Gm-Message-State: AOJu0YzcvZtXNizTBFgZU9WKE3ulrA8IUoXeiNu8JInDYncpNn6lyxKv 4Bgo9taZBhkb6tLt8gim6l0= X-Received: by 2002:adf:fd48:0:b0:332:e9f7:9a99 with SMTP id h8-20020adffd48000000b00332e9f79a99mr4703218wrs.43.1700959077474; Sat, 25 Nov 2023 16:37:57 -0800 (PST) Received: from localhost.localdomain (93-34-89-13.ip49.fastwebnet.it. [93.34.89.13]) by smtp.googlemail.com with ESMTPSA id v19-20020adfd053000000b0032f9688ea48sm7735249wrh.10.2023.11.25.16.37.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Nov 2023 16:37:57 -0800 (PST) From: Christian Marangi To: Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , David Epping , Christian Marangi , Harini Katakam , "Russell King (Oracle)" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [net-next PATCH 3/3] net: phy: add support for PHY package MMD read/write Date: Sun, 26 Nov 2023 01:37:48 +0100 Message-Id: <20231126003748.9600-3-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231126003748.9600-1-ansuelsmth@gmail.com> References: <20231126003748.9600-1-ansuelsmth@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Sat, 25 Nov 2023 16:38:23 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783584895498660419 X-GMAIL-MSGID: 1783584895498660419 Some PHY in PHY package may require to read/write MMD regs to correctly configure the PHY package. Add support for these additional required function in both lock and no lock variant. Signed-off-by: Christian Marangi --- include/linux/phy.h | 74 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 74 insertions(+) diff --git a/include/linux/phy.h b/include/linux/phy.h index 984bca9a82f4..1799133c8387 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -2067,6 +2067,80 @@ static inline int __phy_package_write(struct phy_device *phydev, return __mdiobus_write(phydev->mdio.bus, addr, regnum, val); } +static inline int phy_package_read_mmd(struct phy_device *phydev, + unsigned int addr_offset, int devad, + u32 regnum) +{ + struct phy_package_shared *shared = phydev->shared; + struct mii_bus *bus = phydev->mdio.bus; + int addr, val; + + if (!shared || shared->base_addr + addr_offset > PHY_MAX_ADDR) + return -EIO; + + addr = shared->base_addr + addr_offset; + + phy_lock_mdio_bus(phydev); + mmd_phy_indirect(bus, addr, devad, regnum); + val = __mdiobus_read(bus, addr, MII_MMD_DATA); + phy_unlock_mdio_bus(phydev); + + return val; +} + +static inline int __phy_package_read_mmd(struct phy_device *phydev, + unsigned int addr_offset, int devad, + u32 regnum) +{ + struct phy_package_shared *shared = phydev->shared; + struct mii_bus *bus = phydev->mdio.bus; + int addr; + + if (!shared || shared->base_addr + addr_offset > PHY_MAX_ADDR) + return -EIO; + + addr = shared->base_addr + addr_offset; + mmd_phy_indirect(bus, addr, devad, regnum); + return __mdiobus_read(bus, addr, MII_MMD_DATA); +} + +static inline int phy_package_write_mmd(struct phy_device *phydev, + unsigned int addr_offset, int devad, + u32 regnum, u16 val) +{ + struct phy_package_shared *shared = phydev->shared; + struct mii_bus *bus = phydev->mdio.bus; + int addr, ret; + + if (!shared || shared->base_addr + addr_offset > PHY_MAX_ADDR) + return -EIO; + + addr = shared->base_addr + addr_offset; + + phy_lock_mdio_bus(phydev); + mmd_phy_indirect(bus, addr, devad, regnum); + ret = __mdiobus_write(bus, addr, MII_MMD_DATA, val); + phy_unlock_mdio_bus(phydev); + + return ret; +} + +static inline int __phy_package_write_mmd(struct phy_device *phydev, + unsigned int addr_offset, int devad, + u32 regnum, u16 val) +{ + struct phy_package_shared *shared = phydev->shared; + struct mii_bus *bus = phydev->mdio.bus; + int addr; + + if (!shared || shared->base_addr + addr_offset > PHY_MAX_ADDR) + return -EIO; + + addr = shared->base_addr + addr_offset; + mmd_phy_indirect(bus, addr, devad, regnum); + return __mdiobus_write(bus, addr, MII_MMD_DATA, val); +} + static inline bool __phy_package_set_once(struct phy_device *phydev, unsigned int b) {