From patchwork Sun Nov 26 00:37:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Marangi X-Patchwork-Id: 169813 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp2231511vqx; Sat, 25 Nov 2023 16:38:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IFFjatr0y1mbbj2wDobrYgWd84sQ2NXpVpPBRH3074SE5Uqpm9ZVoQpLy4SJtx3AsMtN0c1 X-Received: by 2002:a17:902:bb8c:b0:1cc:5ed4:7b4c with SMTP id m12-20020a170902bb8c00b001cc5ed47b4cmr7154105pls.35.1700959131192; Sat, 25 Nov 2023 16:38:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700959131; cv=none; d=google.com; s=arc-20160816; b=ScIcBYm+pzpC0+IQ2l4vIAWlaxthFbjOBwFa/9ANJ+V9qBB1hiGiL1YITs0h8rlSH3 RRrCVPKCadSQDJIR7t9ucTgs1VtNabro/ZrJOyqbPWB3VS6ACrH37qedwKL/pZnR7+3j esBjGPr6e/k0q/euh3SbgZS87mPc3Tx04m1XXEhZWPM8ZEadDqPQWS7RgSh9AJG/pA/N kdnh92zaI7HOxIO5xeqlcf+gKzLQpqBZx/ayriol9S88BdfrGZpKScQL0XOZegHt9fil jv0HobX/ARiDllS/qDNmcGUXiHXYkx3mq2YWbhPwqG0m7fAHX8DjXO+HhqqelnMQYRm/ n4hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=nawp6U3vqPYo/CUc2ds9jui4s+5qr227Har9OTpQpYc=; fh=J3u6k9w1tTJVXqrAQN6TvigFxEzuC6yecz+ZMTbdd1Q=; b=eXb/as6EsQZ8a+sHt5lBS4vmZHowCfMqhUzO/9eKDEMBBX5FmXAjbIFvRqT8FNzI1p AjcqVWiufHg39QUrvwShGbtyNWkVivfuIk4jS3VquZFt8cLSfqDSwTugozNtd5wbxHz2 yw4YSqlb3WIrx8BrzzNx9TYbnnhZ2uLIxVPOgxs6YijqErItz8sQ5Q2uhZ6lDgXdd/0V 4yXbjG6L1YwUpLv5suvG0fJ2xUWWIP4HscSvm/CK4jUaPcsK3WoY4cwS/zippDU2KQoo do6rFxL3CweJqdGR8XoyQEeMKqXJRgCWpC/6/UnDQ1bp0rg9a34xQ5fwhr6mREBbuT5c iO7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=lG99uR1O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id b15-20020a170902d50f00b001cc2216e87bsi6852352plg.351.2023.11.25.16.38.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Nov 2023 16:38:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=lG99uR1O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 93D7D8062916; Sat, 25 Nov 2023 16:38:20 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230138AbjKZAhy (ORCPT + 99 others); Sat, 25 Nov 2023 19:37:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229825AbjKZAhw (ORCPT ); Sat, 25 Nov 2023 19:37:52 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CAB013E; Sat, 25 Nov 2023 16:37:58 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-332c0c32d19so2111564f8f.3; Sat, 25 Nov 2023 16:37:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700959076; x=1701563876; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=nawp6U3vqPYo/CUc2ds9jui4s+5qr227Har9OTpQpYc=; b=lG99uR1O5q5MdIn5x/FUuSNHRbkbT4zuCVS2sNNuM/0u1/59fR8KpjUek+dcEKuFSv ahXlv0Yky0myjpzDujCjxbsUzdVAL62IJJYuqt8brYXD7SFikRF2k1v9RalwCGpD/PMf kaVoKqppu+mS6aFZ6bWRSCcLjGIu+7Nkb1Jhg7rlv+a+G/+koY1cFlEsB8VQEwYubopM 6kj3+90sU+ply1oygzMPTQuvGPh3d0Opjaf1lyY3hmKXSte7Yhh4PsK/Aqnd7Zrguwk1 D9x7WFNWRNlcbqIn9MEKNQyMT9ZwMEW74bKx/dYV/lHZHeeCyjs1MMMsSrct8CE1ozQ8 du2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700959076; x=1701563876; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nawp6U3vqPYo/CUc2ds9jui4s+5qr227Har9OTpQpYc=; b=iMQWcZBsfFIPZxp+/PCajrzSOpYlCbBSB2ntq4ZU1y3D4VDP8CE56jcz8utHZCACyr QEBNv3zcgJtl4Wh0kA6f7wVgJ34+RfhhSG3tUvC/lq4nGo1KDwbsgcqGl7HKVTuOkgsi RQlSNiqhHnRmjhXrhsIgDhZAiQE4ZFMZHPuweQsq5GDv/039kKFid490VFqpQB1HFnbX /3rcbxGqoZ+IYbP0FkU1gw8g5i8zaXvOWeo/lxbK9Gsp0IQ3GiBAwLI4ivHKi5FjZnlJ BMhxslDtVIC8ZiVe0Y8vLHwU1UJz2htDCJqdy3DoOQASEyxbrEs8q9Bwxd+l4bzZzTPB bBBQ== X-Gm-Message-State: AOJu0Yx/dcCcbPjYennV8fhI8oqYUY/EgFYqU0AGcUhY/JvHP//qsWLF tmTVx6CU7IdUKkjR/+W8+QM= X-Received: by 2002:a5d:68cc:0:b0:332:ef1e:bb96 with SMTP id p12-20020a5d68cc000000b00332ef1ebb96mr2163557wrw.36.1700959076464; Sat, 25 Nov 2023 16:37:56 -0800 (PST) Received: from localhost.localdomain (93-34-89-13.ip49.fastwebnet.it. [93.34.89.13]) by smtp.googlemail.com with ESMTPSA id v19-20020adfd053000000b0032f9688ea48sm7735249wrh.10.2023.11.25.16.37.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Nov 2023 16:37:56 -0800 (PST) From: Christian Marangi To: Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , David Epping , Christian Marangi , Harini Katakam , "Russell King (Oracle)" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [net-next PATCH 2/3] net: phy: move mmd_phy_indirect to generic header Date: Sun, 26 Nov 2023 01:37:47 +0100 Message-Id: <20231126003748.9600-2-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231126003748.9600-1-ansuelsmth@gmail.com> References: <20231126003748.9600-1-ansuelsmth@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sat, 25 Nov 2023 16:38:20 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783584922321199940 X-GMAIL-MSGID: 1783584922321199940 Move mmd_phy_indirect function from phy-core to generic phy.h to permit future usage for PHY package read/write_mmd. Signed-off-by: Christian Marangi --- drivers/net/phy/phy-core.c | 14 -------------- include/linux/phy.h | 14 ++++++++++++++ 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/net/phy/phy-core.c b/drivers/net/phy/phy-core.c index 966c93cbe616..b4f80847eefd 100644 --- a/drivers/net/phy/phy-core.c +++ b/drivers/net/phy/phy-core.c @@ -526,20 +526,6 @@ int phy_speed_down_core(struct phy_device *phydev) return 0; } -static void mmd_phy_indirect(struct mii_bus *bus, int phy_addr, int devad, - u16 regnum) -{ - /* Write the desired MMD Devad */ - __mdiobus_write(bus, phy_addr, MII_MMD_CTRL, devad); - - /* Write the desired MMD register address */ - __mdiobus_write(bus, phy_addr, MII_MMD_DATA, regnum); - - /* Select the Function : DATA with no post increment */ - __mdiobus_write(bus, phy_addr, MII_MMD_CTRL, - devad | MII_MMD_CTRL_NOINCR); -} - /** * __phy_read_mmd - Convenience function for reading a register * from an MMD on a given PHY. diff --git a/include/linux/phy.h b/include/linux/phy.h index 8253c7871d68..984bca9a82f4 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -1316,6 +1316,20 @@ static inline int __phy_modify_changed(struct phy_device *phydev, u32 regnum, regnum, mask, set); } +static inline void mmd_phy_indirect(struct mii_bus *bus, int phy_addr, int devad, + u16 regnum) +{ + /* Write the desired MMD Devad */ + __mdiobus_write(bus, phy_addr, MII_MMD_CTRL, devad); + + /* Write the desired MMD register address */ + __mdiobus_write(bus, phy_addr, MII_MMD_DATA, regnum); + + /* Select the Function : DATA with no post increment */ + __mdiobus_write(bus, phy_addr, MII_MMD_CTRL, + devad | MII_MMD_CTRL_NOINCR); +} + /* * phy_read_mmd - Convenience function for reading a register * from an MMD on a given PHY.