From patchwork Sat Nov 25 16:11:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 169645 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp1803024vqx; Sat, 25 Nov 2023 00:13:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IHou5hfMpi+odL79tDwLgZyTzXqRdudzTvANVJqOGPO8TYuchRy0Rr8TwHL08p/hYdVmgPQ X-Received: by 2002:a05:6808:191b:b0:3b8:412a:e75b with SMTP id bf27-20020a056808191b00b003b8412ae75bmr7362321oib.10.1700900016001; Sat, 25 Nov 2023 00:13:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700900015; cv=none; d=google.com; s=arc-20160816; b=dD4lSP5RrS9KM4B8B8vdH7fO+0XEujchdF3rJNlGSyOpU2HfFHQR/6gveD37RNbsYx kBUP9rmHRd+2B1YgxSiLoUGG2ZRC6pYxfT7SjFVbmkl4QODo8ILQ9En4rbSkf4xiHHY6 zmkbbn0II55ZQ+Auq2Bp5vCEWTIHbGI5pUAdNU1xr22lagfjWazm7oPw17fMMDghLe06 7CkGMae96B3+JcjCXlLWEWaCXHFF8TxkfV7CYQa6y9az5NnVpJO84sytcCtcoUBVwhhK Fuovmr+YiKBp0L/mrC7sqQJ/ZqCL2yiPRrmbjlaNu1g4lMKWGMyv8m6NBORtBiYDnj/2 1eIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Ilualq1MUEYYRqmt8PF8a/Y8LFdYvuw0frNNzhzDiC4=; fh=eu2llfKjKKC0QBUtW6YWJ13du6subP7SB8ZN6DjSWMA=; b=cUXid9tupd0sOERoYDSrV0gTdB3N6hsLPLEKd1fWmpxfS44pqXrGpt6uOrQX3n8aWz 0gM+WRmvNzGGz4A+xTQ5mIeMtpgJbIXKNcH3phFs1Ko3QhRqwViesuh+SCcJFVUWWChy DhDq5g60MJLFbraHWGYMORO78CDTvlF9MMs+1oT0hWLrQKBas5vEIYnfRrkLbvuUHFoO +Egn6nlYniOLuWoou4K8yq89YYHTV+mCTIF8x4158UurK8EmPsKN5PnyySJEiH7Ve691 0RIfb8b/svoQHo9ayyVFlzl0s5X3YtZgPvyOdQKknOtPdGo71B7QUeOyz8CU7Vs8AiGA BAXA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id f24-20020a63dc58000000b005bd2b888545si5119671pgj.119.2023.11.25.00.13.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Nov 2023 00:13:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id A88EA8040D5C; Sat, 25 Nov 2023 00:13:31 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231800AbjKYIM4 (ORCPT + 99 others); Sat, 25 Nov 2023 03:12:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231755AbjKYIMu (ORCPT ); Sat, 25 Nov 2023 03:12:50 -0500 Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87BDC10F7; Sat, 25 Nov 2023 00:12:55 -0800 (PST) Received: from mail.maildlp.com (unknown [172.19.163.216]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4Scl2p1Vm2z4f3kjX; Sat, 25 Nov 2023 16:12:50 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.75]) by mail.maildlp.com (Postfix) with ESMTP id F39F91A01F4; Sat, 25 Nov 2023 16:12:52 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP2 (Coremail) with SMTP id Syh0CgCnSkmCrGFlWcLEBw--.36822S5; Sat, 25 Nov 2023 16:12:52 +0800 (CST) From: Kemeng Shi To: tytso@mit.edu, adilger.kernel@dilger.ca Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/8] ext4: remove unneeded return value of ext4_mb_release_context Date: Sun, 26 Nov 2023 00:11:38 +0800 Message-Id: <20231125161143.3945726-4-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20231125161143.3945726-1-shikemeng@huaweicloud.com> References: <20231125161143.3945726-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: Syh0CgCnSkmCrGFlWcLEBw--.36822S5 X-Coremail-Antispam: 1UD129KBjvdXoWrKFyDWF1UXFyDJw1kCw1kuFg_yoWkuwb_GF WUGr4xCFyrA34fC3WFy3yrtFZagrs3Ar1jqFs5tFW3uayUXr4xCw1qyrn8ZrZrWr48A343 Crn8Cr1UCrZaqjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbfxYFVCjjxCrM7AC8VAFwI0_Xr0_Wr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JFv_Gryl82 xGYIkIc2x26280x7IE14v26r1rM28IrcIa0xkI8VCY1x0267AKxVW8JVW5JwA2ocxC64kI II0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7 xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2 z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4 xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v2 6r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x0EwI xGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480 Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7 IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k2 6cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxV AFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07jy0PhUUUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-Spam-Status: No, score=-0.8 required=5.0 tests=DATE_IN_FUTURE_06_12, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Sat, 25 Nov 2023 00:13:31 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783522935183211900 X-GMAIL-MSGID: 1783522935183211900 Function ext4_mb_release_context always return 0 and the return value is never used. Just remove unneeded return value of ext4_mb_release_context. Signed-off-by: Kemeng Shi Reviewed-by: Jan Kara --- fs/ext4/mballoc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 765b62729..f79e87ad3 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -5939,7 +5939,7 @@ static void ext4_mb_add_n_trim(struct ext4_allocation_context *ac) /* * release all resource we used in allocation */ -static int ext4_mb_release_context(struct ext4_allocation_context *ac) +static void ext4_mb_release_context(struct ext4_allocation_context *ac) { struct ext4_sb_info *sbi = EXT4_SB(ac->ac_sb); struct ext4_prealloc_space *pa = ac->ac_pa; @@ -5976,7 +5976,6 @@ static int ext4_mb_release_context(struct ext4_allocation_context *ac) if (ac->ac_flags & EXT4_MB_HINT_GROUP_ALLOC) mutex_unlock(&ac->ac_lg->lg_mutex); ext4_mb_collect_stats(ac); - return 0; } static int ext4_mb_discard_preallocations(struct super_block *sb, int needed)