Message ID | 20231125-msm8953-misc-fixes-v2-1-df86655841d9@z3ntu.xyz |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp1896972vqx; Sat, 25 Nov 2023 04:20:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IEC39UNBkVz/HkI4k8aUp/8/Z6CG+aVZv2QmvR0eUfFgMV2rZQpIfCGD3LwNVhg0FllxJBU X-Received: by 2002:a17:90b:3808:b0:25e:a8ab:9157 with SMTP id mq8-20020a17090b380800b0025ea8ab9157mr5734320pjb.22.1700914826583; Sat, 25 Nov 2023 04:20:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700914826; cv=none; d=google.com; s=arc-20160816; b=RwNHgEu9Xth8QTUTEeFLjaQvMw2pjnmt6Xo77DyE7WcwwuOi1mTZpVvqy8CywUx9Hg DVxO3r9Q79xgaFcS2OKMsM64E2gzrmww9osGAOlquxI11tLUMPDR57SQn5eJ5YgCjJ0t SUAJPn5SvFYm3tlI883HkJcTNNOYXHGVPN51qeAZ5ijTTHX4o9m/dUaWle/4PLTE2JpR rF8ePRERojFmXymUIqxQj+wdEgsRwlLqhT1jFgIDkZZZQU13a53g0lGtts79MVQsLrdj z9qNKB9TPvgNFTMU2k+ZK8aarpjuNmddSHw70cgLNu+xbHVcg34qzTHXFzzmmT6zgJwD g7zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=wLNC2dQRxNwbdqbdpPBiPNSyavZeuvFV/OJxhNNf1w4=; fh=rSFdVjeHOpLchEnZwQw2X9nJEgNS/Y9JNZLx42s16JY=; b=RyLMUmufSetBOUhtrQFSertbQRCUV8MBdm9+vyyilGeQuyqHvahvcR7+rXhVdaIr9V AbpB8wULw3E0fk9wu1xok4txUz+bfWeTMQVHPfMai0M96rAujWi8m/bGhBbjwKOWX4nO yG83idW6/A6exMniz98FdzaDieVaCswC6VQUwTN+UzB25ypkWc+cZ+HSDneT4sB9YdWL 7jXfYh3X3E7xjLUkNVtqQUJblBUzBlHOeFx5POld40HroYhVlCFpfdDP79WzeY5MdeIm WXSB3aT8q2zgkAfjPqGj0V2PsQnff/6Fhaw8CoCLJF97km1H65NgpU9XMNUUqIXhjWO9 /gIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@z3ntu.xyz header.s=z3ntu header.b=wTpPLHW8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=z3ntu.xyz Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id b7-20020a17090a6e0700b00262e5a82047si5775150pjk.44.2023.11.25.04.20.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Nov 2023 04:20:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@z3ntu.xyz header.s=z3ntu header.b=wTpPLHW8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=z3ntu.xyz Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id F16358045BEF; Sat, 25 Nov 2023 04:20:23 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231960AbjKYMUH (ORCPT <rfc822;kernel.ruili@gmail.com> + 99 others); Sat, 25 Nov 2023 07:20:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229483AbjKYMUD (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 25 Nov 2023 07:20:03 -0500 Received: from mail.z3ntu.xyz (mail.z3ntu.xyz [128.199.32.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA295D6; Sat, 25 Nov 2023 04:20:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=z3ntu.xyz; s=z3ntu; t=1700914777; bh=UdGEv17E3hADi12SsQvKXsMSfqGDSsuNeaYFESGrjdk=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=wTpPLHW8z7ca6AJhErXFAC4R4WnTbREJAmiDLia0GxyUp5/5Q4KHlTnKg6iDlkPna kTo3ROnMqYdJnI/wQnZYfh3FXJqaxfSDzd6CXb/RqR+dg7BcOM00LVIPdIuOuK1jVu CYtOC+Wfe6hlDyKLngymph9mCDMh31rQS4pYFshg= From: Luca Weiss <luca@z3ntu.xyz> Date: Sat, 25 Nov 2023 13:19:27 +0100 Subject: [PATCH v2 1/2] arm64: dts: qcom: msm8953: Set initial address for memory MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20231125-msm8953-misc-fixes-v2-1-df86655841d9@z3ntu.xyz> References: <20231125-msm8953-misc-fixes-v2-0-df86655841d9@z3ntu.xyz> In-Reply-To: <20231125-msm8953-misc-fixes-v2-0-df86655841d9@z3ntu.xyz> To: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org> Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss <luca@z3ntu.xyz> X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1096; i=luca@z3ntu.xyz; h=from:subject:message-id; bh=UdGEv17E3hADi12SsQvKXsMSfqGDSsuNeaYFESGrjdk=; b=owEBbQKS/ZANAwAIAXLYQ7idTddWAcsmYgBlYeZXvatWXYJzXEZ6FjI5/HS4cRAQyBJuohxSV V7kqHpbO1KJAjMEAAEIAB0WIQQ5utIvCCzakboVj/py2EO4nU3XVgUCZWHmVwAKCRBy2EO4nU3X VhMHEACjjLgF+I7uJI59zY9sXv37xkBYt5o69pWh54DCFVOcMb1RHJ0Yop4cvkZmwa9hA/S+gBI sDmfSXsYGvqpZ3TdHf4uyZ4Hfxsb27bv+ltjLvluvzZColbtZVKK9tmvT9j9kq2RixrUWQFBUME 1DE9+74FQKqX9hTKocOwS4nkBcv3rV4bgnoz+ZZJ3+zQMi4ZCDEYKcSSOkFP2CI9h+4OUT1GK3V q3W5vF8M+972KQxSC/Yi375dIpqyqeHlU/pLISeVs+TTu+vZVo/hPRruAtyT71oe1DyFwFcU7c8 7L26cQuu3IMWkaFGkOSBj51727SsTHEGFrFLEYo7jMoQ50BJjAnLBIPJAU2t8DeHQCNgkR4AVql pms9lVmHXIV8X/xxJLp9D9ZhlF4pmr1+GFhor5xkF9S1pn12jk966c0NQOwDmgdjOoaYy/q8sZG MGx1TxLnsS3LAiIUJ+3RlJcj8p/msQD4lN5iL1rP/EnLi6QGodBqyjxd1OlEKzjsM2JqBMUIKHw 7M5QpIYRwFHZwairzNMfMOs8ktp0k/7uApMZ9U1HPmHLEB7tPWNrt8f5Ru9AEB660ylGNReATA+ cOwOJ+WnPQjjC9Zk3baI2ESMO4HDIjJDCO2oxXuKTyWUHcCSA01ou9UElDzL+7K9gIkJfNrJlSX bcOvLIVjE1KtfnQ== X-Developer-Key: i=luca@z3ntu.xyz; a=openpgp; fpr=BD04DA24C971B8D587B2B8D7FAF69CF6CD2D02CD X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Sat, 25 Nov 2023 04:20:24 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783538464944384790 X-GMAIL-MSGID: 1783538464944384790 |
Series |
Small dtsi fixes for msm8953 SoC
|
|
Commit Message
Luca Weiss
Nov. 25, 2023, 12:19 p.m. UTC
The dtbs_check really doesn't like having memory without reg set.
The base address depends on the amount of RAM you have:
<= 2.00 GiB RAM: 0x80000000
= 3.00 GiB RAM: 0x40000000
= 3.75 GiB RAM: 0x10000000
(more does not fit into the 32-bit physical address space)
So, let's pick one of the values, 0x10000000 which is used on devices
with 3.75 GiB RAM. Since the bootloader will update it to what's present
on the device it doesn't matter too much.
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
arch/arm64/boot/dts/qcom/msm8953.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On Sat, Nov 25, 2023 at 01:19:27PM +0100, Luca Weiss wrote: > The dtbs_check really doesn't like having memory without reg set. > > The base address depends on the amount of RAM you have: > > <= 2.00 GiB RAM: 0x80000000 > = 3.00 GiB RAM: 0x40000000 > = 3.75 GiB RAM: 0x10000000 > (more does not fit into the 32-bit physical address space) > > So, let's pick one of the values, 0x10000000 which is used on devices > with 3.75 GiB RAM. Since the bootloader will update it to what's present > on the device it doesn't matter too much. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > --- > arch/arm64/boot/dts/qcom/msm8953.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8953.dtsi b/arch/arm64/boot/dts/qcom/msm8953.dtsi > index e7de7632669a..a3ba24ca599b 100644 > --- a/arch/arm64/boot/dts/qcom/msm8953.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8953.dtsi > @@ -174,10 +174,10 @@ scm: scm { > }; > }; > > - memory { Wouldn't it be sufficient to add @0 here, to please dtbs_check? Regards, Bjorn > + memory@10000000 { > device_type = "memory"; > /* We expect the bootloader to fill in the reg */ > - reg = <0 0 0 0>; > + reg = <0 0x10000000 0 0>; > }; > > pmu { > > -- > 2.43.0 >
On Sonntag, 3. Dezember 2023 05:20:23 CET Bjorn Andersson wrote: > On Sat, Nov 25, 2023 at 01:19:27PM +0100, Luca Weiss wrote: > > The dtbs_check really doesn't like having memory without reg set. > > > > The base address depends on the amount of RAM you have: > > <= 2.00 GiB RAM: 0x80000000 > > > > = 3.00 GiB RAM: 0x40000000 > > = 3.75 GiB RAM: 0x10000000 > > > > (more does not fit into the 32-bit physical address space) > > > > So, let's pick one of the values, 0x10000000 which is used on devices > > with 3.75 GiB RAM. Since the bootloader will update it to what's present > > on the device it doesn't matter too much. > > > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > > --- > > > > arch/arm64/boot/dts/qcom/msm8953.dtsi | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/msm8953.dtsi > > b/arch/arm64/boot/dts/qcom/msm8953.dtsi index e7de7632669a..a3ba24ca599b > > 100644 > > --- a/arch/arm64/boot/dts/qcom/msm8953.dtsi > > +++ b/arch/arm64/boot/dts/qcom/msm8953.dtsi > > @@ -174,10 +174,10 @@ scm: scm { > > > > }; > > > > }; > > > > - memory { > > Wouldn't it be sufficient to add @0 here, to please dtbs_check? The checker itself also seems to be okay with memory@0 and no other change, but there's this warning with W=1 arch/arm64/boot/dts/qcom/msm8953.dtsi:177.11-181.4: Warning (unique_unit_address_if_enabled): /memory@0: duplicate unit-address (also used in node /soc@0) So probably we should still try to put it at a reasonable address like 0x10000000? Regards Luca > > Regards, > Bjorn > > > + memory@10000000 { > > > > device_type = "memory"; > > /* We expect the bootloader to fill in the reg */ > > > > - reg = <0 0 0 0>; > > + reg = <0 0x10000000 0 0>; > > > > }; > > > > pmu {
diff --git a/arch/arm64/boot/dts/qcom/msm8953.dtsi b/arch/arm64/boot/dts/qcom/msm8953.dtsi index e7de7632669a..a3ba24ca599b 100644 --- a/arch/arm64/boot/dts/qcom/msm8953.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8953.dtsi @@ -174,10 +174,10 @@ scm: scm { }; }; - memory { + memory@10000000 { device_type = "memory"; /* We expect the bootloader to fill in the reg */ - reg = <0 0 0 0>; + reg = <0 0x10000000 0 0>; }; pmu {