From patchwork Fri Nov 24 08:47:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 169304 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp1010527vqx; Fri, 24 Nov 2023 00:50:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IFBQXx7xqMiiTahrXxe4x3ZVePh/D3c2o0ZlDhYR6RZulSsndoSd0m3c0lleVhKsjWPEzFs X-Received: by 2002:a05:6a20:3caa:b0:189:ca96:aa1b with SMTP id b42-20020a056a203caa00b00189ca96aa1bmr2496005pzj.53.1700815804817; Fri, 24 Nov 2023 00:50:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700815804; cv=none; d=google.com; s=arc-20160816; b=f8M7Fdo1o5wWZldDXxSNf2HiydjLuP5gVC00bORWj5Bu3SPn8RysiM1JFjjpMugSlf QHujJkSpQ4+15kVmCLQQ+QVEXH2lMeKDXZyO9co7Doag3RYHIYjUrpOubu0/bDoraWhr N4qHEQfZR3GobTL9YpDFsOlcFx3gGjBLt13uPKjHVshLg8CR0jLFJNSU3NbSpIT3qXSZ NiarPKwRR28B0PXL0HvG6IcwW0TM6jR55dBw2vv6VEmXw44zetcqQ6sUY8UMR63ehuu9 L+Hv6T9UQvUO2TZkZm5yndFmSJxZ9evfeGzKroM9GAWdyXMKmT4Y/v6yGzYuAhcKwoi3 hphQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=QP7XY4fmTz60pkcYxuQfpqnh3RDfuR8C0vo2707NHqs=; fh=W+eSkce8uvUdQ8A1Dj5F8klEXQy967eJmFo02igvYfU=; b=bRy/6z9qZdVNuz96NoXw0KEuoqjx4TZ7G/MiOlzR7h2GwxKpOIAB1yvN1WxU+84cHw rOXp23rMTGe7wVyLeeF1BAf+BGIv3vZnTSkbTK7DXg1hYia7Jp1FBJW5rwyQU4sS7RMF 3+l5KlD4Dm8NB5WxVBd4yBp2Kpiw0jAHDzvJIF4eF/hKsp3AcjW2xy6lMEg+PJQ3YEuw qfdOQltt6JzyEa+QVYmVlMoiwmhxoBzrYPaRaD0VodZTbQmfz8Bp9CA/Ddv0uqc5sGMh EBH20tztNgaS4I3qok9pYH9ei8zAJ6FvbD6opqv/W08FQP4bJYt9qssPYt+y1UVa0c6M jiEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=hg+mOEjY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id p24-20020a056a000a1800b006cb90e7f47csi3054905pfh.199.2023.11.24.00.50.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 00:50:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=hg+mOEjY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 26424832EF6D; Fri, 24 Nov 2023 00:49:26 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233108AbjKXItO (ORCPT + 99 others); Fri, 24 Nov 2023 03:49:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232938AbjKXIsp (ORCPT ); Fri, 24 Nov 2023 03:48:45 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52DE7172D; Fri, 24 Nov 2023 00:48:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700815732; x=1732351732; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=3vtdvE3QnntLHyxMXQ0tiVPrz7diOVGb+IPBdmkCkGQ=; b=hg+mOEjYHdXM+rYuniWLvybL+Zpa2socPyGdw8LjUdKAuyyjkhWTTjyZ /Z7vz10i/npzDmbVR9jBHMUteOamARr7CEnOo56o+jgJS5Wybjm+CIjr4 fcm9eLoi8aVZUB6oap+n13Uon+ZVFfDblZp6a/adxvY212B6z4UVJmvqx nAcAr0I9F2tL67g0ABgdhmBFRR8kDnGduy2AEWkRbJKMIv1+sTBSMSJxU 8GaxrwB0+PIhZqMRy2siIF3KOodBviJPBFrGqqpQOvBYg22yDjQbBgx57 Oosozw8jzV3O1We2xySsZq92p2yy7dQ+qXzG0FCwpRFtatOrtGcTFggbU g==; X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="456728959" X-IronPort-AV: E=Sophos;i="6.04,223,1695711600"; d="scan'208";a="456728959" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2023 00:48:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="760900546" X-IronPort-AV: E=Sophos;i="6.04,223,1695711600"; d="scan'208";a="760900546" Received: from mvlasov-mobl1.ger.corp.intel.com (HELO localhost) ([10.251.220.89]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2023 00:48:48 -0800 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= To: "John W. Linville" , Kalle Valo , Larry Finger , linux-wireless@vger.kernel.org, Ping-Ke Shih , Bjorn Helgaas , linux-kernel@vger.kernel.org Cc: =?utf-8?q?Ilpo_J=C3=A4rvinen?= Subject: [PATCH v2 09/10] wifi: rtlwifi: Remove unused PCI related defines and struct Date: Fri, 24 Nov 2023 10:47:24 +0200 Message-Id: <20231124084725.12738-10-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20231124084725.12738-1-ilpo.jarvinen@linux.intel.com> References: <20231124084725.12738-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 24 Nov 2023 00:49:26 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783434633172741144 X-GMAIL-MSGID: 1783434633172741144 The rtlwifi driver comes with a number of PCI related defines that are unused and many would be provided by PCI core anyway if they'd be needed again. Similarly, the struct rtl_pci_capabilities_header is unused and no driver should come up their own way to access PCI Capabilities anyway. Remove the unused/duplicated PCI related defines and struct. Signed-off-by: Ilpo Järvinen --- drivers/net/wireless/realtek/rtlwifi/pci.h | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.h b/drivers/net/wireless/realtek/rtlwifi/pci.h index d6307197dfea..8bb35506ab1e 100644 --- a/drivers/net/wireless/realtek/rtlwifi/pci.h +++ b/drivers/net/wireless/realtek/rtlwifi/pci.h @@ -44,18 +44,6 @@ #define ATI_DEVICE_ID 0x7914 #define AMD_VENDOR_ID 0x1022 -#define PCI_MAX_BRIDGE_NUMBER 255 -#define PCI_MAX_DEVICES 32 -#define PCI_MAX_FUNCTION 8 - -#define PCI_CONF_ADDRESS 0x0CF8 /*PCI Configuration Space Address */ -#define PCI_CONF_DATA 0x0CFC /*PCI Configuration Space Data */ - -#define PCI_CLASS_BRIDGE_DEV 0x06 -#define PCI_SUBCLASS_BR_PCI_TO_PCI 0x04 -#define PCI_CAPABILITY_ID_PCI_EXPRESS 0x10 -#define PCI_CAP_ID_EXP 0x10 - #define U1DONTCARE 0xFF #define U2DONTCARE 0xFFFF #define U4DONTCARE 0xFFFFFFFF @@ -113,11 +101,6 @@ enum pci_bridge_vendor { PCI_BRIDGE_VENDOR_MAX, }; -struct rtl_pci_capabilities_header { - u8 capability_id; - u8 next; -}; - /* In new TRX flow, Buffer_desc is new concept * But TX wifi info == TX descriptor in old flow * RX wifi info == RX descriptor in old flow