Message ID | 20231124020237.27116-5-jarkko@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp841178vqx; Thu, 23 Nov 2023 18:03:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IEKnfI5jhYtd1KyQIR9U4Ea24F6gnCxWRIa8z70aWOBL5a5FJsaAQ8bo+WFyl7d5Lh/ZB1T X-Received: by 2002:a6b:f704:0:b0:7b3:52d5:4209 with SMTP id k4-20020a6bf704000000b007b352d54209mr1270170iog.17.1700791404302; Thu, 23 Nov 2023 18:03:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700791404; cv=none; d=google.com; s=arc-20160816; b=gGoV0VYnFABAl2Fy5lmJ4/BjgWdbxdJgjVY5gOgSNfkGEUMHvNDIqlhtDcE2rFdCpY bFkT1Tf+1pUkfMj34XspQQRAkpdJeaKh7A5gnLtqiwrnQXKoWp3eZDQLYulR5Wa5P4XV qa6wo9B+ZeQubxPTv2XBpTOHbYTOeNaw4FrGIFnzWLwVRtoSSaOIl5nso82pdkQynKek 9+w+m5DgvZ8x7GtycxQeE6n8icawgzblMYtGoR4mRVqufi/t+F7mHWtydkzr+qs9kFpc mKAzQ5t+A5ZLtFS+UNX3mXwTXf10sHjsNsVU8FgRyn58ApYxYc4v/0uw5P481B1jmATd eagw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=IvWguukgndAnT1zZ2JCal7278RS3u0WQUiTyPBWQQiQ=; fh=RBX0EO7BCt4n4lnvPBYFN24o6jFly+IlKRm41n8yo0s=; b=h5/vXFiZAZRCaT7TXaPzSGAFxprOwgNUrC1Xy4405vS7mXaTxAvStqBFDR8l0IAjUR SnE25Os7gnaEeOYWhWN9vyyCnF3F6uB3yPuuBESYnEG3n/DX1Anr/Alfx2Sr8vNoSKop LFffgRUkbLHp2bUJyiMSI0OixA1DR/dPst/uR+7slOVk5a9+Kprcdr5IDfOf39evpJQw 1nhWDIFzzdcyHBA0ckHClPh7PkUDXpe+6MPbxoWpXZQnQoyIKQYU01nzSMjWAyBnBlsw +bptMoAwTTOzpGG9JR8eb/6a3aRMWPy0vssh6GTpNf1nUGVcW/yXZ62VWG5b6r7zuG4p eh0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Z1rX6Y/q"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id y21-20020a63e255000000b0058974d3c296si2529911pgj.815.2023.11.23.18.03.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 18:03:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Z1rX6Y/q"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 7F10482DAFE0; Thu, 23 Nov 2023 18:03:21 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232704AbjKXCDK (ORCPT <rfc822;ouuuleilei@gmail.com> + 99 others); Thu, 23 Nov 2023 21:03:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231157AbjKXCCz (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 23 Nov 2023 21:02:55 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8E2A171E for <linux-kernel@vger.kernel.org>; Thu, 23 Nov 2023 18:02:54 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ABA6FC433C8; Fri, 24 Nov 2023 02:02:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700791374; bh=gORzZnTnBE2H3oHce9S3/9lGlc/hZRFZ0MDxFGFZxTc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z1rX6Y/qnWHG7DB8DhMf+Oo6R83MLcYs5VO8KN29H1f0Uno04N+VG8nWMYbLrOrM9 54L5a/kFUw3OX1GkLd+pYmXX8puiHLJP3k5e1+LA2x35G7Qukcc9SYCnagVaR17CYu pHrfN2Mw+MrG78Iozu7C4tYfBxgmz11+rI3iB7aHPk3lCHVv1AQ0F7XdEH2ObXbhkd /ASdym8QobCwuqXiUaeSQfh/5K2HJBn5ttlE4Puh9X1TtTQG2d3spuGB7OfIOBv3pH U3MJ0AFdGXS0fCNTi+7S34YRf7QxWXD/n2emLIaB0OolgbahX2jOzPBFQhZMkQh09r Y3jC5GHTQH3nw== From: Jarkko Sakkinen <jarkko@kernel.org> To: linux-integrity@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Jarkko Sakkinen <jarkko@kernel.org>, James Bottomley <James.Bottomley@HansenPartnership.com>, William Roberts <bill.c.roberts@gmail.com>, Stefan Berger <stefanb@linux.ibm.com>, David Howells <dhowells@redhat.com>, Jason Gunthorpe <jgg@ziepe.ca>, Mimi Zohar <zohar@linux.ibm.com>, Mario Limonciello <mario.limonciello@amd.com>, Jerry Snitselaar <jsnitsel@redhat.com> Subject: [PATCH v6 4/8] tpm: Update struct tpm_buf documentation comments Date: Fri, 24 Nov 2023 04:02:33 +0200 Message-ID: <20231124020237.27116-5-jarkko@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231124020237.27116-1-jarkko@kernel.org> References: <20231124020237.27116-1-jarkko@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 23 Nov 2023 18:03:21 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783409047542143936 X-GMAIL-MSGID: 1783409047542143936 |
Series |
Extend struct tpm_buf to support sized buffers (TPM2B)
|
|
Commit Message
Jarkko Sakkinen
Nov. 24, 2023, 2:02 a.m. UTC
Remove deprecated portions and document enum values.
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
---
v1 [2023-11-21]: A new patch.
v2 [2023-11-24]: Refined the commit message a bit.
---
include/linux/tpm.h | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
Comments
On 11/23/23 21:02, Jarkko Sakkinen wrote: > Remove deprecated portions and document enum values. > > Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org> > --- > v1 [2023-11-21]: A new patch. > v2 [2023-11-24]: Refined the commit message a bit. > --- > include/linux/tpm.h | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/include/linux/tpm.h b/include/linux/tpm.h > index bb0e8718a432..0a8c1351adc2 100644 > --- a/include/linux/tpm.h > +++ b/include/linux/tpm.h > @@ -297,15 +297,14 @@ struct tpm_header { > }; > } __packed; > > -/* A string buffer type for constructing TPM commands. This is based on the > - * ideas of string buffer code in security/keys/trusted.h but is heap based > - * in order to keep the stack usage minimal. > - */ > - > enum tpm_buf_flags { > + /* the capacity exceeded: */ was exceeded > TPM_BUF_OVERFLOW = BIT(0), > }; > > +/* > + * A string buffer type for constructing TPM commands. > + */ > struct tpm_buf { > unsigned int flags; > u8 *data; Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
On Mon Nov 27, 2023 at 10:41 PM EET, Stefan Berger wrote: > > > On 11/23/23 21:02, Jarkko Sakkinen wrote: > > Remove deprecated portions and document enum values. > > > > Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org> > > --- > > v1 [2023-11-21]: A new patch. > > v2 [2023-11-24]: Refined the commit message a bit. > > --- > > include/linux/tpm.h | 9 ++++----- > > 1 file changed, 4 insertions(+), 5 deletions(-) > > > > diff --git a/include/linux/tpm.h b/include/linux/tpm.h > > index bb0e8718a432..0a8c1351adc2 100644 > > --- a/include/linux/tpm.h > > +++ b/include/linux/tpm.h > > @@ -297,15 +297,14 @@ struct tpm_header { > > }; > > } __packed; > > > > -/* A string buffer type for constructing TPM commands. This is based on the > > - * ideas of string buffer code in security/keys/trusted.h but is heap based > > - * in order to keep the stack usage minimal. > > - */ > > - > > enum tpm_buf_flags { > > + /* the capacity exceeded: */ > > was exceeded +1, agreed a better form :-) > > > TPM_BUF_OVERFLOW = BIT(0), > > }; > > > > +/* > > + * A string buffer type for constructing TPM commands. > > + */ > > struct tpm_buf { > > unsigned int flags; > > u8 *data; > > Reviewed-by: Stefan Berger <stefanb@linux.ibm.com> If possible give this to the James' patch set, thank you for the review. BR, Jarkko
diff --git a/include/linux/tpm.h b/include/linux/tpm.h index bb0e8718a432..0a8c1351adc2 100644 --- a/include/linux/tpm.h +++ b/include/linux/tpm.h @@ -297,15 +297,14 @@ struct tpm_header { }; } __packed; -/* A string buffer type for constructing TPM commands. This is based on the - * ideas of string buffer code in security/keys/trusted.h but is heap based - * in order to keep the stack usage minimal. - */ - enum tpm_buf_flags { + /* the capacity exceeded: */ TPM_BUF_OVERFLOW = BIT(0), }; +/* + * A string buffer type for constructing TPM commands. + */ struct tpm_buf { unsigned int flags; u8 *data;