From patchwork Thu Nov 23 17:25:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 169066 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp605070vqx; Thu, 23 Nov 2023 09:32:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IFJdLzXCYV7blHyfFiHOmkzywucKKShEjY15HSxDQSoxJKfDocPXPAsPXqEahzjXzI+PUfO X-Received: by 2002:aa7:9a87:0:b0:6bb:8982:411c with SMTP id x7-20020aa79a87000000b006bb8982411cmr170207pfi.8.1700760753367; Thu, 23 Nov 2023 09:32:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700760753; cv=none; d=google.com; s=arc-20160816; b=qDhKNLe7A/xAwAuwHLXtRFB/2SLGq673GI53H0/69f0Mt6L34AVlaWm20Nv2uZJv2v jSnprlNFmR/OqEzn3SlfpS14iV8M+y75kM5uBCsFLvZkQtkj/ylSbYRhrMbsQI7pUJkN XVbb0zNOmKbNxFc1UtXHiPcyyoVeDpO4UGR127q11PkTbT7kxq4sk5tBppndeth9vrH6 /0V2Jm0KXzisOT6RIq/DHPfPAZ4WfAsRrvDdPxHBoebTYi7Hq/ecIp4kknZn67ovlwhm cXPdfMtb5tsG4BVT5jHhAfWMZd8KzoMtJ/HFeX4D0UmoAEjoueNae3qnBPMakc+O47Nx GKlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=BL+OQkvdu8IoyqUBYtzyXRoQDFcBE614btAYpN/4iVI=; fh=mgEK3u4FNCVZrw2eK4ElottVljJzztdE8jidxZTIxyU=; b=KfhbXEZcoMmf3QFIayHOCKrWr6Qb/9DsL4TgRwcdygMxVDzZkvAsVgRRWvSU6V7bsY KiUdLiaHTY/hWlUjHWl8tItE6wP0kNUG6p9TU/iYDYmOH/lP/SNZCWRVy9r14pgWToWL SrVGgRiHV/E8XiOB+VrvjmAsn8XAPUK65I8KKPQY7y23gshSU/fwjFa+5OSoDtYJba3D XBgmnlPBWnpr46BndeiY0nG11gJpykWo1DyZvqHbgtbWQrMvGpiEvcc8HZY6dIbEt0kV mLTENCLDsCRu+1JYyQr7+15hZU6fQLw02WQNfw+q0k9I0E1ez4PB52r7LoC7HxC5mYYv QrnA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id bi5-20020a056a02024500b005c203ad2343si1817849pgb.94.2023.11.23.09.32.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 09:32:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 05582804E6BB; Thu, 23 Nov 2023 09:30:34 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345497AbjKWRaR (ORCPT + 99 others); Thu, 23 Nov 2023 12:30:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229686AbjKWRaL (ORCPT ); Thu, 23 Nov 2023 12:30:11 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91C6D1BF for ; Thu, 23 Nov 2023 09:30:17 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4342FC433D9; Thu, 23 Nov 2023 17:30:17 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.97-RC3) (envelope-from ) id 1r6DX9-00000003678-0EDW; Thu, 23 Nov 2023 12:30:35 -0500 Message-ID: <20231123173034.915220118@goodmis.org> User-Agent: quilt/0.67 Date: Thu, 23 Nov 2023 12:25:42 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Josef Bacik Subject: [for-linus][PATCH 3/5] eventfs: Do not allow NULL parent to eventfs_start_creating() References: <20231123172539.582640797@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 23 Nov 2023 09:30:35 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783376907904358954 X-GMAIL-MSGID: 1783376907904358954 From: "Steven Rostedt (Google)" The eventfs directory is dynamically created via the meta data supplied by the existing trace events. All files and directories in eventfs has a parent. Do not allow NULL to be passed into eventfs_start_creating() as the parent because that should never happen. Warn if it does. Link: https://lkml.kernel.org/r/20231121231112.693841807@goodmis.org Cc: Masami Hiramatsu Cc: Mark Rutland Cc: Andrew Morton Reviewed-by: Josef Bacik Signed-off-by: Steven Rostedt (Google) --- fs/tracefs/inode.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/fs/tracefs/inode.c b/fs/tracefs/inode.c index 5b54948514fe..ae648deed019 100644 --- a/fs/tracefs/inode.c +++ b/fs/tracefs/inode.c @@ -509,20 +509,15 @@ struct dentry *eventfs_start_creating(const char *name, struct dentry *parent) struct dentry *dentry; int error; + /* Must always have a parent. */ + if (WARN_ON_ONCE(!parent)) + return ERR_PTR(-EINVAL); + error = simple_pin_fs(&trace_fs_type, &tracefs_mount, &tracefs_mount_count); if (error) return ERR_PTR(error); - /* - * If the parent is not specified, we create it in the root. - * We need the root dentry to do this, which is in the super - * block. A pointer to that is in the struct vfsmount that we - * have around. - */ - if (!parent) - parent = tracefs_mount->mnt_root; - if (unlikely(IS_DEADDIR(parent->d_inode))) dentry = ERR_PTR(-ENOENT); else