From patchwork Thu Nov 23 16:56:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169028 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp581356vqx; Thu, 23 Nov 2023 08:57:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IGxuHQpcFTVzTDtwZ+TerlfZlaSXo5N3+XWzxsTjsiqcFThA9CX2X3SngpIO3U5D2LYUbwH X-Received: by 2002:a05:6a20:3c90:b0:180:e3f1:4f60 with SMTP id b16-20020a056a203c9000b00180e3f14f60mr183538pzj.45.1700758633703; Thu, 23 Nov 2023 08:57:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758633; cv=none; d=google.com; s=arc-20160816; b=w8UGwo0pD8tahD4X+JlBi/Vgpz3jGwlAeSu+IG3iRJBF5x97Tu+hf16lxhtuhWj4p2 CRSoCsUwgR3s7d9yE8O2ZoHOBb+I23njXCCC/ivRCF3mUcVtkJNn+Z+92IwQQ3/pSNy/ hjIYqM6+0Rf2Ezg+LyYkF4sDVEgyvzGIp9/3HxapfocGN4dxQ6VhLUJEwhKs6Z0toaTr BAqxymr8T9JUPyCqWtmKQGltqo9KKxXNvysyhSxEM5PBeH7mK/r0Yj66klHwaA07leIL haMqdCW/WKmiuX+cgU5KddD2jSyTYS6TijXaKiQu18Py1VfitIGucljcdI9CEExHqJBX KIug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=cp1N31QWm6o7MZ0I8JJcE3c/9OfyixxPW9uF/7LnRhc=; fh=Zdg/IaJWIkan+8kr6bDKmrlAn6GL271tZGmx1ajMHC0=; b=gRhstg+2PXkG36020wYAQ9dnAYuYxSvXaFdlP2llCBE2H6oJf+/6mMZu0hLKXFmqCp A8tLJleiWE+F+ps0IHYjyRmNllhsYUGebtwHqPMrePhzf1kOq+IgTwaTcJM7JqzQsn6U nsOiBFgG90e+8WVNDxG0rTPoNih7/wphhsubOSV5YbLR6plN8HwHcJD7EJ+yIdkcmF03 NYDPiQ4MhOkHs0Ijx0ml65FpeE65RG2K+keTxGx7u/iX129GuewqhgGfUul5h+WlG3zV V8VEovw1wQSpGJpzoEEti1LucLi/9oBwdjvNjzEgWyNV1azgp/3M+iovFIRt1sLiBmYy 55oA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id cn4-20020a056a020a8400b00577475ee5f6si1569625pgb.618.2023.11.23.08.57.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 08:57:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id C82E88329A3C; Thu, 23 Nov 2023 08:57:07 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229686AbjKWQ47 (ORCPT + 99 others); Thu, 23 Nov 2023 11:56:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229526AbjKWQ44 (ORCPT ); Thu, 23 Nov 2023 11:56:56 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF8F6D48 for ; Thu, 23 Nov 2023 08:57:01 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0e-00053N-Du; Thu, 23 Nov 2023 17:57:00 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0e-00B54x-03; Thu, 23 Nov 2023 17:57:00 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0d-006ozY-NM; Thu, 23 Nov 2023 17:56:59 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 08/18] mfd: mcp-sa11x0: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:36 +0100 Message-ID: <20231123165627.492259-9-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1942; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=306Da8DHDzuEHmAs2DmBNmnh5FVbLXfhEvcGFu1AvDA=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RE0iIvzSXUDoJ9ZVZKIf15IRopeUzfSOp0C 53AfyWitiyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+ERAAKCRCPgPtYfRL+ ThT6B/9e+FvsnumNbUow1hEZHP3FjwjB8jAayEvtkeFQjLORjXL3V8rrtg6gyvW06tlteUyI3AP ALV4nxz7WfRe+LQuqpIULBW9FPfCUh4QO1wouqvS5/8aTmpQ0RKDqaPefNheRW7Wy+FLR+aGfED dYdfjqmHC6Oco4ZwXl945p6b/P80IGkyhPLmc1/lY1q7UboFwhTpYsb1mZfltVDLH+Vt+NBkKDG BH8tfcw40gVGwgVprukoLzsRqbgw3w5tNCZcyPq2dJOaWvLLrXPr0j+aqw/5Eo61WjysE1WOIe1 sRdbMD74i8uGKm7orHjTJ2raUv4mzZbhYItGuEFV1PjyJG0k X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:57:07 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374685244854284 X-GMAIL-MSGID: 1783374685244854284 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mfd/mcp-sa11x0.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/mcp-sa11x0.c b/drivers/mfd/mcp-sa11x0.c index 1c9831b78cf9..3883e472b739 100644 --- a/drivers/mfd/mcp-sa11x0.c +++ b/drivers/mfd/mcp-sa11x0.c @@ -232,7 +232,7 @@ static int mcp_sa11x0_probe(struct platform_device *dev) return ret; } -static int mcp_sa11x0_remove(struct platform_device *dev) +static void mcp_sa11x0_remove(struct platform_device *dev) { struct mcp *mcp = platform_get_drvdata(dev); struct mcp_sa11x0 *m = priv(mcp); @@ -251,8 +251,6 @@ static int mcp_sa11x0_remove(struct platform_device *dev) mcp_host_free(mcp); release_mem_region(mem1->start, resource_size(mem1)); release_mem_region(mem0->start, resource_size(mem0)); - - return 0; } static int mcp_sa11x0_suspend(struct device *dev) @@ -288,7 +286,7 @@ static const struct dev_pm_ops mcp_sa11x0_pm_ops = { static struct platform_driver mcp_sa11x0_driver = { .probe = mcp_sa11x0_probe, - .remove = mcp_sa11x0_remove, + .remove_new = mcp_sa11x0_remove, .driver = { .name = DRIVER_NAME, .pm = pm_sleep_ptr(&mcp_sa11x0_pm_ops),