From patchwork Thu Nov 23 16:56:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169033 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp581585vqx; Thu, 23 Nov 2023 08:57:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IHeyLhnWWIy0qra4n//Lvj3mDyCG2YRZE6Q68+b7NQioEDLfCe9oafacOCJcvFsS14S7u/m X-Received: by 2002:a17:90a:e7cf:b0:280:215e:7ae2 with SMTP id kb15-20020a17090ae7cf00b00280215e7ae2mr96237pjb.2.1700758662296; Thu, 23 Nov 2023 08:57:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758662; cv=none; d=google.com; s=arc-20160816; b=rDG3hDuugVoz9DX8i8dKGuU2LBQX0klH0AD09T2WSnPcIRYZz1OGOnIyBy1npWw6Kw kQh7ipE51zUwgoyIjYKtMwG/7AS+qaTL4+3klqjIQFJVMODPIJIVVf/nv/Xu5ED47wc7 KtZH0ss+/CvAbU61L09arWA5KgTbdsV47mi3QBd53SYAwBifz+eA2VGdKMa+Tjs1WMha Eq8dlIdzu9w3LVl/+SONCqLlQDJ7rhJoTJHPuL+3m42z92Wk7rIP+saPBwZm4BVGzKfX uLGGGZpPrf4fJFU7cxlSZKZ9WaXK4gFTkx0qdLn7kvs6XBa+LapN9h7UTF0hXL6g7X6N Gaew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=xuzl0oZcVQrevsPyZssuMk40bkqg7ew8yvEeT8CEi9E=; fh=Zdg/IaJWIkan+8kr6bDKmrlAn6GL271tZGmx1ajMHC0=; b=nYltDTqfIQGIwl6mKDUKz2BNE/ecPXAHSISYb6MvUEYcI42rHRLHc5KynAKwDsDYSR +g56mc1vUBL8MNhoJ+UCKbxA4AVnRLYErp8Lf/ubEyI/Al0rHpfup4rUcbC1RC+EXa7y qdVD6Sni6Gkh8QPzF+3/TCyMmYIOVl8gEFEh+s+ybFva92VMyuZXlZlgzt3njF1wEktU Y1AtiKDdlNy0toyx+SDdAVuHzuZXtNHic8qHVvXg0XczMGcWI3G+4DyRwv54ViPoYR0I RnAF0d8VXKTgrk0NYIPZurq1x/CMtqjQdYxfqkAjzTIiVJwleFbBoqqUm0Uge57exkgB o6mg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id lp6-20020a17090b4a8600b002803af4c4f8si1738309pjb.74.2023.11.23.08.57.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 08:57:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 22A2B80659A7; Thu, 23 Nov 2023 08:57:32 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345187AbjKWQ5B (ORCPT + 99 others); Thu, 23 Nov 2023 11:57:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229519AbjKWQ44 (ORCPT ); Thu, 23 Nov 2023 11:56:56 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF8D2D46 for ; Thu, 23 Nov 2023 08:57:01 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0e-00051H-6o; Thu, 23 Nov 2023 17:57:00 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0d-00B54t-Or; Thu, 23 Nov 2023 17:56:59 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0d-006ozU-Fw; Thu, 23 Nov 2023 17:56:59 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 07/18] mfd: kempld-core: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:35 +0100 Message-ID: <20231123165627.492259-8-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1898; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=KmijBtfkuKurQFpbpsAneLTGXJS1Jnusah8kZowlcJE=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RDkwUEr6r4st/+YMwIR6Z1awsT9exPwbnm+ tzt0Lu8yw2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+EQwAKCRCPgPtYfRL+ Ttn6B/4ufQ06c+9PQx3uvAkc7ww5TKk0Z7pNN69ibei2pGdkYQWM+s0VKB7rz0SBrWrltLOR/6G FKF61LS1f3IlHxPf5cplsK0Dcb7K15gmy7wdJ7C+un3FEA6ISQMk2ZwGQklHzCRuWn+pudJJJYR Zac1NvgcYdSWbl/CArFuX1NIa7gLd1z4S3b/5mMtDqtMsMEDeweLqu+7Li0nbqxvD77uzi7tDd+ JrVmtmMrTMJWT2wJ7fj5/Et0pFFXkonZrXjw2t2hg9TNuPjDeYbx1D7c2mBi63weorU0GFCIRXg +34765A/6ijn9ryLfJ0JdzdATOibqh0YhNhNCp1JqkusDJGE X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:57:32 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374715208591334 X-GMAIL-MSGID: 1783374715208591334 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mfd/kempld-core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c index 33c6cfe9fe42..67af36a38913 100644 --- a/drivers/mfd/kempld-core.c +++ b/drivers/mfd/kempld-core.c @@ -535,7 +535,7 @@ static int kempld_probe(struct platform_device *pdev) return kempld_detect_device(pld); } -static int kempld_remove(struct platform_device *pdev) +static void kempld_remove(struct platform_device *pdev) { struct kempld_device_data *pld = platform_get_drvdata(pdev); const struct kempld_platform_data *pdata = dev_get_platdata(pld->dev); @@ -544,8 +544,6 @@ static int kempld_remove(struct platform_device *pdev) mfd_remove_devices(&pdev->dev); pdata->release_hardware_mutex(pld); - - return 0; } #ifdef CONFIG_ACPI @@ -563,7 +561,7 @@ static struct platform_driver kempld_driver = { .acpi_match_table = ACPI_PTR(kempld_acpi_table), }, .probe = kempld_probe, - .remove = kempld_remove, + .remove_new = kempld_remove, }; static const struct dmi_system_id kempld_dmi_table[] __initconst = {