From patchwork Thu Nov 23 16:56:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169030 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp581416vqx; Thu, 23 Nov 2023 08:57:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IH6gXsuNlQyiA4YpU67q4CmVKZRAiWi2dMSeQIX7snbrrdBj1oay3DELHfs0rPNmXgbf1Ig X-Received: by 2002:a17:90b:33c3:b0:281:19db:b5a7 with SMTP id lk3-20020a17090b33c300b0028119dbb5a7mr32861pjb.49.1700758639466; Thu, 23 Nov 2023 08:57:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758639; cv=none; d=google.com; s=arc-20160816; b=XLRadt5FmPchy+ZA7widVy3EpRy0h1MpqnADCk7HKaKPatNK49V7t2R/701m/mumo7 FsBNXoAV6VTeOxz8n/Z1lqSosxW+lQch0UG0AFHAqHfTgopeTu7VifC7tQj2UWLQ5KHQ ZjgGmoOgZ/Rc5/pGMsSWUD6XIislIP08us5rF/kbn1mBpNGIdxKO9X+QUyHCXlgIHg4P WzX60oBt5y1vB2cHXSsOwesljrN6D8y/1Dx5/mre3M2oUor8Dkt+u8BNoqWLOAld6Oa6 qcFeIU+mhYOOW6+GTpeGzY+tnw8rPavpzNY1ApSc+i/OskP+ic0ngOWk7KCyATds2cSF 7pdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=zQAHI372AUVVJ1OB+OtHU1kxIYazri9P+mUkLa4FUVs=; fh=Zdg/IaJWIkan+8kr6bDKmrlAn6GL271tZGmx1ajMHC0=; b=pgGIsPzvxjsczC0sVuFByXZCghK423mqN5THoEezWTXlSeQi1d2c0Ytj5gmeCNqYA+ mQuR7HmRnMSyn2MYShO85J9Tw6GqeQBnmsUPKnW28l2222xMWau4VUAaHRQqLZVMKR9v KG0rfwxHzLlQBK1aCODmQOwGplBLTxVm+U5htnZVh6AL/xKM9/epdGmJkCChMzsiZ3RG aAfxPTaTi2xOso2dQOuao+KWAgtpO7jRSkMlAcDZUrW3X1Nk4y0CsSovTCFp7YBd6ZjO 4onOZUJWxM1CqKfOf93mWb3BcbypS6CbosEv72P8C3J+MCqRmG44NAQUS7F+7vRx36wB Z42Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id o11-20020a17090ad24b00b0028515bd32a2si1680808pjw.81.2023.11.23.08.57.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 08:57:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 1113A809AF91; Thu, 23 Nov 2023 08:57:11 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345166AbjKWQ5A (ORCPT + 99 others); Thu, 23 Nov 2023 11:57:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229921AbjKWQ44 (ORCPT ); Thu, 23 Nov 2023 11:56:56 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 720E8D42 for ; Thu, 23 Nov 2023 08:57:01 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0d-000503-Rr; Thu, 23 Nov 2023 17:56:59 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0d-00B54n-FI; Thu, 23 Nov 2023 17:56:59 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0d-006ozQ-6D; Thu, 23 Nov 2023 17:56:59 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 06/18] mfd: intel-lpss-acpi: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:34 +0100 Message-ID: <20231123165627.492259-7-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1698; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=Sme7QalM7Fxz+h2W/iOt36fGZfq+w2Qz9J3kQwKy1O8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RCnfCgkDJiIE25/oCfSiIzC5NO848BrtAnH ZyBqiDPe++JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+EQgAKCRCPgPtYfRL+ ToMQB/9Usf5Erf+yrIvwTJja/sV0wyLm7NbGOq/oPD0A6ULzpXEPJXuTuLFzeI+pUQ1izKzIpXX drtfihdCoaAjmIpQ2xlGLJF68i4FohnxMOUI53PnpT2LX7AzWA+g+EUiuldK/u1JmsPMf1kJNLG eiQDV7FQ5EhP+eZbiHSddN3ddK1mR99Ps+2lGCxnuq8/5fmdYe/56ds/hkTJu6fR2yIogyVbQWx AHBac4/+1LERCvnSy4ZkCsdy5K12f3VcJiPMX11dl/8BKpKzC+bnxraJTr24FHc8QtIY4faIWKr r39ArH582zRPo5wsmp1wUA2YZcJkh9BoWu7DNoISukGYB1gT X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:57:11 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374691286450303 X-GMAIL-MSGID: 1783374691286450303 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mfd/intel-lpss-acpi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/intel-lpss-acpi.c b/drivers/mfd/intel-lpss-acpi.c index 212818aef93e..5184fd1a5df1 100644 --- a/drivers/mfd/intel-lpss-acpi.c +++ b/drivers/mfd/intel-lpss-acpi.c @@ -198,19 +198,17 @@ static int intel_lpss_acpi_probe(struct platform_device *pdev) return 0; } -static int intel_lpss_acpi_remove(struct platform_device *pdev) +static void intel_lpss_acpi_remove(struct platform_device *pdev) { intel_lpss_remove(&pdev->dev); pm_runtime_disable(&pdev->dev); - - return 0; } static INTEL_LPSS_PM_OPS(intel_lpss_acpi_pm_ops); static struct platform_driver intel_lpss_acpi_driver = { .probe = intel_lpss_acpi_probe, - .remove = intel_lpss_acpi_remove, + .remove_new = intel_lpss_acpi_remove, .driver = { .name = "intel-lpss", .acpi_match_table = intel_lpss_acpi_ids,