From patchwork Thu Nov 23 16:56:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169029 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp581405vqx; Thu, 23 Nov 2023 08:57:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IHf9MMUHfZHuxiuYZup7VMRpgrba+WHyr7eWDaOGPj424LyssP1suopnsv9HnQBN0vTY3mc X-Received: by 2002:a17:903:22d0:b0:1cf:696b:1a7f with SMTP id y16-20020a17090322d000b001cf696b1a7fmr144109plg.0.1700758638020; Thu, 23 Nov 2023 08:57:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758638; cv=none; d=google.com; s=arc-20160816; b=TGqyBqWpj5WpaSNJchnnGk4zs34SyCK236J4QFj81GmSz/kGhsewmTqhsFLcA4rTes F7ojIx8q7RqygeglT02lJPusf5GY6ZnOxG1hzxjf+DCmWuLP6ihi+A3MPCbSW3dXHy45 KSDXcFHNUsdmEqOgLUlSQ4uSCLmFteotZzj7APQ5V1gETa/wyRMBI388nbMoqmtOk04a xH+o9RBLoGLWbSZ8UOC09Yc0c828CjQNfT8hsr/DERL5jybyHdqeMg47yUq3NAhstlPp Q37ZnOR1vfU4gQAruVvV7eXgW9L4IAjSrbgOjOMtQXywKZrQx5X2Hq989IN2lx0saYBj z7og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=S6KAYq9D0deJY3F5emrtEOD0Bu/J2/oXLsIIYMngVw0=; fh=Zdg/IaJWIkan+8kr6bDKmrlAn6GL271tZGmx1ajMHC0=; b=rFkgcXr7Z5XlRCMoNZaZ1yix/3NymIvjumIRlggYthx3knStqKNMbnoqLLMqlF7DJf ivXA4b9rdi2k+9/QpEzYkdyBqocd6nUNthHrYF7I/y1/IXNnhQ8m/fVJXVyMwM799GIT CYRSFCM22hQoLQb67YM+ciMUOg19ayR4Z0XCpbk0fwWdxlbJY5/sRdlSHD5+iCYFPfZz JudjEQlHcFEKfs8H+d+BID6UQpEC97GhCWMSYO8cBRB6XKzVhF6Z97IhryVDK6G/gXeQ zNrpRBvf4998wjnsxEK6ZDShEsrOC0vx5nXyicJOcQqZZ/7G8s0i7EOV8rCPTC16fmZG 5Q5g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id s13-20020a170902b18d00b001cc3473657bsi1443895plr.215.2023.11.23.08.57.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 08:57:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id E7925824E53D; Thu, 23 Nov 2023 08:57:05 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229949AbjKWQ44 (ORCPT + 99 others); Thu, 23 Nov 2023 11:56:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbjKWQ4z (ORCPT ); Thu, 23 Nov 2023 11:56:55 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37587BC for ; Thu, 23 Nov 2023 08:57:01 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0d-0004zR-IT; Thu, 23 Nov 2023 17:56:59 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0d-00B54k-66; Thu, 23 Nov 2023 17:56:59 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0c-006ozM-TS; Thu, 23 Nov 2023 17:56:58 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 05/18] mfd: hi655x-pmic: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:33 +0100 Message-ID: <20231123165627.492259-6-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1778; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=dI9I7gz8/r2ZcPCua/AplnWUDrg6g0W/Uk6MlFqZHHs=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RB+83Rz11Z6/NItwJ0/Z2CF9epAbSH3zyAJ bGInwhPFXeJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+EQQAKCRCPgPtYfRL+ TkNtB/wOctIRHw/GpGBKwLcWP5+UlhVikKuLUUUSBgs3bn3C+ji2CoY2cc56deEZZE4k5Fd7MGM /ae9HmULVtrQu6GSj25QNZna4hagUvC/NNFcDNbJ30cMxve4yqWRilnBqKKV5Napyc1dFgwiiGE cKT+l2u9f2FN1qHCxvW/ATkHT6zlXJPkUcJqhV1IMHRPN/q71spl8z3K9gsI0mmY1S3PnN9IsXk v3GqUubRdIGafZl75/bHxHOMkXRNLF+sXhdbNeJ9dRzO77PI71gbn+QtRzrAAdlOa+N44N20QA6 JAMBUPoxPHrt25mXDUnYv1y92yIivSmpLYmHoZYw9oRCkAa9 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:57:06 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374689524974672 X-GMAIL-MSGID: 1783374689524974672 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mfd/hi655x-pmic.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c index 8feae8d8fd9d..042109304db4 100644 --- a/drivers/mfd/hi655x-pmic.c +++ b/drivers/mfd/hi655x-pmic.c @@ -144,13 +144,12 @@ static int hi655x_pmic_probe(struct platform_device *pdev) return 0; } -static int hi655x_pmic_remove(struct platform_device *pdev) +static void hi655x_pmic_remove(struct platform_device *pdev) { struct hi655x_pmic *pmic = platform_get_drvdata(pdev); regmap_del_irq_chip(gpiod_to_irq(pmic->gpio), pmic->irq_data); mfd_remove_devices(&pdev->dev); - return 0; } static const struct of_device_id hi655x_pmic_match[] = { @@ -165,7 +164,7 @@ static struct platform_driver hi655x_pmic_driver = { .of_match_table = hi655x_pmic_match, }, .probe = hi655x_pmic_probe, - .remove = hi655x_pmic_remove, + .remove_new = hi655x_pmic_remove, }; module_platform_driver(hi655x_pmic_driver);