From patchwork Thu Nov 23 16:56:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169036 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp581686vqx; Thu, 23 Nov 2023 08:57:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IF01tljV6UfZxDwaXBDtBwqiyuM4yUoAqi12ao9QJIcdxOegCOzag+LJc/pYqabaV4Ol9+A X-Received: by 2002:a17:903:247:b0:1cc:31c4:377b with SMTP id j7-20020a170903024700b001cc31c4377bmr37684plh.63.1700758677906; Thu, 23 Nov 2023 08:57:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758677; cv=none; d=google.com; s=arc-20160816; b=r0Lk5+qUkInChkDjbYu5BYhMSk9zDO21GRg1b6/qxxl1EJUZPGn6hpiNbJ1rOQ6XK0 5VspWeah/YpZNNcEz3bdpjzC+42wYCg617zWcdnBUT3riRlLoUIKGG/y+4SabvBN3HMI dGb3XbunUwnlK3oZeQVvFyez6Dm7bnc/QwSTJtN6X8Fd6g8ZgZcyungYEYbhXDk11w8R H0ixdS3Ol3EO16KTkAlykHFfAiKWpUxgcR/ne7n/1fH5iNOmwY4F3YgufzibVtKvTkvc KaGcoIHXrzWaFYNV9EA2x/4Vf8DPZIIZ7+l/EX802i6s//p2ighwMeiCsNZ9c040k/br L0fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=nmdQO+GhILkGYlOJqOA9i9CQJU8sdyFdE1w+7jrQmgA=; fh=cIjNq8AJ7DYG+w9Jtcuz1ji5cufJZKE/mbz7BhfN7Sc=; b=oTvkqveIC9Al4LxkiAPk6Khfl0F50GjJOZCCoZfmiKroE5Fr14I3jpTy/FKnGgyDzw iHC6KHRA5d63scVu1lJJ0430el4hLAtWqaGQqKmTMs4bDNPkMYiukxuOKmFVjOv+4Cdd iJD8jPpy6DITY6WqF+iLx4qhkqd4M2TI9vWetAhNCQAzrnZoN0Ix7FrvJF/KbMPu53Hi r2sFvG9y8rY9Zt3KfPgvlCtB2rbmK8IDYS30qM7+BxzyGd/Yxpqni/DOWLiGAbls9LYV fJ42OyC9FE+Hmy4DCwU7/oxg3m48chhKfP4tllaB8B5z+fCOFA5bm20pEnZoQzsn2EiT 5dSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id jj14-20020a170903048e00b001bf1d1d99b0si1457013plb.568.2023.11.23.08.57.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 08:57:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 117868260C34; Thu, 23 Nov 2023 08:57:52 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345346AbjKWQ5g (ORCPT + 99 others); Thu, 23 Nov 2023 11:57:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345208AbjKWQ5E (ORCPT ); Thu, 23 Nov 2023 11:57:04 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50963D64 for ; Thu, 23 Nov 2023 08:57:08 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0d-0004zQ-Dl; Thu, 23 Nov 2023 17:56:59 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0c-00B54g-UL; Thu, 23 Nov 2023 17:56:58 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0c-006ozI-L1; Thu, 23 Nov 2023 17:56:58 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 04/18] mfd: fsl-imx25-tsadc: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:32 +0100 Message-ID: <20231123165627.492259-5-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1657; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=H9E4DQumuJYM4xGNsjymKWQwrBqvaE1jdcSqA7stR1c=; b=owGbwMvMwMXY3/A7olbonx/jabUkhtT4FocGfaaOewzxfHtil1sf2aDbr83dc66GIdswU79qe vUGZsFORmMWBkYuBlkxRRb7xjWZVlVykZ1r/12GGcTKBDKFgYtTACbCls/+z646rGhr3C5Bjiks tW/fztmy8prXz8TGDv5Fv1UupnQfCV7jfkixwfaWSoN7z5ZWjd0/1e/ZNvH8k19+S137VH6C7Cl FhijdjHs6p8Ks+hgFItikJWRiTyasrTul9Gzt2tfxEpqppwy0vj5dIRWl9/h13+xQ7ZslW4Wb3n C8Nly/v4J1Z1zirq0xrXXLj0uc3bRDK3DTh8s8bT/kBcI8OXbNv57JL7F2VrihxckViQbCoU9qK 7juPDu1ef1vu3sTi+dnL7lW6v0mSO+0kvWEFc2cf2K49HQXzrRbPLmWXTM+RfSi5xMhqfXckYLF nxenrHE048m68tzQ4Pm0xgvTgv4WLHgbsKKnYu2V6DUdAA== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:57:52 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374731167738782 X-GMAIL-MSGID: 1783374731167738782 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mfd/fsl-imx25-tsadc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/fsl-imx25-tsadc.c b/drivers/mfd/fsl-imx25-tsadc.c index 089c2ce615b6..74f38bf3778f 100644 --- a/drivers/mfd/fsl-imx25-tsadc.c +++ b/drivers/mfd/fsl-imx25-tsadc.c @@ -194,11 +194,9 @@ static int mx25_tsadc_probe(struct platform_device *pdev) return ret; } -static int mx25_tsadc_remove(struct platform_device *pdev) +static void mx25_tsadc_remove(struct platform_device *pdev) { mx25_tsadc_unset_irq(pdev); - - return 0; } static const struct of_device_id mx25_tsadc_ids[] = { @@ -213,7 +211,7 @@ static struct platform_driver mx25_tsadc_driver = { .of_match_table = mx25_tsadc_ids, }, .probe = mx25_tsadc_probe, - .remove = mx25_tsadc_remove, + .remove_new = mx25_tsadc_remove, }; module_platform_driver(mx25_tsadc_driver);