From patchwork Thu Nov 23 16:56:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169043 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp583936vqx; Thu, 23 Nov 2023 09:01:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IHncVE7M7D1uMLeEtbYBp65CXdYsVK7Kcn6RbYCVpIxYRt6IJFoB5I94g36qJGW1Jc4Xv7M X-Received: by 2002:a05:6808:181:b0:3a7:1b28:4bc9 with SMTP id w1-20020a056808018100b003a71b284bc9mr6299742oic.54.1700758885255; Thu, 23 Nov 2023 09:01:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758885; cv=none; d=google.com; s=arc-20160816; b=BMsG70KX8wbseh2QB2pYR4wCi+lGggUGPGaii93ZeMWIoMptKhXE8+UvdgIBQKvU9g cHhTNE4FWNdbQQzRYN432MxgGvYPw2JplZPPv6rN2a+bG7JrBxZMLB1vI2Z2U5+r8G+u hBrK89UF8OIAW6uOhwIZie2yA7XdVpplHm1xXT7oRwFoO5mq86s3wlJ2WehW166n9o7K wJmVVGBSIxetbhzv1DYfsgkInp31VRhj6t+ARjnWGzUb3pPCglzVCuc/sIJRlp3Ss27E 69jf9cubfPvbtefkglfVRMxU1nIboaf5998vZzBFIb9qgYE3pdAIkEory0+lvPBDxu6p +sYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ZheSiNts4rCg/qKQSdeGyTFEG9ta0VByb8ksP4/T67k=; fh=Pb0YFf3Qb0jiyU9w8FvUhRt9p1tOuz1X66bA4DIOFKo=; b=Sl3MImOegiW4COy/PN0BqvYXU+tx+3GlEbV1/JJdU44R5P0HrvQ/Y2pggoWh7kmwYd OQXrKjmcfZC7m732wQvhXZdG+UwsC9WpWsdCwqn+H6iaLMVMVviZrV0lKYeLL5ddIP1F 5qoJnmmh7OQ1/d8+FuUHzpsRMDraPXKvVGESNQXCaZrGoUVku7Z7DpCI26ir6mfWTHL4 1YdKeJfEKSBueKmSlJHgdZWIMsigkqpOyRykX7cfcCTDPEcgZh+AyIYEW8I+YJTj8QBs ujPuSpd3EUkir2hNXPjKZWSzg+AjHqX4mNuJJ7UhzDk4SVRdVikG09jbxzxzyQL18jFl 6PaQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id dl3-20020a056808614300b003b6cb6a18c2si563835oib.211.2023.11.23.09.01.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 09:01:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id DF1AB8030B9C; Thu, 23 Nov 2023 08:57:53 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345188AbjKWQ5V (ORCPT + 99 others); Thu, 23 Nov 2023 11:57:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229970AbjKWQ46 (ORCPT ); Thu, 23 Nov 2023 11:56:58 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F5F0D48 for ; Thu, 23 Nov 2023 08:57:05 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0c-0004z6-SO; Thu, 23 Nov 2023 17:56:58 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0c-00B54Z-FD; Thu, 23 Nov 2023 17:56:58 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0c-006ozA-5t; Thu, 23 Nov 2023 17:56:58 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: Benson Leung , Guenter Roeck , chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 02/18] mfd: cros_ec_dev: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:30 +0100 Message-ID: <20231123165627.492259-3-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1720; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=LCw3bj2aWliMJeRhvUQKWZ55KhVQThCiahgEmDcwN4c=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4Q9cxZ+4UCl/GvDKW8mubt9953vOUXfszBV1 wxXWkcEyzCJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+EPQAKCRCPgPtYfRL+ TnSGCACPvoDxVg9509CpoLILWkjmQePD3RgHtDcRoR7vpXswXCrpfuxJ0LgJhErkN9IMJwHLJCZ n5MH/d47hy4AAlYyGpVfRdJDAaId5dQHOIC6qcmZh8IUKbJ+I4oFt5ReW2XRjvPZJD6SuE/HMIn m97u6S+ZX0DD7ELI5VFlmtH8lyt3zN6niBuAvpMc5aR0l+yGGUDuxto0cg1r19oGht93TgQUZJB bnuZFTb6XFh/A0ewm4kADppa6R23xUdDqI+I9J/wv1rF5Q8uOnVPQLBHM4jfZ9uqdEz7dNbHoPb BKvxqOcnohoCSeEKMHyyLOhGrMIytQKUsZ4X3M/BFwQ42KxY X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:57:54 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374948532531094 X-GMAIL-MSGID: 1783374948532531094 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mfd/cros_ec_dev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c index 79d393b602bf..603b1cd52785 100644 --- a/drivers/mfd/cros_ec_dev.c +++ b/drivers/mfd/cros_ec_dev.c @@ -288,13 +288,12 @@ static int ec_device_probe(struct platform_device *pdev) return retval; } -static int ec_device_remove(struct platform_device *pdev) +static void ec_device_remove(struct platform_device *pdev) { struct cros_ec_dev *ec = dev_get_drvdata(&pdev->dev); mfd_remove_devices(ec->dev); device_unregister(&ec->class_dev); - return 0; } static const struct platform_device_id cros_ec_id[] = { @@ -309,7 +308,7 @@ static struct platform_driver cros_ec_dev_driver = { }, .id_table = cros_ec_id, .probe = ec_device_probe, - .remove = ec_device_remove, + .remove_new = ec_device_remove, }; static int __init cros_ec_dev_init(void)