From patchwork Thu Nov 23 16:56:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169035 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp581661vqx; Thu, 23 Nov 2023 08:57:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IGF4MCfjO4gwjg3NIimj/UgW/wvafFgGcJUfztXN5S465329ObjgZaWjTk30NpDNWz/NN6j X-Received: by 2002:a05:6a20:3d11:b0:189:c353:3a65 with SMTP id y17-20020a056a203d1100b00189c3533a65mr254441pzi.12.1700758674446; Thu, 23 Nov 2023 08:57:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758674; cv=none; d=google.com; s=arc-20160816; b=QVZ5TKE3bAol6EYynh0q+a5VSrdxZCnmly71YhnJqKBQ1c9cin8roQIXpow51pO2Rf UaSdv8iG4DsX2KZ862NU6IGsQz3y0k8cB0+pV6UVlSx5Ao4XrpWgxIHfJDvHaKqQU9Md J/IPWjwKZpZU30A66Aro+9uB/lGUhu0Z7vqJnA/g9KPTNa7tZO/0yN8vxxzi7ZxMasgo 3EWZieq3LcluqUwiCKKghPkuhS7xhnsiE0KobaruLLnEYkXmEJs0N1S+1hk5RXMYWZuD nZ2qaA5uLkoYFdlwsSnG1IQ3gIIDiJVjMrzCgfes9ZakEBSG7UPrfBmhyghVlafSDYRx Uq/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=hRhNpqdlNfu3ViDvku3YH4tpsoqmcQdD5jYzc+1XtNQ=; fh=Zdg/IaJWIkan+8kr6bDKmrlAn6GL271tZGmx1ajMHC0=; b=ZQ2p05MdkXyORAo8kVztOKUDbWolyRl0/sWjMShrFKThO6TcnEegw99snzmsLIeYRN TsEfT0KNXsI6hOXM1uFQYeDSZ2D4ZbG1wtzDUQYp6IP1rwYVmVOb5Ogk/RWT/919uLoF mJf4y2mJizHYCCIEhjU/s3CPiE08ROrKzXwyJXI4sH9w5wfU7T71ZyuJM6u6mW2C+CaW xtGGwol7BRm34gg9WjFlujGBXhj7OstKzCaPteOzYZohVZBfO9IyCvbLvmstaxBoe56F swAxcHEtYVb5aH+VShCmQsNsfOinKhTop9eNVESuXrE3KNIMMEUvdjmr27TPlmzHxEG/ S8Cg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id k1-20020a635a41000000b005acba4c9bf4si1642183pgm.2.2023.11.23.08.57.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 08:57:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id BD674809B6CC; Thu, 23 Nov 2023 08:57:50 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345270AbjKWQ5K (ORCPT + 99 others); Thu, 23 Nov 2023 11:57:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345133AbjKWQ46 (ORCPT ); Thu, 23 Nov 2023 11:56:58 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 043CCBC for ; Thu, 23 Nov 2023 08:57:04 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0g-00058l-E4; Thu, 23 Nov 2023 17:57:02 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0g-00B55U-1W; Thu, 23 Nov 2023 17:57:02 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0f-006p04-Ok; Thu, 23 Nov 2023 17:57:01 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 16/18] mfd: ti_am335x_tscadc: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:44 +0100 Message-ID: <20231123165627.492259-17-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1826; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=958CZe9ea6jlgCw+DhNvLHgJQMdn3TTMy73VrfjhS7g=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RNzUp+O1Q5mU1TkWEfA3LmuaPzBLdiln56y PSSEKex4f6JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+ETQAKCRCPgPtYfRL+ TurkCACzAHQ8fH88QHgqOLqaNePjWA12uL4ORz6rDd/07Qql/Ocfh960J2cC1A9UR/xfVcUw5M1 xRz2DM97OMdCUYi6zn7jATB7wZ5HQbgdf4GWEN8PZOdNZdExU+Da70xA3G2ftNnvOBDYQ9Xpjjl LcIX/J36/F15n0ewUYD93CLn5i9eZOlbn8cZwF1aM7Vu6jp38egkaQbS5r9O9TmiEgHEjzytFjD 1dwiHTLqpkoExD/kLDpsEO1eT/FTDc8pB8BlE0IwT1ozQ+GMTCceLq9L/28LGwj0Pw59DT8Ll0O ocPFfGmV7OYX/MmBSfr301ogvoJCLRoWcetR7uv8ixprikzT X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:57:51 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374727417791702 X-GMAIL-MSGID: 1783374727417791702 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mfd/ti_am335x_tscadc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c index b88eb70c17b3..4bbd542d753e 100644 --- a/drivers/mfd/ti_am335x_tscadc.c +++ b/drivers/mfd/ti_am335x_tscadc.c @@ -298,7 +298,7 @@ static int ti_tscadc_probe(struct platform_device *pdev) return err; } -static int ti_tscadc_remove(struct platform_device *pdev) +static void ti_tscadc_remove(struct platform_device *pdev) { struct ti_tscadc_dev *tscadc = platform_get_drvdata(pdev); @@ -308,8 +308,6 @@ static int ti_tscadc_remove(struct platform_device *pdev) pm_runtime_disable(&pdev->dev); mfd_remove_devices(tscadc->dev); - - return 0; } static int __maybe_unused ti_tscadc_can_wakeup(struct device *dev, void *data) @@ -381,7 +379,7 @@ static struct platform_driver ti_tscadc_driver = { .of_match_table = ti_tscadc_dt_ids, }, .probe = ti_tscadc_probe, - .remove = ti_tscadc_remove, + .remove_new = ti_tscadc_remove, };