From patchwork Thu Nov 23 16:56:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169039 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp581767vqx; Thu, 23 Nov 2023 08:58:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IFdnZbcOQgkYKxue7AhbrX1VWcu1HL+NI5Q8QMj6vs+Relu/lLDyLXCW6Z69ThmB5U7PAVJ X-Received: by 2002:a17:902:ea84:b0:1cf:5543:a96 with SMTP id x4-20020a170902ea8400b001cf55430a96mr59332plb.51.1700758690111; Thu, 23 Nov 2023 08:58:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758690; cv=none; d=google.com; s=arc-20160816; b=AnQw3pkunaAvJvYCMmCDcGi/GNcRvwOT715EegjIj0De0ehuNZGS2KWFDydNA9IwRr Oi1Yzw1sq1BkoSttYE5ej+WbLoEI0KIjvJQYltJR2FEd33JIkbhFVkIXNxYTXLe32GjQ loWEzp0nk29QNLGkeCP5dYyK/4RpW/2pqKCWvEQbkGIRD2usawN58ubB8vd6QjlE7ZGi pVpPaAOUn//c2YQWcSDY8oh50hTzjBl0O7MPl42MTEiWIS/iow+Xo5fZr3wiHUeNN7ZZ OjUloun2a39AnWTtwvxxVLt+OEUqBqixT5B3otZmUIqyyaPIu0UiTLfkgzEh/WFw7L34 yqoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=wBSWXbESFj/hWFQFGPwDBtS7ePfelgSBKNIUPCL5mWw=; fh=EeUu5qqm5c8zt5D4k3FDPjzWDcPXNXWxVs6KRgrSsoQ=; b=l8z3iC5nGAOpEXCpfQhnibTh7MhBTYEIYyXMpxW9XJxzdafQuX5Bm9/8ZccyJQerTA l0iRW2UYos/quKbjEUzIV1twHei2sgGXF08vxyy7OGrFD4U/ORh2watpzirS7/VSaQ9N VCYMF+d3AXy0SFloiVnRcV4WnPiojYIRGklFMt7ihauLJaK/XJbAUubuzcjhpNHTRFb2 AQfZdganrBIgsDpdjnzZbTbYcshsKFcY/xNDZGqtFm7xy7WIX6RZFYg6cTEiPCPWuOSj w9xaHnQru/pZ2zcTpA1r6Z4i3zuqyy4YxgxieQZZ3PayFVzYiRnQ+fRCJ74r+dfYIdP7 wR5Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id q4-20020a170902dac400b001ce66693239si1566830plx.206.2023.11.23.08.58.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 08:58:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 36116806BF04; Thu, 23 Nov 2023 08:58:04 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345432AbjKWQ5y (ORCPT + 99 others); Thu, 23 Nov 2023 11:57:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345253AbjKWQ5F (ORCPT ); Thu, 23 Nov 2023 11:57:05 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EE9410C9 for ; Thu, 23 Nov 2023 08:57:09 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0g-00058f-7S; Thu, 23 Nov 2023 17:57:02 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0f-00B55Q-Qq; Thu, 23 Nov 2023 17:57:01 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0f-006p00-HW; Thu, 23 Nov 2023 17:57:01 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 15/18] mfd: stm32-timers: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:43 +0100 Message-ID: <20231123165627.492259-16-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1913; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=jVkK8Ke5hsybq+hJya3Qt2KaRP0LWkU08638E+yF+OA=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RMWnS+kDacKKlH4v2Liesd5r6OzwvKBRTf0 42Nudp3EaOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+ETAAKCRCPgPtYfRL+ Tg51B/4iQeyWsKcZqQxzJ9EpqzADAmrRSQK1J+YgDkC/ssJwOFwFHeKS9ufGTLQZjueDdMviNqX VhZdoCQGRNaPOJGESuecYhuxZuAMuRX8wH9ekGMyx5PJLMf8Eo0kjpy8BNPewRkuvpasgc3ZRiR cOXatNi6ahOcob8Sw52RwHZJpyzqqLLhWt5AKCh2amYBpEo5uWwt192cGOffMLfw7C+sJXQXFzE pey/6uHGKQPofLnGxcpA987g/L1rQeaZFlqP97/GpwMozfiDxicqhDQGWCWf1Rse8p5j3qe7x0v fnP2lJ0Drk67B4wBR3zTU3eQMwcXGlO43rUPuXsSIhW0pukC X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:58:04 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374744338668680 X-GMAIL-MSGID: 1783374744338668680 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mfd/stm32-timers.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/stm32-timers.c b/drivers/mfd/stm32-timers.c index a656a1c186a8..9fd13d88950c 100644 --- a/drivers/mfd/stm32-timers.c +++ b/drivers/mfd/stm32-timers.c @@ -306,7 +306,7 @@ static int stm32_timers_probe(struct platform_device *pdev) return ret; } -static int stm32_timers_remove(struct platform_device *pdev) +static void stm32_timers_remove(struct platform_device *pdev) { struct stm32_timers *ddata = platform_get_drvdata(pdev); @@ -316,8 +316,6 @@ static int stm32_timers_remove(struct platform_device *pdev) */ of_platform_depopulate(&pdev->dev); stm32_timers_dma_remove(&pdev->dev, ddata); - - return 0; } static const struct of_device_id stm32_timers_of_match[] = { @@ -328,7 +326,7 @@ MODULE_DEVICE_TABLE(of, stm32_timers_of_match); static struct platform_driver stm32_timers_driver = { .probe = stm32_timers_probe, - .remove = stm32_timers_remove, + .remove_new = stm32_timers_remove, .driver = { .name = "stm32-timers", .of_match_table = stm32_timers_of_match,