Message ID | 20231123165627.492259-15-u.kleine-koenig@pengutronix.de |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp584138vqx; Thu, 23 Nov 2023 09:01:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IHFioymdjdpLPQRWIcMZ0ceZ/QKStQkhwGdbfBdfvZ5GCyJgysUsiM34Q28yGNGus4S3upu X-Received: by 2002:a05:6808:bd6:b0:3b2:eade:5e81 with SMTP id o22-20020a0568080bd600b003b2eade5e81mr8365215oik.34.1700758897116; Thu, 23 Nov 2023 09:01:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758897; cv=none; d=google.com; s=arc-20160816; b=be2i+K5TDtMqbqkCttjGpVEKf7nHYbEyS25Oan12vMJe28tPjqFZLQymsTxb56eQxS dC9b/DVFWoJ7G/gbaaOLdLrEdqVJr/yJQ91eAhs8XG8VprxynN2FN9oZB4RLpAvL0j83 pNY7nxRETBzBDIMzx2jYkxLLfRachRzvn75PfJeTsW7OCgvZLRQ/TfCgoDIyI0Iy4Rpx xriss37z8v+drPEy7smqvHmZYp4hWTQtSOMeTqSrHR5lnCo1nvkOVOCOE0zwXpdSLYg+ kF/1hnHiOCaHle74KdUUXBIFVgOvVRflhMr+YI4ft2p5mB++L5EUyTbE2GtMMaQDQ141 SXZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=UgBlT319sLhai+YBmgYm1AJIGOsJSBUou51vvKYIeJ0=; fh=Zdg/IaJWIkan+8kr6bDKmrlAn6GL271tZGmx1ajMHC0=; b=rVQoKwNGCxR51IS1HfRaG8HcPdxr+Sff9q5XBEaSWUwfMNQGniFqVtYzgDF9+FM/b0 ECQ1EZ3yf+Xj/lz0TKT9uTHrPIcGT+Gw/Q767YjW9RhlWuxwzpAisb/Lq2T5soemAUT2 vsNj+FjFE5SzTYkYs/+9XGGiG3a+ZZz22x7/J9+pv/q5WmrgeFPr2TyRfHDb7kXQj8Q/ hZxM1dz1QNW5QZkZw8KVDYw6OEuE6MlHrSLSwG+wEJsMU6pg3MRX0Jhxqcn4zXOK8UL6 4lSKOm9K0DrGJHgt9Ul8Vl4V0zoYxIMQX8O9TSoqVOjf9a9AEqyHOlmb19yVsDDUuhmm eq6A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id ct16-20020a056808361000b003b8518b5cc2si113004oib.0.2023.11.23.09.01.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 09:01:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 7845280C247C; Thu, 23 Nov 2023 08:57:34 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345167AbjKWQ5H (ORCPT <rfc822;ouuuleilei@gmail.com> + 99 others); Thu, 23 Nov 2023 11:57:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229944AbjKWQ44 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 23 Nov 2023 11:56:56 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74297D54 for <linux-kernel@vger.kernel.org>; Thu, 23 Nov 2023 08:57:03 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <ukl@pengutronix.de>) id 1r6D0f-00058S-UF; Thu, 23 Nov 2023 17:57:01 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1r6D0f-00B55M-Ht; Thu, 23 Nov 2023 17:57:01 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1r6D0f-006ozw-8s; Thu, 23 Nov 2023 17:57:01 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de> To: Lee Jones <lee@kernel.org> Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 14/18] mfd: sm501: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:42 +0100 Message-ID: <20231123165627.492259-15-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Developer-Signature: v=1; a=openpgp-sha256; l=1850; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=zg/2ZKivK3j/zzzpz8S6gtZj3g6k3uJ+o38xadR7Krk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RLVqlKlHQf/icLBp7mzF2JWyccRJ6kaVxD9 ZxwFFiBXvyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+ESwAKCRCPgPtYfRL+ TpMwB/9Z7joueqrSTQ5o2Xb8R/dCAHqRR6UsmAR1YjWLq5pL1Rzpa8Gak2wetFc/nIU07qJdR7K QIe0DrE6Okv/OJUP5UVMdmr/pqRssuBnIPIZuKW43frusnGnaFvuDzX3/8l2GroW8zjPZ7ARjqx NKPlVjfutyeDb1+XH+rKXRR6lMuaLtVpeIMiALs2iKUFti3W9iSGd//bbEEbscyBkE9A3r82GOu iehYZd3xSfylBtB92N7zDDcgFVPWblukIYYrVTofG+LgS2U2zfGmu6UVE71Y2jU5KFREXnbcMEW 7XMoLoEi4jYdH+NA52nVtRDFVTHs6UCWwO+eJZZV2IPvjnQr X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:57:34 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374960904166310 X-GMAIL-MSGID: 1783374960904166310 |
Series |
mfd: Convert to platform remove callback returning void
|
|
Commit Message
Uwe Kleine-König
Nov. 23, 2023, 4:56 p.m. UTC
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/mfd/sm501.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c index 28027982cf69..b3592982a83b 100644 --- a/drivers/mfd/sm501.c +++ b/drivers/mfd/sm501.c @@ -1667,7 +1667,7 @@ static void sm501_pci_remove(struct pci_dev *dev) pci_disable_device(dev); } -static int sm501_plat_remove(struct platform_device *dev) +static void sm501_plat_remove(struct platform_device *dev) { struct sm501_devdata *sm = platform_get_drvdata(dev); @@ -1675,8 +1675,6 @@ static int sm501_plat_remove(struct platform_device *dev) iounmap(sm->regs); release_mem_region(sm->io_res->start, 0x100); - - return 0; } static const struct pci_device_id sm501_pci_tbl[] = { @@ -1707,7 +1705,7 @@ static struct platform_driver sm501_plat_driver = { .of_match_table = of_sm501_match_tbl, }, .probe = sm501_plat_probe, - .remove = sm501_plat_remove, + .remove_new = sm501_plat_remove, .suspend = pm_sleep_ptr(sm501_plat_suspend), .resume = pm_sleep_ptr(sm501_plat_resume), };