From patchwork Thu Nov 23 16:56:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169045 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp584236vqx; Thu, 23 Nov 2023 09:01:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IHEZBUi546DPBPLsV3HyYroaosYQ0GRURa7t70m5UhV45kSautwEvltNMpI7j7eZHPXWTu4 X-Received: by 2002:a05:6820:513:b0:58d:a0:8c4a with SMTP id m19-20020a056820051300b0058d00a08c4amr265524ooj.0.1700758903596; Thu, 23 Nov 2023 09:01:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758903; cv=none; d=google.com; s=arc-20160816; b=AriG+Ef58cHBL59RDgoOoUAsEn+6YRBQ1AUiXPyciIzaXvJE8eoM7zfEQfAksVocNO v7ZrkC1b4v46fCTzhuuEAx5UYsXF2Q2ZXJREOunZaldvsyInFApAe0hq/HW+5rqcB0lB 4qkI56spwYTwPND7fC0i2bPrg0+YRJz6VmcVJRLph8Vom9SxUuBxDpAH4vxpL7uzacIQ QYBgmf9/FTyifOlxcS0yfAgIpz1N484CmGdXHx7GR6Qr+YfiVGGN6AwEvbl9WBPaA2X+ RfABgnW0MjIxTFDbsKf2Nyy6KMPurBtozQ1MpDyfEcPvJVRVE0f3grpFVsxJQRBB+XMN 1nXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=WSTzduU8ekYBRWA7afE70bIUJYnql0LaByzaesGq0bE=; fh=yfJMaNdqSZ8T71FfwLhd2f+2rbag6ER4GaoPLWd+tEM=; b=uImDgXZxnEXEahVKSjVt0WRPU9o57fv2cjezQ1S9JKkJITbomDdQs41gFPYzJQb6YJ rutgE+zuebp7ewjnuKLObloXIpoo2t8m614F5fANxhxo5tfn1mpmyrSHtkUm1WH24uK6 WntG8JWZmWxyUzMe2Ap3jRW2Im3Px8PJidpcBL2utTGV6d12Aa6rN4L21RlZqct5VdxT LViMFqNd8JMUAwA5CLRqL1umTaD4Wr+FiheaN30zdAmzYJyjdSetFB5r5LAIySAUzer/ rADTHxCXSUnPTA4CiekNM34ufzJTBQ2ddeDPLQL0PXgc2iGJMUcvhbmFsRsApcYc79BV CWDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id z9-20020a4a9c89000000b0058a7e918206si546766ooj.9.2023.11.23.09.01.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 09:01:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id BA045818909A; Thu, 23 Nov 2023 08:58:10 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345478AbjKWQ56 (ORCPT + 99 others); Thu, 23 Nov 2023 11:57:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345305AbjKWQ5Q (ORCPT ); Thu, 23 Nov 2023 11:57:16 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67B2710E5 for ; Thu, 23 Nov 2023 08:57:11 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0f-00058H-Lr; Thu, 23 Nov 2023 17:57:01 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0f-00B55H-8o; Thu, 23 Nov 2023 17:57:01 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0e-006ozs-W1; Thu, 23 Nov 2023 17:57:01 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 13/18] mfd: qcom-pm8xxx: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:41 +0100 Message-ID: <20231123165627.492259-14-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1720; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=kmmW3jQ8i81KFfqYxB0Ki4v/E6hUWk+ecQRLAZOVMi0=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RKkkPvevqUyzElWksaJzFiy57xDrcoz/rI+ 5duKyqUVSGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+ESgAKCRCPgPtYfRL+ Tos1CACw6arTk6jUW66Qko52akt9RHWRZbEU2z8w3FWnWDZ8FtMaRviddYr5vLNJkH8REHMKo59 luR8nZFEKsyzNBUKWMOFKsuY48gaVCYtOBgvZceoEGfAZK+DwX4gW6rw68yxAcIXsxZFV9fvfCa fkSK4SOlXt0J49eWjKFFKah99rcOD4wrm5Q9ODvI7ASlwEGgW6/8f8iU7Y2D+v33zFwmVbDqPLQ rumhqaQFkSFO9l+2yWuOvTIq7boaWo/vVwzev02a+2yt+MNeQBJLhaU080mT2KeMl+KAiLr3T7/ 74ZxAAx+1HKJIcTOFil15pq6m5TYfI9DKo7N1HeRwwgKQDIy X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:58:10 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374967839424693 X-GMAIL-MSGID: 1783374967839424693 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Reviewed-by: Konrad Dybcio Signed-off-by: Uwe Kleine-König --- drivers/mfd/qcom-pm8xxx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/qcom-pm8xxx.c b/drivers/mfd/qcom-pm8xxx.c index 07c531bd1236..8b6285f687da 100644 --- a/drivers/mfd/qcom-pm8xxx.c +++ b/drivers/mfd/qcom-pm8xxx.c @@ -585,19 +585,17 @@ static int pm8xxx_remove_child(struct device *dev, void *unused) return 0; } -static int pm8xxx_remove(struct platform_device *pdev) +static void pm8xxx_remove(struct platform_device *pdev) { struct pm_irq_chip *chip = platform_get_drvdata(pdev); device_for_each_child(&pdev->dev, NULL, pm8xxx_remove_child); irq_domain_remove(chip->irqdomain); - - return 0; } static struct platform_driver pm8xxx_driver = { .probe = pm8xxx_probe, - .remove = pm8xxx_remove, + .remove_new = pm8xxx_remove, .driver = { .name = "pm8xxx-core", .of_match_table = pm8xxx_id_table,