Message ID | 20231123165627.492259-13-u.kleine-koenig@pengutronix.de |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp581478vqx; Thu, 23 Nov 2023 08:57:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IGGJTGAK5y+XvC3/ZQmnYBmSpjyVZ5g5ZDbg1pGUs1+m0NMfbGSPmwuBAb+NMpCPO4oZzcI X-Received: by 2002:a05:6a20:7d85:b0:18b:c927:d30f with SMTP id v5-20020a056a207d8500b0018bc927d30fmr260439pzj.10.1700758649951; Thu, 23 Nov 2023 08:57:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758649; cv=none; d=google.com; s=arc-20160816; b=QubxrPXJXEU0yan1JwbboV3Uym5Dt5e12TUdIWFMqAjlAArTOKdVgRYLcfhnn7a8Rz zq7HsXDParJxAm3IxK5Dt4qCa8Bamq4oGVba3aB5KtDjni41kaKLOf0Hbg02XF/Iqh/E 09lJg4z7trGcu6ZHEfl0otdVOHvvTudI9TJB5NLy96C2Gft3IbcKVvMfAre1GNkSaWqn Vq/0VsJTWxgmvPJj4rnO1WVuDmVWfjyYAYrexCrFvkbUVOJMb1XsPEtIJCD3+WVeEdca +in0E++mmYaAaf7Fxto0OjXXYcshTp3nX2JuNpg9zz073Bbl9mGLB5MMfdkmJ2JlNjqs zMmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=rYgoKVKU1CrWMupKRq0B9CX3znaO9RKxXc9mKyqkpO0=; fh=Zdg/IaJWIkan+8kr6bDKmrlAn6GL271tZGmx1ajMHC0=; b=IgHAZO1n+5iLJGgMxGW9DDlCzdVRFv+cvbY2sZ5g+CoQKsFU5UqBuU/9aj2q1uxPPW Y4bkwCQlIra9uexxWEe8daNrZfYayG77aJuZZeDEypytpTwuCCppKJ3fHlLnkTW7nG3w oCPdfDdlCmCJlvcxgydHPBYZBwxJNSz9+b8OATvXc8y6nmKCpVJxaB5hNZ8cBOw16Gjr h5AX8Rw9ib6ancQzlRkbHMcFpKrAQcva2SoXs/ExwOQaQ3QrA8XaQz4937TL1gMAffY+ 8BBA3/1JuCcWUKFZfFENjqaahE1mSz85T9f/mSX3P5thfCwV2xIqP85qHVEiQjPCDKq/ LQ1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id bo9-20020a17090b090900b00283a0cb5b9bsi1596134pjb.58.2023.11.23.08.57.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 08:57:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 2F60B8260C09; Thu, 23 Nov 2023 08:57:24 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345207AbjKWQ5E (ORCPT <rfc822;ouuuleilei@gmail.com> + 99 others); Thu, 23 Nov 2023 11:57:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229930AbjKWQ44 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 23 Nov 2023 11:56:56 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2509DD53 for <linux-kernel@vger.kernel.org>; Thu, 23 Nov 2023 08:57:02 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <ukl@pengutronix.de>) id 1r6D0f-00057i-D2; Thu, 23 Nov 2023 17:57:01 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1r6D0f-00B55D-0Z; Thu, 23 Nov 2023 17:57:01 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1r6D0e-006ozo-Ns; Thu, 23 Nov 2023 17:57:00 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de> To: Lee Jones <lee@kernel.org> Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 12/18] mfd: pcf50633-adc: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:40 +0100 Message-ID: <20231123165627.492259-13-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Developer-Signature: v=1; a=openpgp-sha256; l=1835; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=FtAnMobifYM32sw3SvUnyTDhNGwr52N00NU39uqq4PY=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RJMlhOsi8S7zcdLMJJGez9KN5J7DTm4Ovzc h33JyjXZYOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+ESQAKCRCPgPtYfRL+ TsSrCACGgOBx/tuJ6VjMhZrKaZ5Q4ORmRr+AKmZ/Jdi25XfzGMxN/QVvYjz4MZIcgK32AbMhuI+ lpzQq5URbuFHW6IUTN6TJj+/ttUcpwjyZt0nZ05mH8upuNsv0f61od4P2RErgPI22odTknb45NU AsK4vOceNV9AWvjJwkGeJFVmMo/DGJ4kHYOQVeliQmEZKdR8I5KlJbWHIfTdHiD9o6JFekGRDNa C4iM72L7ALHRA7LJSZwPf4BezOAqkNl0zR20e3n3ubAOAst4R25Q6gdq3E/MbxnKvh/F8gK/ZE2 5g7BkpUNuzlwXzz6rSI+ErdEhGIaQvol7QNcZNAQr8/hIs2u X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:57:24 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374702375760691 X-GMAIL-MSGID: 1783374702375760691 |
Series |
mfd: Convert to platform remove callback returning void
|
|
Commit Message
Uwe Kleine-König
Nov. 23, 2023, 4:56 p.m. UTC
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/mfd/pcf50633-adc.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/mfd/pcf50633-adc.c b/drivers/mfd/pcf50633-adc.c index 191b1bc6141c..ab55906f91f9 100644 --- a/drivers/mfd/pcf50633-adc.c +++ b/drivers/mfd/pcf50633-adc.c @@ -218,7 +218,7 @@ static int pcf50633_adc_probe(struct platform_device *pdev) return 0; } -static int pcf50633_adc_remove(struct platform_device *pdev) +static void pcf50633_adc_remove(struct platform_device *pdev) { struct pcf50633_adc *adc = platform_get_drvdata(pdev); int i, head; @@ -236,8 +236,6 @@ static int pcf50633_adc_remove(struct platform_device *pdev) kfree(adc->queue[i]); mutex_unlock(&adc->queue_mutex); - - return 0; } static struct platform_driver pcf50633_adc_driver = { @@ -245,7 +243,7 @@ static struct platform_driver pcf50633_adc_driver = { .name = "pcf50633-adc", }, .probe = pcf50633_adc_probe, - .remove = pcf50633_adc_remove, + .remove_new = pcf50633_adc_remove, }; module_platform_driver(pcf50633_adc_driver);