From patchwork Thu Nov 23 16:56:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169037 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp581726vqx; Thu, 23 Nov 2023 08:58:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IGbatX5MFq1yftGP/xiHMhOaxCgLQRhfVG+laP8F6zvAzc9LG5WbiJ59z7iU6qObhRoMM+d X-Received: by 2002:a17:90b:1d09:b0:285:80d5:6e51 with SMTP id on9-20020a17090b1d0900b0028580d56e51mr81524pjb.21.1700758683286; Thu, 23 Nov 2023 08:58:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758683; cv=none; d=google.com; s=arc-20160816; b=E+KZ/iIffIRQ+94GBtq2oAKhQPgdGOeWpB6qcKDkDUj5dFyBA6Kue5NEDGK5bsUyCL rAb3uscIF6GXxieoH2KJniJHYcd0vPQ/uloMX6NLT4mwDZLPQ95tHxg7AIsY+JI7Juzy c7OtYMqCbOZVWrZVgBDZFbaceKoFNHCAf2MZT7gSlSOd+TXDePB9iRTLdSvIiM3i6F9k GtRztod0IW+uYGxCSOHYl/ID+TEec92rKRLnNd87hc+iEupzqOWhjveo91eydf8m3yua xgdiwPYI3KFBszTYawWf4H+tfrinNNLH/JZH76dXyPxS/Ry21OVnqJLNOm+IYLrRxN17 d2YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=tcT+1ISneeMRp40b2qlRnyZ1xpYNgyCti30IiAkMP9w=; fh=MPr1O/33eOLDJUuxTfiG33qwsHqzUAGRVnE+SCXoc58=; b=pn9hDy21SRaqj1A1fKVyS4Lxzkg56DJXTrMvwooSf+4Qxc96uTjS7c87I8DGSaRrY0 uIBFUeuQxyaGCxHvqdFsFBxXWwZ9QjQbQA2FdgStBuKx+yzF2Tz2uFbNzGZ/MyRc/Uie YvDVkAaGBr3L3vaizv17SMFrS9kwpO3hWBni9GHFa/dPB1RlE7voocl6btoNAU5+EU7r k4YDfrdQIy9KIhDY+dK0qcSlz88InRf8a55ytpqjDrhoCOJiPXwwgWq9m+toFH285rms WSgbHLhGp/vDn8M6Le0HiSkmsVAuzVMk34/07xME7nuViwfJg4764FBv/mrbB2aw1nOc X1Zg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id x17-20020a17090a789100b002801dcaf6a9si2108401pjk.64.2023.11.23.08.58.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 08:58:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id C5EA98290981; Thu, 23 Nov 2023 08:57:58 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345321AbjKWQ5b (ORCPT + 99 others); Thu, 23 Nov 2023 11:57:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345185AbjKWQ5B (ORCPT ); Thu, 23 Nov 2023 11:57:01 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7C30D5E for ; Thu, 23 Nov 2023 08:57:07 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0f-000572-6L; Thu, 23 Nov 2023 17:57:01 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0e-00B559-OK; Thu, 23 Nov 2023 17:57:00 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0e-006ozk-FA; Thu, 23 Nov 2023 17:57:00 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: Tony Lindgren , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 11/18] mfd: omap-usb-tll: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:39 +0100 Message-ID: <20231123165627.492259-12-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1867; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=6grJxx2LHRITrZAbOAlfmI+2kXgEuMJigw1AAr3yPog=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RIFwziiGXsZn1On1/MovUspXu733lLnlJFD RweOUzkJcaJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+ESAAKCRCPgPtYfRL+ TvoiB/420e3zD2ZZI9dSb9u1sLR6OEJ63GxYAc51glsm6MAZhyys0dNzjVte35LL+w8oHPQKf79 4WA6Ugt2sTgD9fOcRoPM0wv35ApqXwf6dYwBdISkQVFIUcMsql5XWbJ6zlSSEIooEl9Q+lgjvsQ zRuiAm0/psL39x8zoXNCYJzoif+fi8lZp5xUlsrnXbLYqV7qlhM2cRwIdYWGM3q96tuWxtrTl2w IvN+uykum8DzDcXeG0WNKJQAQL2jCkl35Kafzzs9WauOkBpu1/6FaDAdzrv1p+3PD0Ci2mYLFK0 uSpw69ugywtV/QdI/BEKquIyLcjVxfKTRoGUDf6YR4D4LK8S X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:57:59 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374737183348588 X-GMAIL-MSGID: 1783374737183348588 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mfd/omap-usb-tll.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c index 906353735c78..b6303ddb013b 100644 --- a/drivers/mfd/omap-usb-tll.c +++ b/drivers/mfd/omap-usb-tll.c @@ -270,7 +270,7 @@ static int usbtll_omap_probe(struct platform_device *pdev) * * Reverses the effect of usbtll_omap_probe(). */ -static int usbtll_omap_remove(struct platform_device *pdev) +static void usbtll_omap_remove(struct platform_device *pdev) { struct usbtll_omap *tll = platform_get_drvdata(pdev); int i; @@ -287,7 +287,6 @@ static int usbtll_omap_remove(struct platform_device *pdev) } pm_runtime_disable(&pdev->dev); - return 0; } static const struct of_device_id usbtll_omap_dt_ids[] = { @@ -303,7 +302,7 @@ static struct platform_driver usbtll_omap_driver = { .of_match_table = usbtll_omap_dt_ids, }, .probe = usbtll_omap_probe, - .remove = usbtll_omap_remove, + .remove_new = usbtll_omap_remove, }; int omap_tll_init(struct usbhs_omap_platform_data *pdata)