From patchwork Thu Nov 23 16:56:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169040 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp581793vqx; Thu, 23 Nov 2023 08:58:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IFHKjGERW6X6ph7ChkXrGQcBbwNieg2lGMBPCR0rXTKNjRAJcw4ilESOXJM/IIwZD908KRe X-Received: by 2002:a05:6a20:3c8a:b0:140:6979:295d with SMTP id b10-20020a056a203c8a00b001406979295dmr239543pzj.2.1700758693282; Thu, 23 Nov 2023 08:58:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758693; cv=none; d=google.com; s=arc-20160816; b=poKsbC6d1ESe3QiJeWUjtmyMpHo0gIc3zOTpvhgmVadDi2zWakUJFUVQrmMO388hPx b+hjGdomCKH8t8A3jZQyKbEcn2dqDD6unUKsWtYiRu8hTQt62fQONhbR6tgZQbAJQ674 eTAUIRWhiD81cnqJPcJTDdFD+H100C4dINbnqFfZcYSSJik5OVsDit20YdRhn6skzXyW 7NnNvv9JJA3O2nllCFyka/r6LwkVnLZecZRQcP2dBu9VDOk2rxM0t1OnyL5F6vrb4oHk 8540rnO0FEFIB/q1802Ukgos9MKyoYl//EGi42ftN1K6mc1g4iOaEUOUmktdkoPHLlJd s7rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Jn0eLx0tD0YoJ5dMAsKpyjPkQn3MN+IzxiPG+s8xeBQ=; fh=cIjNq8AJ7DYG+w9Jtcuz1ji5cufJZKE/mbz7BhfN7Sc=; b=bhG0onoy0uKLLXwHEX8OJVsCzqBhX7yp4cSJSQTUuZgeeigbhIm5e1KtjF1c1OJIfy AKYbqATF5WVwvJllSkC3Fp0V7KbznyQMI8mMLVaWezoO92edifB6npQyLdbo2Gr7GJLS sXbuBDk/TQs2s1DtGJIlGfGwmy4a55fpoYH/kqmfEX1C3i8sbBwXSv0l6VH5W12RdKwr qyJXf73Lw9SWqlQfjuRHXzmxEEVIqBPpDjZDF7BKpJn78wnB966MelJXzwJvTqS5aqUX f0Owalx2zPT0j4B/M7wWk+mtXrq2tG1hArd7KK0oMFhAB9Jga5XBE38Oci39m2hjufLt kjqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id i18-20020a170902c95200b001b9ffda162csi1505164pla.441.2023.11.23.08.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 08:58:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 74557832DCE4; Thu, 23 Nov 2023 08:58:06 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345408AbjKWQ5u (ORCPT + 99 others); Thu, 23 Nov 2023 11:57:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345245AbjKWQ5F (ORCPT ); Thu, 23 Nov 2023 11:57:05 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6157DD7E for ; Thu, 23 Nov 2023 08:57:09 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0e-00054w-Mw; Thu, 23 Nov 2023 17:57:00 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0e-00B550-8E; Thu, 23 Nov 2023 17:57:00 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0d-006ozc-VH; Thu, 23 Nov 2023 17:56:59 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 09/18] mfd: mxs-lradc: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:37 +0100 Message-ID: <20231123165627.492259-10-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1686; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=GNK+c3Abifs5Um4n3RL+YvkDdPV3heWsrI7W1ir+IZ8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RFCaJ6YKeIfgaSRYJ+VtntxTS1jxS1g3H7Y y1ZQd/hUJeJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+ERQAKCRCPgPtYfRL+ ThjMCACQ4bf1a2PidPYlIeCGasO6BuOXhwT/Cb+640lGH78lqfL+3RaGVeFJRiCjV7hEnbuTIIU 6rAvOIPQzMmMbhyJXQz6f7955w5316eIHcoAJQONjqYWLnPRST6/t+4+O/kCMDaH8Mm+1b+8h87 cjbIy/E4SCLP1I1F1LCMfDQe6nvxntOqEPn/Xy9H0bg0gFvSKZVpJdcTcQ7+rSl0g1rOwldkA7w t7OsdALFnZblnxDLCOK267TDs5rC9O8HraKUOSw4Cu8+fzdQLO16pJwk5DM3XWTiNKvuvlelg5y oOmoCo9yd7Vg8R2b6C4skR0i9fL3yuxaxe9B7kHlZhAXrK3n X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:58:06 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374747620766192 X-GMAIL-MSGID: 1783374747620766192 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mfd/mxs-lradc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/mxs-lradc.c b/drivers/mfd/mxs-lradc.c index ec1b356562b9..73893890b50a 100644 --- a/drivers/mfd/mxs-lradc.c +++ b/drivers/mfd/mxs-lradc.c @@ -230,13 +230,11 @@ static int mxs_lradc_probe(struct platform_device *pdev) return ret; } -static int mxs_lradc_remove(struct platform_device *pdev) +static void mxs_lradc_remove(struct platform_device *pdev) { struct mxs_lradc *lradc = platform_get_drvdata(pdev); clk_disable_unprepare(lradc->clk); - - return 0; } static struct platform_driver mxs_lradc_driver = { @@ -245,7 +243,7 @@ static struct platform_driver mxs_lradc_driver = { .of_match_table = mxs_lradc_dt_ids, }, .probe = mxs_lradc_probe, - .remove = mxs_lradc_remove, + .remove_new = mxs_lradc_remove, }; module_platform_driver(mxs_lradc_driver);