Message ID | 20231122235050.2966280-1-robh@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6358:6f03:b0:164:83eb:24d7 with SMTP id r3csp1579231rwn; Wed, 22 Nov 2023 15:52:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IHqeSDVX5X11mPC1yiswWjYUl2jfwCRk3ZyhM1dRKE0rA5KZ/TPkefVTDWxy/YiPiWASWN/ X-Received: by 2002:a05:6a20:914f:b0:18a:d8a3:d56c with SMTP id x15-20020a056a20914f00b0018ad8a3d56cmr4012437pzc.57.1700697159707; Wed, 22 Nov 2023 15:52:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700697159; cv=none; d=google.com; s=arc-20160816; b=WTJwTjw3t6gkOWqLEUuYUZDz43gIivIrEYXUmrxHAzAC+e4EUDC+s0cxJcRPMz+ac8 VDIhLDoAMMST3gbYXa2c9O4tQRrCfXFh1X74wMqUvb0/2Gxh98VES2OiVRnNzmcxTDtO zRJOEpKWaH6oOWsYvZVI0WLVIecjiK+cLMGsG+xX7bR5Lj6EGYtLCibk60XzDYfnRhjM HNhFoWahtg/OM31mbhUrfxbefT4fKxT+VM25FCBvJSGuBRQd3E3N+j8FCek47EZSjFkD mXAPly1SNU1stAQQebhc96oo4kto2Bii3tS1Uvj0+/4V+wD5XFgFZed452ji9Uka/VuC 4CSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=S9y7B28iU5ZNUpsVCJlJk1JXKne0NiaXScyyG4NBAic=; fh=JhOapNNZ4xeSm/wcBOnJDLaNzP6rMwvlKkg4Z9MZqaM=; b=Zd4qUXji8QzVMCGKWDVhAhpsDLuRp7ev1KxJQ03t+fiwKXxC7V8u+Z4svfabiaHKer dEQGuwYSgTp15u3RHMAXyIDfr42SUS5vA/+Lctnmv21Xpa6QD5DLnjeHzqR9ik8G1a6s wD/J1ghbbk3mfNv7OslpN7RRmTdPPjz3mNKQjhdaHxlF3s5UGSbv686iwNjVOBPgXqv8 CrjsZcyMV8Z2dJqdCB8LB33Q49iTgjPjEUtWH8kO38eqyKoh+lunlr/EHJBMXCJEOCQM 6VbUeKapRqUmXMG0J49KvQ4ebGXEEBQtMPJZ21j2rIiU9Dz+/cGZWFl/nHVVmS5UtKfT p0WA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id ep2-20020a17090ae64200b00285259acbcesi132168pjb.142.2023.11.22.15.52.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 15:52:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 2183883A9F94; Wed, 22 Nov 2023 15:51:02 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232295AbjKVXvC (ORCPT <rfc822;ouuuleilei@gmail.com> + 99 others); Wed, 22 Nov 2023 18:51:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231410AbjKVXvB (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 22 Nov 2023 18:51:01 -0500 Received: from mail-il1-f176.google.com (mail-il1-f176.google.com [209.85.166.176]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19A1C10C; Wed, 22 Nov 2023 15:50:58 -0800 (PST) Received: by mail-il1-f176.google.com with SMTP id e9e14a558f8ab-35b1d57d7dbso1023385ab.3; Wed, 22 Nov 2023 15:50:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700697057; x=1701301857; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=S9y7B28iU5ZNUpsVCJlJk1JXKne0NiaXScyyG4NBAic=; b=SITtd94WYof+ra6JeiKNSJxAqL+PPfv/GLjKc4TAJZ5TQfSWzlk7J1fCNp2jygNr18 VtMOjQYLWksLNM4kXYUKEjRFpWFi6fDy06yZCl3eQUksyKoSj1eqeM5Rl8PJ7DO78+Ld CQRKmSmUURefHhn7wnmn3J8suboQvDEPosKcoLkZ2dZXhLRcFbnXzgnYZKfUfwFuaFxM 4MHNhNVE9UgcWOSko//YNX0D0k6AnA5GqueYrFWsvAzMVb0B1vpB7Oaif8+NkveInhHR xHAwl3w1C1LlZlV9cc23/g1YukY/i8zOhfzarlw6L5ioZU9X/r4WYPX3JA1FwNNRXvJy 1eCg== X-Gm-Message-State: AOJu0YwlK/Izstvx/oLHLuE1P41vDBZj5GuQQwdLBTBbCR4F0isLvFmY eVyjNI/ySOdPmKm/4X7D+A== X-Received: by 2002:a92:cc41:0:b0:359:4048:38e0 with SMTP id t1-20020a92cc41000000b00359404838e0mr4017608ilq.0.1700697057292; Wed, 22 Nov 2023 15:50:57 -0800 (PST) Received: from herring.priv ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id ck14-20020a056e02370e00b00359d156386csm214367ilb.4.2023.11.22.15.50.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 15:50:56 -0800 (PST) Received: (nullmailer pid 2966454 invoked by uid 1000); Wed, 22 Nov 2023 23:50:55 -0000 From: Rob Herring <robh@kernel.org> To: Vinod Koul <vkoul@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org> Cc: dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] dt-bindings: dma: Drop undocumented examples Date: Wed, 22 Nov 2023 16:50:50 -0700 Message-ID: <20231122235050.2966280-1-robh@kernel.org> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 22 Nov 2023 15:51:02 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783310225233486088 X-GMAIL-MSGID: 1783310225233486088 |
Series |
dt-bindings: dma: Drop undocumented examples
|
|
Commit Message
Rob Herring
Nov. 22, 2023, 11:50 p.m. UTC
The compatibles "ti,omap-sdma" and "ti,dra7-dma-crossbar" aren't documented
by a schema which causes warnings:
Documentation/devicetree/bindings/dma/dma-controller.example.dtb: /example-0/dma-controller@48000000: failed to match any schema with compatible: ['ti,omap-sdma']
Documentation/devicetree/bindings/dma/dma-router.example.dtb: /example-0/dma-router@4a002b78: failed to match any schema with compatible: ['ti,dra7-dma-crossbar']
As no one has cared to fix them, just drop them.
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/dma/dma-controller.yaml | 15 ---------------
.../devicetree/bindings/dma/dma-router.yaml | 11 -----------
2 files changed, 26 deletions(-)
Comments
On 23/11/2023 00:50, Rob Herring wrote: > The compatibles "ti,omap-sdma" and "ti,dra7-dma-crossbar" aren't documented > by a schema which causes warnings: > > Documentation/devicetree/bindings/dma/dma-controller.example.dtb: /example-0/dma-controller@48000000: failed to match any schema with compatible: ['ti,omap-sdma'] > Documentation/devicetree/bindings/dma/dma-router.example.dtb: /example-0/dma-router@4a002b78: failed to match any schema with compatible: ['ti,dra7-dma-crossbar'] > > As no one has cared to fix them, just drop them. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 22-11-23, 16:50, Rob Herring wrote: > The compatibles "ti,omap-sdma" and "ti,dra7-dma-crossbar" aren't documented > by a schema which causes warnings: > > Documentation/devicetree/bindings/dma/dma-controller.example.dtb: /example-0/dma-controller@48000000: failed to match any schema with compatible: ['ti,omap-sdma'] > Documentation/devicetree/bindings/dma/dma-router.example.dtb: /example-0/dma-router@4a002b78: failed to match any schema with compatible: ['ti,dra7-dma-crossbar'] So instead now we will have undocumented ti-omap-sdma? Adding Peter and TI folks as well > As no one has cared to fix them, just drop them. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > .../devicetree/bindings/dma/dma-controller.yaml | 15 --------------- > .../devicetree/bindings/dma/dma-router.yaml | 11 ----------- > 2 files changed, 26 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/dma-controller.yaml b/Documentation/devicetree/bindings/dma/dma-controller.yaml > index 04d150d4d15d..e6afca558c2d 100644 > --- a/Documentation/devicetree/bindings/dma/dma-controller.yaml > +++ b/Documentation/devicetree/bindings/dma/dma-controller.yaml > @@ -19,19 +19,4 @@ properties: > > additionalProperties: true > > -examples: > - - | > - dma: dma-controller@48000000 { > - compatible = "ti,omap-sdma"; > - reg = <0x48000000 0x1000>; > - interrupts = <0 12 0x4>, > - <0 13 0x4>, > - <0 14 0x4>, > - <0 15 0x4>; > - #dma-cells = <1>; > - dma-channels = <32>; > - dma-requests = <127>; > - dma-channel-mask = <0xfffe>; > - }; > - > ... > diff --git a/Documentation/devicetree/bindings/dma/dma-router.yaml b/Documentation/devicetree/bindings/dma/dma-router.yaml > index 346fe0fa4460..5ad2febc581e 100644 > --- a/Documentation/devicetree/bindings/dma/dma-router.yaml > +++ b/Documentation/devicetree/bindings/dma/dma-router.yaml > @@ -40,15 +40,4 @@ required: > > additionalProperties: true > > -examples: > - - | > - sdma_xbar: dma-router@4a002b78 { > - compatible = "ti,dra7-dma-crossbar"; > - reg = <0x4a002b78 0xfc>; > - #dma-cells = <1>; > - dma-requests = <205>; > - ti,dma-safe-map = <0>; > - dma-masters = <&sdma>; > - }; > - > ... > -- > 2.42.0
On 23/11/2023 09:52, Vinod Koul wrote: > On 22-11-23, 16:50, Rob Herring wrote: >> The compatibles "ti,omap-sdma" and "ti,dra7-dma-crossbar" aren't documented >> by a schema which causes warnings: >> >> Documentation/devicetree/bindings/dma/dma-controller.example.dtb: /example-0/dma-controller@48000000: failed to match any schema with compatible: ['ti,omap-sdma'] >> Documentation/devicetree/bindings/dma/dma-router.example.dtb: /example-0/dma-router@4a002b78: failed to match any schema with compatible: ['ti,dra7-dma-crossbar'] > > So instead now we will have undocumented ti-omap-sdma? It wasn't documented before. Nothing changes in that matter. Best regards, Krzysztof
On Wed, Nov 22, 2023 at 5:50 PM Rob Herring <robh@kernel.org> wrote: > > The compatibles "ti,omap-sdma" and "ti,dra7-dma-crossbar" aren't documented > by a schema which causes warnings: > > Documentation/devicetree/bindings/dma/dma-controller.example.dtb: /example-0/dma-controller@48000000: failed to match any schema with compatible: ['ti,omap-sdma'] > Documentation/devicetree/bindings/dma/dma-router.example.dtb: /example-0/dma-router@4a002b78: failed to match any schema with compatible: ['ti,dra7-dma-crossbar'] > > As no one has cared to fix them, just drop them. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > .../devicetree/bindings/dma/dma-controller.yaml | 15 --------------- > .../devicetree/bindings/dma/dma-router.yaml | 11 ----------- > 2 files changed, 26 deletions(-) Vinod, Can you pick this up please. As pointed out, examples don't document anything. "ti,omap-sdma" is not documented at all (though in use). "ti,dra7-dma-crossbar" is documented in dma/ti-dma-crossbar.txt and there's still an example there. Rob
On 07-12-23, 14:59, Rob Herring wrote: > On Wed, Nov 22, 2023 at 5:50 PM Rob Herring <robh@kernel.org> wrote: > > > > The compatibles "ti,omap-sdma" and "ti,dra7-dma-crossbar" aren't documented > > by a schema which causes warnings: > > > > Documentation/devicetree/bindings/dma/dma-controller.example.dtb: /example-0/dma-controller@48000000: failed to match any schema with compatible: ['ti,omap-sdma'] > > Documentation/devicetree/bindings/dma/dma-router.example.dtb: /example-0/dma-router@4a002b78: failed to match any schema with compatible: ['ti,dra7-dma-crossbar'] > > > > As no one has cared to fix them, just drop them. > > > > Signed-off-by: Rob Herring <robh@kernel.org> > > --- > > .../devicetree/bindings/dma/dma-controller.yaml | 15 --------------- > > .../devicetree/bindings/dma/dma-router.yaml | 11 ----------- > > 2 files changed, 26 deletions(-) > > Vinod, Can you pick this up please. > > As pointed out, examples don't document anything. "ti,omap-sdma" is > not documented at all (though in use). "ti,dra7-dma-crossbar" is > documented in dma/ti-dma-crossbar.txt and there's still an example > there. Sure, queued up now
On Wed, 22 Nov 2023 16:50:50 -0700, Rob Herring wrote: > The compatibles "ti,omap-sdma" and "ti,dra7-dma-crossbar" aren't documented > by a schema which causes warnings: > > Documentation/devicetree/bindings/dma/dma-controller.example.dtb: /example-0/dma-controller@48000000: failed to match any schema with compatible: ['ti,omap-sdma'] > Documentation/devicetree/bindings/dma/dma-router.example.dtb: /example-0/dma-router@4a002b78: failed to match any schema with compatible: ['ti,dra7-dma-crossbar'] > > As no one has cared to fix them, just drop them. > > [...] Applied, thanks! [1/1] dt-bindings: dma: Drop undocumented examples commit: 4a8ececbb50f0dd9395ffc4188ae780916df4a9c Best regards,
diff --git a/Documentation/devicetree/bindings/dma/dma-controller.yaml b/Documentation/devicetree/bindings/dma/dma-controller.yaml index 04d150d4d15d..e6afca558c2d 100644 --- a/Documentation/devicetree/bindings/dma/dma-controller.yaml +++ b/Documentation/devicetree/bindings/dma/dma-controller.yaml @@ -19,19 +19,4 @@ properties: additionalProperties: true -examples: - - | - dma: dma-controller@48000000 { - compatible = "ti,omap-sdma"; - reg = <0x48000000 0x1000>; - interrupts = <0 12 0x4>, - <0 13 0x4>, - <0 14 0x4>, - <0 15 0x4>; - #dma-cells = <1>; - dma-channels = <32>; - dma-requests = <127>; - dma-channel-mask = <0xfffe>; - }; - ... diff --git a/Documentation/devicetree/bindings/dma/dma-router.yaml b/Documentation/devicetree/bindings/dma/dma-router.yaml index 346fe0fa4460..5ad2febc581e 100644 --- a/Documentation/devicetree/bindings/dma/dma-router.yaml +++ b/Documentation/devicetree/bindings/dma/dma-router.yaml @@ -40,15 +40,4 @@ required: additionalProperties: true -examples: - - | - sdma_xbar: dma-router@4a002b78 { - compatible = "ti,dra7-dma-crossbar"; - reg = <0x4a002b78 0xfc>; - #dma-cells = <1>; - dma-requests = <205>; - ti,dma-safe-map = <0>; - dma-masters = <&sdma>; - }; - ...