From patchwork Wed Nov 22 17:58:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hugo Villeneuve X-Patchwork-Id: 168493 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2b07:b0:403:3b70:6f57 with SMTP id io7csp1505269vqb; Wed, 22 Nov 2023 09:59:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IEr5I5yAc3g13phNrUbMWtXkTuBopGKFAlyiqbW2x6RYveX0NAarlrInPrfQ63p4XjJbIU6 X-Received: by 2002:a17:90b:1bcf:b0:282:cb42:246b with SMTP id oa15-20020a17090b1bcf00b00282cb42246bmr3058201pjb.40.1700675979262; Wed, 22 Nov 2023 09:59:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700675979; cv=none; d=google.com; s=arc-20160816; b=rXqOqvOJ64G4o5jVRoiF5yLC4Wu0TQQHG9doIZ6H/7OKKR06PTBPGjB9XSkwkmlLDC 8dg64yCm9LsoQYs8FahM6O2QWGD5eLiqC+hE6PLUGcPncRNdJ+3dPsk7YQBXpTte4OL4 krCEir3CHCIR0XJxZCIibD0K6f2HQ6BwbnZQRFPvQw4W7HKbGvOFBO3K+XdlXkDw69yd 1+pqnEaQwiI+0NleAHZuRHKR0slLv7n731xUJxdGu59N9kN7q4DN0QvGYZxkzo7tqd8n fNzzYwyV8nGdMK7jD217up/6+D5JYNQhIZBDQg1EO6ZCpHOKjhffKLN9FFK0ISC9tGmv iM2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :message-id:date:cc:to:from:dkim-signature; bh=BuF5Rm4s6M217X/U1K5BQhU00lWtXZ8dQ8SUtzZjsGM=; fh=Nz6ne7h+AgCzD1lryOzZAocqC56o6aNMrzsKseIZn0k=; b=XVghD/k5/k/KL/6K3DCqDH0R9O5MmUexhmhFCzA9YWkxj65NiHkDU47Y/BjJZKJ28m CYWEHPGc4Z0PYiBY2ehetTAlFx3qU1/6UD4hilXTCPvYaw3bf2SDwKVF142hof9baDZV SOWf3m3rlkEAJJH+MuC99Ojq75fMmr9ii+u+kSJ5kL8NT1/ivAYGXA529xD7iCFn5gnu CYbUFLhmWQ040xZK1OpNhmBLj6skQD8pJHMJRXCHPZDcwIRWlKBsdcC90h4UejHm7yhV EcTGwEKYZrrbu2MI7mxviNiXGTZFp7Rw33TVyk5Gl5unrh0P0mjNahjlHQ4f8cHzETor q2ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@hugovil.com header.s=x header.b=Yo9pnX9J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id fr21-20020a17090ae2d500b002839b4b17a9si110833pjb.97.2023.11.22.09.59.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 09:59:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@hugovil.com header.s=x header.b=Yo9pnX9J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 686588257E3C; Wed, 22 Nov 2023 09:59:11 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231410AbjKVR7M (ORCPT + 99 others); Wed, 22 Nov 2023 12:59:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230377AbjKVR7L (ORCPT ); Wed, 22 Nov 2023 12:59:11 -0500 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0612112; Wed, 22 Nov 2023 09:59:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Cc:To :From:subject:date:message-id:reply-to; bh=BuF5Rm4s6M217X/U1K5BQhU00lWtXZ8dQ8SUtzZjsGM=; b=Yo9pnX9J+bpTdoFD2661sN1cvD 39exH1gyt8h+s+uewECF2UNAZBRv+HZCQg8kNjv0X3qkmaPRQIgAWvkKk9MeOI2bmg8ojy+Y5Efo1 it3yuqno9VggZjjJuZEoWSfAgXAbc1ViklqAG7ymlPYdUlU9bpGGTiee6KL8/sD+LdxM=; Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:55790 helo=pettiford.lan) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1r5rV8-00014i-2e; Wed, 22 Nov 2023 12:59:03 -0500 From: Hugo Villeneuve To: Greg Kroah-Hartman , Jiri Slaby Cc: hugo@hugovil.com, Hugo Villeneuve , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Date: Wed, 22 Nov 2023 12:58:59 -0500 Message-Id: <20231122175859.3874753-1-hugo@hugovil.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 70.80.174.168 X-SA-Exim-Mail-From: hugo@hugovil.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 Subject: [PATCH] serial: sc16is7xx: change confusing comment about Tx FIFO X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 22 Nov 2023 09:59:11 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783288015625307968 X-GMAIL-MSGID: 1783288015625307968 From: Hugo Villeneuve The comment wording can be confusing, as txlen will return the number of bytes available in the FIFO, which can be less than the maximum theoretical Tx FIFO size. Change the comment so that it is unambiguous. Signed-off-by: Hugo Villeneuve --- drivers/tty/serial/sc16is7xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 98b1cc82c4affc16f5598d4fa14b1858671b2263 diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index db2bb1c0d36c..43776aabea41 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -675,7 +675,7 @@ static void sc16is7xx_handle_tx(struct uart_port *port) /* Get length of data pending in circular buffer */ to_send = uart_circ_chars_pending(xmit); if (likely(to_send)) { - /* Limit to size of TX FIFO */ + /* Limit to space available in TX FIFO */ txlen = sc16is7xx_port_read(port, SC16IS7XX_TXLVL_REG); if (txlen > SC16IS7XX_FIFO_SIZE) { dev_err_ratelimited(port->dev,