Message ID | 20231122175039.2289945-1-andriy.shevchenko@linux.intel.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2b07:b0:403:3b70:6f57 with SMTP id io7csp1501165vqb; Wed, 22 Nov 2023 09:51:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IHvQIQdaNZNLPdrfLDM3tgRTsxXlbr3JOOQxmvIXCFZ765qd2o4da00E5LdTX3HR6lSOwWg X-Received: by 2002:a05:6a20:e117:b0:18b:4e39:835 with SMTP id kr23-20020a056a20e11700b0018b4e390835mr2296905pzb.31.1700675510058; Wed, 22 Nov 2023 09:51:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700675510; cv=none; d=google.com; s=arc-20160816; b=RicnbRJoRLNp1pPPIU74TU75xZqtt4+sKkojOWp6eHWpkVfk0bcNPPF6uV1AX5HF1/ OEFawva/H3e4L+RtPsRRwLfDE4CqAgGPVR92pvWX9R7aZZPAHr5D7iJXS88l0AWHY+V2 Z2VXMFd3ajIZVvMaJdCC5lz3uzfpwJCzHelZyIXB4GXVLhjo7jG012d/WEAGEL/Whhvt LmNKArWQSwOdFTItnNIwGhx5B2QB8U2Q7LJPxF50GzhoHZ34lCkcTw9GzyNRw+tZKgPw IXb762Rp82Rprm6pvwYBXBYmiUGiWs5pZzIIkYbUyvfKwohF8LwsUILrw/jzMWEIE+yo fo7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=BM5fs4esy+k5v3EYGFizC6cDbdSTDlIHniSX2YM0OkE=; fh=5FU642BpIFAr4AKyJrXFMz4Yus9QjD/h8EEeKBF2tLg=; b=j9Qc/7DN35anybXdjh7zx9Opw7yVeMtDJDYHlTFKj7ia9oD4lEZhrVYmxvQg+IfMkO DudxpXVOuHnGmIxOTg6+KxczRi0wV8HcygMxaIxECEjr/2Yl3EQZwwfFQSz4nRU0w/Up qaiceEuhf4Wh/3vLsXpUnrikOwgQfEeRyuLMv3ySpbkT4qI6p7AZXyT6MAudGtYojlzE 4QdmDiq1jUJU+0cideD+1ZQ9/9StixubhUGbIwQz76HjQS8fBd7mJ9w1egc2YVwuklLY 2Gucdzvfjd2gW4x98SO6k3Iprq9ddTc8c4vrrQZzQeE/6r1D+WI8KwZjekBP4VXV90L7 dvLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XmdDKZzD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id x20-20020aa79414000000b006c3182d2a84si12467964pfo.322.2023.11.22.09.51.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 09:51:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XmdDKZzD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 7CB02822CA8C; Wed, 22 Nov 2023 09:51:11 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233995AbjKVRvH (ORCPT <rfc822;ouuuleilei@gmail.com> + 99 others); Wed, 22 Nov 2023 12:51:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231789AbjKVRvD (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 22 Nov 2023 12:51:03 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1269D9A; Wed, 22 Nov 2023 09:51:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700675459; x=1732211459; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=vjM99oJF/e2ni3/auPFYtDFRthGYsyUVZgmaU1qFAN0=; b=XmdDKZzDMDCjZ1URGjnyH3YjR/q71E3JctUi/QIK/rnWmpwYSLuWWo3e IGJRngLZRRcgVMgoj0S+ClsTdZbhhGw79qVhikeJBRbXl2DGhuid++OWS A+9dztKxixvXgMCLgAQNx+6f+l0Fc6kI1W5ke7ztMp6te8ijw3qOUAtxS OV7go9NUwvhVHpsIOnN5eySUeGbMkyaq4zpwRvZjuO8PN4G+iiYgNbhNq Cf/aHeum6QZ6KjCpbdeNF4/Lmj+V/rptsjjPTL5e4Lq/IJZtlu0gMEwz4 gZjWnEJ0G/LJ5HSJRmn6cM08CrEoV85gU873Y6HM0tPzz+/vsO9uyAecG w==; X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="456431556" X-IronPort-AV: E=Sophos;i="6.04,219,1695711600"; d="scan'208";a="456431556" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 09:50:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="770707124" X-IronPort-AV: E=Sophos;i="6.04,219,1695711600"; d="scan'208";a="770707124" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga007.fm.intel.com with ESMTP; 22 Nov 2023 09:50:56 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id E02AC2A2; Wed, 22 Nov 2023 19:50:54 +0200 (EET) From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mika Westerberg <mika.westerberg@linux.intel.com>, Andy Shevchenko <andy@kernel.org>, Linus Walleij <linus.walleij@linaro.org> Subject: [PATCH v1 1/4] pinctrl: baytrail: Fix types of config value in byt_pin_config_set() Date: Wed, 22 Nov 2023 19:50:36 +0200 Message-ID: <20231122175039.2289945-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 22 Nov 2023 09:51:11 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783287523323690850 X-GMAIL-MSGID: 1783287523323690850 |
Series |
[v1,1/4] pinctrl: baytrail: Fix types of config value in byt_pin_config_set()
|
|
Commit Message
Andy Shevchenko
Nov. 22, 2023, 5:50 p.m. UTC
When unpacked, the config value is split to two of different types.
Fix the types accordingly.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/intel/pinctrl-baytrail.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On Wed, Nov 22, 2023 at 07:50:36PM +0200, Andy Shevchenko wrote: > When unpacked, the config value is split to two of different types. > Fix the types accordingly. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> There was one typo which I commented (please fix when applying). Otherwise the series looks good to me, Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
On Fri, Nov 24, 2023 at 07:33:39AM +0200, Mika Westerberg wrote: > On Wed, Nov 22, 2023 at 07:50:36PM +0200, Andy Shevchenko wrote: > > When unpacked, the config value is split to two of different types. > > Fix the types accordingly. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > There was one typo which I commented (please fix when applying). > Otherwise the series looks good to me, > > Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com> Fixed locally. Pushed to my review and testing queue, thanks!
diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c index 3cd0798ee631..f1af21dbd5fb 100644 --- a/drivers/pinctrl/intel/pinctrl-baytrail.c +++ b/drivers/pinctrl/intel/pinctrl-baytrail.c @@ -918,13 +918,14 @@ static int byt_pin_config_set(struct pinctrl_dev *pctl_dev, unsigned int num_configs) { struct intel_pinctrl *vg = pinctrl_dev_get_drvdata(pctl_dev); - unsigned int param, arg; void __iomem *conf_reg = byt_gpio_reg(vg, offset, BYT_CONF0_REG); void __iomem *val_reg = byt_gpio_reg(vg, offset, BYT_VAL_REG); void __iomem *db_reg = byt_gpio_reg(vg, offset, BYT_DEBOUNCE_REG); u32 conf, val, db_pulse, debounce; + enum pin_config_param param; unsigned long flags; int i, ret = 0; + u32 arg; raw_spin_lock_irqsave(&byt_lock, flags);