diff mbox series

clk: qcom: gpucc-sm8150: Update the gpu_cc_pll1 config

Message ID 20231122042814.4158076-1-quic_skakitap@quicinc.com
State New
Headers
Series clk: qcom: gpucc-sm8150: Update the gpu_cc_pll1 config |

Commit Message

Satya Priya Kakitapalli Nov. 22, 2023, 4:28 a.m. UTC 
  Update the test_ctl_hi_val and test_ctl_hi1_val of gpu_cc_pll1
as per latest HW recommendation.

Fixes: 0cef71f2ccc8 ("clk: qcom: Add graphics clock controller driver for SM8150")
Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
---
 drivers/clk/qcom/gpucc-sm8150.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Konrad Dybcio Nov. 22, 2023, 4:02 p.m. UTC | #1 
On 11/22/23 05:28, Satya Priya Kakitapalli wrote:
> Update the test_ctl_hi_val and test_ctl_hi1_val of gpu_cc_pll1
> as per latest HW recommendation.
IIRC there is SM8150 v2.1 that's there on most devices and v2.2
that was used on the Microsoft Duo (or v2.0 and v2.1 respectively,
not sure, don't have any device on hand to read it back), do these
settings apply to both? Are they different for mobile vs auto?

Konrad
Satya Priya Kakitapalli Nov. 24, 2023, 11:24 a.m. UTC | #2 
On 11/22/2023 9:32 PM, Konrad Dybcio wrote:
>
>
> On 11/22/23 05:28, Satya Priya Kakitapalli wrote:
>> Update the test_ctl_hi_val and test_ctl_hi1_val of gpu_cc_pll1
>> as per latest HW recommendation.
> IIRC there is SM8150 v2.1 that's there on most devices and v2.2
> that was used on the Microsoft Duo (or v2.0 and v2.1 respectively,
> not sure, don't have any device on hand to read it back), do these
> settings apply to both? Are they different for mobile vs auto?
>

Yes these settings apply to all v2.x devices, also they are same for 
auto and mobile.


> Konrad
Konrad Dybcio Nov. 25, 2023, 11:40 a.m. UTC | #3 
On 24.11.2023 12:24, Satya Priya Kakitapalli (Temp) wrote:
> 
> On 11/22/2023 9:32 PM, Konrad Dybcio wrote:
>>
>>
>> On 11/22/23 05:28, Satya Priya Kakitapalli wrote:
>>> Update the test_ctl_hi_val and test_ctl_hi1_val of gpu_cc_pll1
>>> as per latest HW recommendation.
>> IIRC there is SM8150 v2.1 that's there on most devices and v2.2
>> that was used on the Microsoft Duo (or v2.0 and v2.1 respectively,
>> not sure, don't have any device on hand to read it back), do these
>> settings apply to both? Are they different for mobile vs auto?
>>
> 
> Yes these settings apply to all v2.x devices, also they are same for auto and mobile.
Thanks for confirming!

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
Bjorn Andersson Dec. 8, 2023, 2:55 p.m. UTC | #4 
On Wed, 22 Nov 2023 09:58:14 +0530, Satya Priya Kakitapalli wrote:
> Update the test_ctl_hi_val and test_ctl_hi1_val of gpu_cc_pll1
> as per latest HW recommendation.
> 
> 

Applied, thanks!

[1/1] clk: qcom: gpucc-sm8150: Update the gpu_cc_pll1 config
      commit: 6ebd9a4f8b8d2b35cf965a04849c4ba763722f13

Best regards,
diff mbox series

Patch

diff --git a/drivers/clk/qcom/gpucc-sm8150.c b/drivers/clk/qcom/gpucc-sm8150.c
index 8422fd047493..c89a5b59ddb7 100644
--- a/drivers/clk/qcom/gpucc-sm8150.c
+++ b/drivers/clk/qcom/gpucc-sm8150.c
@@ -37,8 +37,8 @@  static struct alpha_pll_config gpu_cc_pll1_config = {
 	.config_ctl_hi_val = 0x00002267,
 	.config_ctl_hi1_val = 0x00000024,
 	.test_ctl_val = 0x00000000,
-	.test_ctl_hi_val = 0x00000002,
-	.test_ctl_hi1_val = 0x00000000,
+	.test_ctl_hi_val = 0x00000000,
+	.test_ctl_hi1_val = 0x00000020,
 	.user_ctl_val = 0x00000000,
 	.user_ctl_hi_val = 0x00000805,
 	.user_ctl_hi1_val = 0x000000d0,