From patchwork Wed Nov 22 00:42:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Holland X-Patchwork-Id: 168046 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2b07:b0:403:3b70:6f57 with SMTP id io7csp1011309vqb; Tue, 21 Nov 2023 16:42:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IEYSFh0gyEngacQlj6/RllBzW+SgEWBC92fQDMYSFQmuHBBSVO7nkt2sFBIEmgppho8YwGQ X-Received: by 2002:a17:903:2352:b0:1cf:636f:1c14 with SMTP id c18-20020a170903235200b001cf636f1c14mr1026481plh.0.1700613769966; Tue, 21 Nov 2023 16:42:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700613769; cv=none; d=google.com; s=arc-20160816; b=NjPiSYLT7unwZGJ0ZAYAozvWETuM153rHlIePu7SgIU/oHc1ZWEvWCVN1Y72M2B35S u+XRWA7B+W0voQE1MIP4tz/AxlT/q5jH+RHL8g8cHaapY5rqqAr/pOV/uHTyOLcPf0+d +yOc53lVBVyth7AKxV+CS/DFoiRCjlgu8x7cSh1Rz2VDGuIj5GfrM1FTv/x5/ITPAFY5 HiCx4MPuKFTVS4WrXBlw0jhROOA7pPKNBmkdrRL527L3jt/XoU/81Tyw244tSVTmsCdS hP0Qq3f/rGBDtp9knnzG8BRs9QHGRQj0y0+f4k+7yPBBRYVyLIAIpDm4/rf1kM/OoJr0 rzdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=3JAG0RDoM6r+OhcBNCljqVXixFJN9onE/iS8GXZuAZc=; fh=UqPBposXCB+xJXiyhSyMav1ORaD8AxWEVu42G6G317w=; b=Fgxs6S9F1LL8cMNMcbcuaS7xa/oIN+5x8vexm06nVwmiqqx2RWzzuE30XmAagUjHhI s7FJ7QpY/fK2chaTfPtkauqw2nVbs+iD+pCaY6HlHo4EBCqGPunZqCpt7hCxdkkZduCn EbZ9X/oTvLfg8XF4GCKs2phLlgbvOfZqtWXM8CPaG0b+AZ7vLMVkikRkuZCWCIBxzLq8 nkODjOvpD0daj2b6WI9iWxksETCp/nHEdyJ5EjAnxQS2qF+0xIFHsnC4Ug9IVU6nHCBK YbT1y0IyF/b968mEq5eiQgiSq2mA6S2hur/+riasOgbSaEItEoy+AJHGKvmTfckMY3XE 0T6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=J8kBBzXN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=sifive.com Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id bc12-20020a170902930c00b001c7345bc01csi7388342plb.450.2023.11.21.16.42.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 16:42:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=J8kBBzXN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=sifive.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 55C8580CFD17; Tue, 21 Nov 2023 16:42:47 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229513AbjKVAm1 (ORCPT + 99 others); Tue, 21 Nov 2023 19:42:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229464AbjKVAm0 (ORCPT ); Tue, 21 Nov 2023 19:42:26 -0500 Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DBBA112 for ; Tue, 21 Nov 2023 16:42:22 -0800 (PST) Received: by mail-oi1-x22b.google.com with SMTP id 5614622812f47-3b2ea7cca04so4037304b6e.2 for ; Tue, 21 Nov 2023 16:42:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1700613742; x=1701218542; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3JAG0RDoM6r+OhcBNCljqVXixFJN9onE/iS8GXZuAZc=; b=J8kBBzXNLvaLzzItbZ6aiB87DxoMjhSXat/Mmm9YQExy3E3RcYeTGt+nkBO6NxqWfA VPNPDZYFNVP9FUqYg03bsV1XkDv0HTyhGQVcx9vX6LF0ONJkf/VOdMnD1McMurjfkEFx Ku8fYwMMW6mqIeMr8EzT04k2zKMOVhLxCmbp5aE92Vm3nuLSUU5GO8XTCxrhXNk0WWSX En2EFu79XuCuv/xfDk2kMTIyOZ2G6EMt0vZYBSn88rUcpe4dvZ7V1Up/MMxIDe62l1ZV CejkP9hYykrU+xNVFjW57jGM+cL2vC7AXdZT54rRJHH+N2Wx1teMhM4r/BtLBFKhyXBH XR9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700613742; x=1701218542; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3JAG0RDoM6r+OhcBNCljqVXixFJN9onE/iS8GXZuAZc=; b=feI3WE0TPS++46MEgxS3dSgTmfxgc9/SzhzAs8uEb5oc2G0+foWRnMI1Knpn0EsFCF qTTj8KTazDyVyW4auuhuqQM3i7RWaUl9exMS89lYVm4ZiNcHkf+Vb8SpQSgtHFHmKW8g gCD4bKbLrfWT1jfr3Mp1yXCj/1KsLu/WVcRDEhW7O9RCxNkTub/pzEWbNMraSijZgJY5 Pnrst1Z8+B+phFCssxZs21MnSCpuH3ex03CBZPaKSM0F3l6lPFsXokVZdsBEeuN7mPvJ vKwwc1BbX5lfLEqFN1oYhEO9Cnjz0G0iu0c2czEScAjDxU6xVvND3VlUK8+P2lxl5FzE Elcw== X-Gm-Message-State: AOJu0Yxh7RnHW1hO8hVPFQ6BqxOke6y2mUfETRIVGRLXQBV5a35UqS9o UXXts+oKUt6mwISf3Ideq1cuDNdKaot51d78tX8yyQ== X-Received: by 2002:a05:6808:1693:b0:3b8:3ba9:b14b with SMTP id bb19-20020a056808169300b003b83ba9b14bmr1311964oib.43.1700613741892; Tue, 21 Nov 2023 16:42:21 -0800 (PST) Received: from sw06.internal.sifive.com ([4.53.31.132]) by smtp.gmail.com with ESMTPSA id z128-20020a636586000000b005b856fab5e9sm8382145pgb.18.2023.11.21.16.42.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 16:42:21 -0800 (PST) From: Samuel Holland To: Radhey Shyam Pandey Cc: Samuel Holland , Ariane Keller , Daniel Borkmann , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Michal Simek , Paolo Abeni , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH net] net: axienet: Fix check for partial TX checksum Date: Tue, 21 Nov 2023 16:42:17 -0800 Message-ID: <20231122004219.3504219-1-samuel.holland@sifive.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 21 Nov 2023 16:42:47 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783222784532532573 X-GMAIL-MSGID: 1783222784532532573 Due to a typo, the code checked the RX checksum feature in the TX path. Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver") Signed-off-by: Samuel Holland Reviewed-by: Andrew Lunn Reviewed-by: Radhey Shyam Pandey --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index 82d0d44b2b02..bf6e33990490 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -822,7 +822,7 @@ axienet_start_xmit(struct sk_buff *skb, struct net_device *ndev) if (lp->features & XAE_FEATURE_FULL_TX_CSUM) { /* Tx Full Checksum Offload Enabled */ cur_p->app0 |= 2; - } else if (lp->features & XAE_FEATURE_PARTIAL_RX_CSUM) { + } else if (lp->features & XAE_FEATURE_PARTIAL_TX_CSUM) { csum_start_off = skb_transport_offset(skb); csum_index_off = csum_start_off + skb->csum_offset; /* Tx Partial Checksum Offload Enabled */