Message ID | 20231122-rkisp-fixes-v2-2-78bfb63cdcf8@ideasonboard.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2b07:b0:403:3b70:6f57 with SMTP id io7csp1420484vqb; Wed, 22 Nov 2023 07:52:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IE+bKbOlV2o+QmPb05BOsTrwxTbNQBdssdXR5CA52Iz/TKxjr8UYWPaH4Cbf8wYKlLyUgWW X-Received: by 2002:a05:6a00:3992:b0:6c3:41fd:3a3e with SMTP id fi18-20020a056a00399200b006c341fd3a3emr2797774pfb.27.1700668362020; Wed, 22 Nov 2023 07:52:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700668362; cv=none; d=google.com; s=arc-20160816; b=tJzd+oBXgOT7K8XxBvRUa06aMmGSY4ujqkNx33b0E+C6z9tdwgbD8La9g27iKbLqmA V33bmezqh3HFwqx7MbnywCBTkAbny0Wsg3f5N4H1h4CvUnkkrBGLYXdVwzzPrOW0hRcd zAcwSjRU99UtYRN5ZjSEpVhiaHnXv+oOLizmBCHM6WnIzC/oZKDotvf83gfyQUL/IkIE ZAg3aZxXt1xYjS93T9ZhqowHzbpiS8x2h9vmksVILBv6MaCM3z+cim56mBlASSS230AS j3w2lttmx4gi5Qngd5dnIdx2mY218GCN5N7AyU8sCJOOcwwmMIgp3yNQAGZG+5VsJBIG Sqew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=UmsgZ4R6XqjmqCQftlhBfy4T1UOhevwpoOXfrsC3Yqk=; fh=C0dXkAvu/VipV4SxI6kL8WioTQwoH+s7n35QCI5Zld8=; b=YiGC6TfFKQsJWMsgMDJeIUGIWRDsHxLyVLN/9hjsE+eLlg9Tq1/XS1kNc/p7PZXIGR GAj1UUqLOZ0g+kQyVRoFUNoLHbHD1PyzwBQRtivZ9HtpEh3pl/hDd7pCPRD1VUuxT9cM jvG45rzWQZLEyQf3AS1VFop00RcOBN8VyuvrwybRcuDWgL8OxeNnGruJ2Ygu1j6rOr3j 3pD0lZqFj/Z26bIpDTyAeXXFQKnP0BqKYGSkSZsiJiJcEVq+/3dDKJLSOwxPlO36klyE I4lGziiS6ATgtBCM8EymIOO1hq4YeXe18bZ3c9LCUqVtNgmXQ48JeXIeGkclghisrk+T M2Uw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=hwzEUySD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id g17-20020a63fa51000000b005b902b61cbbsi12781719pgk.125.2023.11.22.07.52.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 07:52:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=hwzEUySD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id A3F8182AA64C; Wed, 22 Nov 2023 07:52:09 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344473AbjKVPvD (ORCPT <rfc822;ouuuleilei@gmail.com> + 99 others); Wed, 22 Nov 2023 10:51:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231737AbjKVPug (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 22 Nov 2023 10:50:36 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23310D42; Wed, 22 Nov 2023 07:50:33 -0800 (PST) Received: from [127.0.1.1] (91-158-149-209.elisa-laajakaista.fi [91.158.149.209]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C84F2641; Wed, 22 Nov 2023 16:49:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1700668199; bh=GWSvmigvhbqxxKwsO8s1wxYTODF1EHzXekCVLlbZGxI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=hwzEUySDhdg7+rV4lAQv1SLbaMq4f5LP3XGp0v8sHnCVXjnUyl0SO7+KttWy3qd2V ONCgstHK1hey+zQcUHwkd7jQB80umbQ68bN4Z1oIfOBPCFBF3Fb1GgBwHFHmMTjTby 0u85d2oWQM5WqA6W6rSwkwJa2jMvx9VPIjAT6N+I= From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Date: Wed, 22 Nov 2023 17:50:08 +0200 Subject: [PATCH v2 2/2] media: rkisp1: Fix memory leaks in rkisp1_isp_unregister() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20231122-rkisp-fixes-v2-2-78bfb63cdcf8@ideasonboard.com> References: <20231122-rkisp-fixes-v2-0-78bfb63cdcf8@ideasonboard.com> In-Reply-To: <20231122-rkisp-fixes-v2-0-78bfb63cdcf8@ideasonboard.com> To: Dafna Hirschfeld <dafna@fastmail.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Heiko Stuebner <heiko@sntech.de>, Jacob Chen <jacob2.chen@rock-chips.com>, Yichong Zhong <zyc@rock-chips.com>, Shunqian Zheng <zhengsq@rock-chips.com>, Paul Elder <paul.elder@ideasonboard.com>, Sakari Ailus <sakari.ailus@linux.intel.com> Cc: Kieran Bingham <kieran.bingham@ideasonboard.com>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Eddie Cai <eddie.cai.linux@gmail.com>, Allon Huang <allon.huang@rock-chips.com>, Jeffy Chen <jeffy.chen@rock-chips.com>, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>, Tommaso Merciai <tomm.merciai@gmail.com> X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=940; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=GWSvmigvhbqxxKwsO8s1wxYTODF1EHzXekCVLlbZGxI=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBlXiNCOLg/ZNZkH5JNt4+lP3cqdiX2JgWJ0yFPo ckl7sgXzkyJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCZV4jQgAKCRD6PaqMvJYe 9fWRD/9StEmHs8CUsFrm3u/UhmQD6eVyKBwAImdgigY4oTPn41xWao/S59SXpr3e88F9bXGxcMZ 6rnSXhmN7BDKXLKnWttYjjKhkYpLSaxegHh55Z4xtfr3u0wXzdWcC3NEH6HS94P48DjKHuHzzBU Gr04pONVTSW+ns9cdVhJynYL2qzL4V2BFb7hQYKS1rAazEYhCVoUaC1EfEs0xm6wt5nk2HQGlP0 tIpbqw+/2Jld19VUWran31Omv5uB+Z0RjRLRodX4vu0505piKnTt78v4Kly6xUU73WgIlh7YCp+ 9rknI0dcamE4ZCdv+dlCjENspgLNgfP1/09L2urGYQTcd6ggOttdO2Qg0KBfzcDTbrBVp64qQMn qFF6wovam1VktcLAFtH9crxOKWo+ZP8OU53xXj9IqpVQDO0mKZ5kYhKBzjU6t6tzXu2Z2d5uWgk TuSwTAfKKFRgjBn23rCbc3xzX53yKDURqxeNH6ZbTmA54ulm0vAlKwKb8uXgk1axttXuXaNMkoe Qp0vaz6pijRptgcMSEjMpeKY0xgjMsz8cCWG377otml93uq9BKemmP0IAZMNLb5d4KBs40Vz725 y81xyOlm4aUtZfRvZvRNkx8Y22HHL2YhtupQjAel9hxFF1W3kcuGso4wuqky0GaAz9Qqf0zHZEj 5JAOoWZlF2PmAFw== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 22 Nov 2023 07:52:09 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783280028298151549 X-GMAIL-MSGID: 1783280028298151549 |
Series |
media: rkisp1: Fix memory leaks
|
|
Commit Message
Tomi Valkeinen
Nov. 22, 2023, 3:50 p.m. UTC
Add missing call to v4l2_subdev_cleanup() to fix memory leak. Fixes: 2cce0a369dbd ("media: rkisp1: isp: Use V4L2 subdev active state") Reviewed-by: Tommaso Merciai <tomm.merciai@gmail.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> --- drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c index 88ca8b2283b7..45d1ab96fc6e 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c @@ -933,6 +933,7 @@ void rkisp1_isp_unregister(struct rkisp1_device *rkisp1) return; v4l2_device_unregister_subdev(&isp->sd); + v4l2_subdev_cleanup(&isp->sd); media_entity_cleanup(&isp->sd.entity); }