From patchwork Tue Nov 21 22:01:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Leoshkevich X-Patchwork-Id: 167985 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2b07:b0:403:3b70:6f57 with SMTP id io7csp942594vqb; Tue, 21 Nov 2023 14:05:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IHyOMivcBtxyJr74NsEL0zfxOENNp4qysa3R85trGsQn0Qf9MHuIDFGP0SQHSETDPkM7dkc X-Received: by 2002:a17:902:f542:b0:1cf:662b:4523 with SMTP id h2-20020a170902f54200b001cf662b4523mr823440plf.34.1700604350594; Tue, 21 Nov 2023 14:05:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700604350; cv=none; d=google.com; s=arc-20160816; b=EnlK0xek3eqPxID/kFsOPV7kbhxdYGG5kUww3F/D0K1GIW5akvTPY1orekAQ+U4Jcs jlWA5W+STHTnHb/pdWoaPCQctjyhFJg69vnAFDnO9gWLSkGwpZfaqzi+HnlvSTyCHYAr CFYbCX5dqY+lq4TXzJBC+o+4m1X3qEpTRCWxjNGpttAdg9jssk54PFqV/tU1iwq4w2WB alPEjbQRUFKNM47rta77lT4pD59ilMp+1Om4lMQ4a68ArrfatNSYgoRxNApgQJ82n1rj WY2jCc5OvTMtGrBDrWfYjzvPQPcEenhZQqD0ISmJvFdBFmha9KYMZRhOKC1aslDMVB9Q v+TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=kTguPNTtkujOx5aTw0/7lEtG7eBE+cQa3Gtf60+X5Og=; fh=TQATEbdDZNcnk8L2eDP6eFL9HlexFaHIexhR1TH2IlY=; b=cFs+Ehib0rOdd8UKbocBLjebHNL8A5EHoPEEQg+mGjPCE1zdPJa8KLhCA1H8PEZphi n0u23ztVnMpqYgxd+3OS90GcQPr66sDv75ilTjq7Oj2Y4+IyNJDMpJneUOg6JrjYOJWW uKERGLFN/cPRBcFfW875HqJAQgbOuQSvKvrWNkKNXPKLkeWcBiONlMeH/Ex+71Mg6EMO G7ijOPTkz7O77aMQi/uQ3SC1bUn4HFuwYgMyY942/HzkY9rCcLZAtEo883IdZ5JhbLUl nLNOsnoJHF/1JdBrvU0tKVIfcsdaBoLyxZzZF0u2oWdYbIFSa1dwngBf8cGBDidTCmXY dcjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=RYRunEdV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id b2-20020a170902ed0200b001cc692bf120si10793415pld.61.2023.11.21.14.05.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 14:05:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=RYRunEdV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id A77E38027F2D; Tue, 21 Nov 2023 14:03:00 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229672AbjKUWCn (ORCPT + 99 others); Tue, 21 Nov 2023 17:02:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229513AbjKUWCm (ORCPT ); Tue, 21 Nov 2023 17:02:42 -0500 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F099419E; Tue, 21 Nov 2023 14:02:38 -0800 (PST) Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3ALLgeV8032042; Tue, 21 Nov 2023 22:02:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=kTguPNTtkujOx5aTw0/7lEtG7eBE+cQa3Gtf60+X5Og=; b=RYRunEdVlGJ8LkcClRIzeGMY+SRQp9VBzfJiRjTGw2TWKeaxNi98GdwKxZKlApd/vTEa 5fjYrnjzr0QtjOhaVDZbYPwao2fQR0EGhd9r3YG7H9mM7BLAkODp28yimlDK7TS5fRm0 DxVCfxpLh9HWu2b+PEpfzKOqwnccK8suT/mT94/thceRjJaaX9S8qZAzVnvhRx6d5ilU GueFEMdIdyhbTJrF/KddFXXpcF+9uxLd00jnef2EoRQ9ty+7irqLiNxe8Bi31OL9wUH3 HMlQszrqZwRiaKlSh/dxcT6ZwuzV2bGj3TFqPqH7rHGcBlc+FyVnO4CplQegEqOgrhOR Dw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uh4pw8eyu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 22:02:21 +0000 Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3ALLghtL032152; Tue, 21 Nov 2023 22:02:20 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uh4pw8eyd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 22:02:20 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3ALLnXxd011060; Tue, 21 Nov 2023 22:02:19 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3uf9tkbbg2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 22:02:19 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3ALM2GDj44171902 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Nov 2023 22:02:16 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7F0122005A; Tue, 21 Nov 2023 22:02:16 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 07BE220063; Tue, 21 Nov 2023 22:02:15 +0000 (GMT) Received: from heavy.boeblingen.de.ibm.com (unknown [9.179.23.98]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 21 Nov 2023 22:02:14 +0000 (GMT) From: Ilya Leoshkevich To: Alexander Gordeev , Alexander Potapenko , Andrew Morton , Christoph Lameter , David Rientjes , Heiko Carstens , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka Cc: Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle , Ilya Leoshkevich Subject: [PATCH v2 07/33] kmsan: Remove a useless assignment from kmsan_vmap_pages_range_noflush() Date: Tue, 21 Nov 2023 23:01:01 +0100 Message-ID: <20231121220155.1217090-8-iii@linux.ibm.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231121220155.1217090-1-iii@linux.ibm.com> References: <20231121220155.1217090-1-iii@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: B7RtM10wgoiXDWtQSzCUsN3XoYr-pcVr X-Proofpoint-ORIG-GUID: YLsibPNprUpSVnBcQtTLu3E3EBSDOV_z X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-21_12,2023-11-21_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 impostorscore=0 mlxlogscore=999 phishscore=0 mlxscore=0 adultscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311210172 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 21 Nov 2023 14:03:00 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783212907909538122 X-GMAIL-MSGID: 1783212907909538122 The value assigned to prot is immediately overwritten on the next line with PAGE_KERNEL. The right hand side of the assignment has no side-effects. Fixes: b073d7f8aee4 ("mm: kmsan: maintain KMSAN metadata for page operations") Suggested-by: Alexander Gordeev Reviewed-by: Alexander Potapenko Signed-off-by: Ilya Leoshkevich --- mm/kmsan/shadow.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/kmsan/shadow.c b/mm/kmsan/shadow.c index b9d05aff313e..2d57408c78ae 100644 --- a/mm/kmsan/shadow.c +++ b/mm/kmsan/shadow.c @@ -243,7 +243,6 @@ int kmsan_vmap_pages_range_noflush(unsigned long start, unsigned long end, s_pages[i] = shadow_page_for(pages[i]); o_pages[i] = origin_page_for(pages[i]); } - prot = __pgprot(pgprot_val(prot) | _PAGE_NX); prot = PAGE_KERNEL; origin_start = vmalloc_meta((void *)start, KMSAN_META_ORIGIN);