From patchwork Tue Nov 21 22:01:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Leoshkevich X-Patchwork-Id: 167994 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2b07:b0:403:3b70:6f57 with SMTP id io7csp944013vqb; Tue, 21 Nov 2023 14:08:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IFBEDdffL9kDaMyfpz/z5LF2zJqdedQseybkFD8WGtusCb2rnnfBKFlvLhIxU4IVHbRpP0I X-Received: by 2002:a05:6a21:33a2:b0:188:973c:ef7a with SMTP id yy34-20020a056a2133a200b00188973cef7amr499322pzb.34.1700604519361; Tue, 21 Nov 2023 14:08:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700604519; cv=none; d=google.com; s=arc-20160816; b=LEQFiZ9Ap+DMGoV+1mAYL+pqBAIuMorxYigzzj5k4isaBFzy/3iNFpdM22IjwOEx5W VLfBT5IpSVshC9JJA2PSn9eUXTivnfn9OInYwBiH2HXwNQXEGnr3AN1/0rOHDs9CzWQy zMZbzYbl8LQSlo0UCeBIa5Yo65LtRhK/J94hvAilR9wuf6MkTi80Z/jQygxKBMtqzAdf ja37BSrj42OuhRsKMjrOJIrQd02MQxy5Zcoq+mjW8Qhdo0XT2BrNLdtqWIMAhyumBY4E ajAEfOWouInEId1Dif/k0tKOhoJC9xtabpAVzEavMBVtH8t23FuwOYnf0R+D29B2DBXL l3Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=5NSwnOlXGjBF5jkByPXzrZliIsEVpLRGGgaxRVBZlxc=; fh=TQATEbdDZNcnk8L2eDP6eFL9HlexFaHIexhR1TH2IlY=; b=aujGw0czAB0u3dHn/AkEdTYfHQ7Cmn2pZAfCKcFmUdgEEMjVrYWntfZwe+oD2+2xB7 FXaEc+yVin+e8NIvs0X/683E15TP4dbjcqZM0Ajl01ejpnnUAx2Kr2/prJJ/s7uDFUSg CiMo2dU9FJD+0ccYY8EwZs7R4flX3CBoqGrc4nYwLrjU0mlNr4g39FetGUW6udDm6jkt cU64P3HO2GBka/61Abf54vg94Eut7bjrEJIDYsVwW6xr6CLvOR4oUptNNy193epj0zuu YHGL8gmxzw+HFxMjVCCiXbrFEYoYtZBIDDYmzrfwbyo6wmLQesg/81MTCXxSCKA4I/W2 jOsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=AT+iRf0E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id k1-20020aa788c1000000b006cb84e342dcsi6353878pff.129.2023.11.21.14.08.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 14:08:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=AT+iRf0E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id EBE72802A368; Tue, 21 Nov 2023 14:08:33 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234861AbjKUWIe (ORCPT + 99 others); Tue, 21 Nov 2023 17:08:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234733AbjKUWIN (ORCPT ); Tue, 21 Nov 2023 17:08:13 -0500 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F3DC10E9; Tue, 21 Nov 2023 14:06:48 -0800 (PST) Received: from pps.filterd (m0353722.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3ALLqfCQ007953; Tue, 21 Nov 2023 22:06:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=5NSwnOlXGjBF5jkByPXzrZliIsEVpLRGGgaxRVBZlxc=; b=AT+iRf0EMqqVZTLtEn3XIJ28iYWqEg5ihT1n/OgLrGuLrXV5pV87MhkXjgrgNntPr6Mv jVvX5VAF1G2ayOjrVkfsPcC3OdQo01XBbJXV1VhFaVSTrGW69g+qPsEAAbeOpDjpRlAW gBWPydsVWO0kPL862Q3LA7rsYR27X3nMF9qxD2EwPhZJPytQ+ii3irfOxra5s9pvN9LI Iw1JaWoFz0TznBH7Bx2BewdtbuUj2RGaDsmXcnVpt6u/EPyopcrf7Yw8B1FYGHZcctzQ slxwXGR0dSvGpFhqD6rFvGWfmF12tHnDk29B1M4Owrp2AAndYUN31XNnrlDV8euQtae/ pg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uh4um08k1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 22:06:32 +0000 Received: from m0353722.ppops.net (m0353722.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3ALM6V5t010663; Tue, 21 Nov 2023 22:06:31 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uh4um0808-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 22:06:31 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3ALLnXxc011060; Tue, 21 Nov 2023 22:02:17 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3uf9tkbbfx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 22:02:17 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3ALM2Egm45089276 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Nov 2023 22:02:14 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7B1DB20065; Tue, 21 Nov 2023 22:02:14 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 04FCD20063; Tue, 21 Nov 2023 22:02:13 +0000 (GMT) Received: from heavy.boeblingen.de.ibm.com (unknown [9.179.23.98]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 21 Nov 2023 22:02:12 +0000 (GMT) From: Ilya Leoshkevich To: Alexander Gordeev , Alexander Potapenko , Andrew Morton , Christoph Lameter , David Rientjes , Heiko Carstens , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka Cc: Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle , Ilya Leoshkevich Subject: [PATCH v2 06/33] kmsan: Fix kmsan_copy_to_user() on arches with overlapping address spaces Date: Tue, 21 Nov 2023 23:01:00 +0100 Message-ID: <20231121220155.1217090-7-iii@linux.ibm.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231121220155.1217090-1-iii@linux.ibm.com> References: <20231121220155.1217090-1-iii@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: SoU0RJ6tBdwvO_1Y7haVWEfjyPSE7XyE X-Proofpoint-ORIG-GUID: fzYvMn95qhzPNBXYSvhJrEwMaHFITUBv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-21_12,2023-11-21_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 mlxlogscore=767 phishscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 adultscore=0 bulkscore=0 suspectscore=0 spamscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311210172 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 21 Nov 2023 14:08:34 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783213084515811866 X-GMAIL-MSGID: 1783213084515811866 Comparing pointers with TASK_SIZE does not make sense when kernel and userspace overlap. Assume that we are handling user memory access in this case. Reported-by: Alexander Gordeev Reviewed-by: Alexander Potapenko Signed-off-by: Ilya Leoshkevich --- mm/kmsan/hooks.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/kmsan/hooks.c b/mm/kmsan/hooks.c index 5d6e2dee5692..eafc45f937eb 100644 --- a/mm/kmsan/hooks.c +++ b/mm/kmsan/hooks.c @@ -267,7 +267,8 @@ void kmsan_copy_to_user(void __user *to, const void *from, size_t to_copy, return; ua_flags = user_access_save(); - if ((u64)to < TASK_SIZE) { + if (!IS_ENABLED(CONFIG_ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE) || + (u64)to < TASK_SIZE) { /* This is a user memory access, check it. */ kmsan_internal_check_memory((void *)from, to_copy - left, to, REASON_COPY_TO_USER);