From patchwork Tue Nov 21 18:36:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 167901 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2b07:b0:403:3b70:6f57 with SMTP id io7csp836302vqb; Tue, 21 Nov 2023 10:37:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IH+5P9lhdmSGIFWeGkLXO5ZIueJCCxB4f2Ythsk+bWHUEoSMLgM/z+fvM6SPtgEpuFYCF97 X-Received: by 2002:a05:6a00:f98:b0:6c3:450f:2b64 with SMTP id ct24-20020a056a000f9800b006c3450f2b64mr6189749pfb.6.1700591858362; Tue, 21 Nov 2023 10:37:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700591858; cv=none; d=google.com; s=arc-20160816; b=T2hzVZShdvPUTXAJWVFgK1Uoc5Z/bN196dao6r4owpRBOiN5EJ0ZghUjDCyRt2K0Rb bd+Cy8SwQh2RxXghv465pj4Q1C24qJzzc+En8G0CdOYbKlCN7xZQds72BpGkYCIn/VgH VMQhxjqae17w5qsr17GACb8KCIj6/boICs+yVMQOII6UBPplW0PXYRxc7jcXqmJAC29o Dd2RW8PW5bLhh8ZwlBKoCrj9Fxa0r0Xd4yWq0uY7vVPnGDtwc2KtTrH/CPhZBQx91Fhc 8tLH4t0PLLLoL3mXl/rZsRfwh7DT4LjlYJHLDWC6eafZwn2YiEAiCcWhvEYOHkqpWlJf ho4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=mO/vAmX+Lkqh2xsmrvIngWUJeVivbig4wD1kpXAvcj0=; fh=KVY+YYgWJTdaCaCkMOn84+9OqSlvR5lnFCfeohFAf40=; b=IzqK5NxBKb85TICt3Wa5wzRa8mjZlYLLl5jy4NP7BVsw8Dss4yIsQEIZieqAU1d24w 31wdEtDHXwOUDsgMhTO01Gz0cJNSSMuv/v72YjWsYyjPOgQEdOiGtFE9OboHwbjZkWSN gaFCvGZTdKYcqruJS+8ObRKrgzIKa6oXgXHf2yUX3eInvJopbN4z4wU49lgVLRkrjgel P7msEm0lOxt2iNgyWWkhKRT4qO7sCzFvHFnpY4a1DVe+tmkUryFP5xwQcg5qxXM66g+B /cf0JKV6ovEs01AGgI9u7+7SvJthPh/ReCKcn3lZ2BRjN5ML8Pt3iM6VHs2oW0JqIlCg VuzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Uwt2R144; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id a22-20020a056a000c9600b006c4d5b0fdc2si10746044pfv.392.2023.11.21.10.37.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 10:37:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Uwt2R144; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 2CB3580C3A20; Tue, 21 Nov 2023 10:37:23 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234524AbjKUShO (ORCPT + 99 others); Tue, 21 Nov 2023 13:37:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234513AbjKUShJ (ORCPT ); Tue, 21 Nov 2023 13:37:09 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2EC118C for ; Tue, 21 Nov 2023 10:36:59 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4AA9CC433CB; Tue, 21 Nov 2023 18:36:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700591819; bh=ks9s3ODzJPgxlrZ34fpMdEf9kOaOEvMAaQEGGAEQrtY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Uwt2R144vun2y7PN5CRe6Kc/nrvVoO5JerX2sRIJ/2APNdfidyj1Y3Hx87T/VAoNN wgLL46K7seOlNSRQ5p0o7QcFDTg+14KqqeW9SsKKH+nzv6CPZutqVrsBzSr62pFQi+ CCqFNky92FqTQr7ZpTxNOS0tQsAu+vBjv0aJiENTIxpxsKKY7hKET+TdS1fuwXzoXO 9CcUzr+G6X5Qvo1Om4pOhB3ZirUSTardxrB+atcxCZZdcFB6vL+Xn3Z6uB6of2H5uw NgE82W22Io4RT4kyCC0aXAihXfa3eYQBvWeqWIGrMu365JMVE+cK0ghJFAKWxbA498 8YfO6tobt2+VQ== From: Bjorn Helgaas To: linux-pci@vger.kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , "Rafael J . Wysocki" , Dan Williams , Kan Liang , Tony Luck , Giovanni Cabiddu , Yunying Sun , Tomasz Pala , Sebastian Manciulea , linux-kernel@vger.kernel.org, Bjorn Helgaas Subject: [PATCH 5/9] x86/pci: Rename acpi_mcfg_check_entry() to acpi_mcfg_valid_entry() Date: Tue, 21 Nov 2023 12:36:39 -0600 Message-Id: <20231121183643.249006-6-helgaas@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231121183643.249006-1-helgaas@kernel.org> References: <20231121183643.249006-1-helgaas@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 21 Nov 2023 10:37:23 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783199808813232216 X-GMAIL-MSGID: 1783199808813232216 From: Bjorn Helgaas "acpi_mcfg_check_entry()" doesn't give a hint about what the return value means. Rename it to "acpi_mcfg_valid_entry()", convert the return value to bool, and update the return values and callers to match so testing "if (acpi_mcfg_valid_entry())" makes sense. Signed-off-by: Bjorn Helgaas --- arch/x86/pci/mmconfig-shared.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/x86/pci/mmconfig-shared.c b/arch/x86/pci/mmconfig-shared.c index 896cc11013bd..91fd7921d221 100644 --- a/arch/x86/pci/mmconfig-shared.c +++ b/arch/x86/pci/mmconfig-shared.c @@ -576,22 +576,22 @@ static void __init pci_mmcfg_reject_broken(int early) } } -static int __init acpi_mcfg_check_entry(struct acpi_table_mcfg *mcfg, - struct acpi_mcfg_allocation *cfg) +static bool __init acpi_mcfg_valid_entry(struct acpi_table_mcfg *mcfg, + struct acpi_mcfg_allocation *cfg) { if (cfg->address < 0xFFFFFFFF) - return 0; + return true; if (!strncmp(mcfg->header.oem_id, "SGI", 3)) - return 0; + return true; if ((mcfg->header.revision >= 1) && (dmi_get_bios_year() >= 2010)) - return 0; + return true; pr_err("ECAM at %#llx for %04x [bus %02x-%02x] is above 4GB, ignored\n", cfg->address, cfg->pci_segment, cfg->start_bus_number, cfg->end_bus_number); - return -EINVAL; + return false; } static int __init pci_parse_mcfg(struct acpi_table_header *header) @@ -622,7 +622,7 @@ static int __init pci_parse_mcfg(struct acpi_table_header *header) cfg_table = (struct acpi_mcfg_allocation *) &mcfg[1]; for (i = 0; i < entries; i++) { cfg = &cfg_table[i]; - if (acpi_mcfg_check_entry(mcfg, cfg)) { + if (!acpi_mcfg_valid_entry(mcfg, cfg)) { free_all_mmcfg(); return -ENODEV; }