Message ID | 20231121094642.2973795-2-qiujingbao.dlmu@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2b07:b0:403:3b70:6f57 with SMTP id io7csp506893vqb; Tue, 21 Nov 2023 01:47:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IFWJh1241A+xoOAFsOnIZ8l4fv2E2CXoO9VxWIQ1a9DtSaUO7CRqL2uH50/KUPy7c3c5x9n X-Received: by 2002:a05:6a00:228a:b0:6cb:6857:4022 with SMTP id f10-20020a056a00228a00b006cb68574022mr7061667pfe.18.1700560052760; Tue, 21 Nov 2023 01:47:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700560052; cv=none; d=google.com; s=arc-20160816; b=ANUrhySGbK3U/rUzmVNb3QNEeAS+qYYACEzVKPaOR9c+jVmBZRx5MipFPhWEyJJIRp E0zmqvEYOqCLfno0py+/J5kHskQFo9ohiIsVPV/l+L77I2GTsXpts+zUC7Tj+Tbh5HVo 7NaUx6l9GyUdY9ODdXt/B6/tZmco4abj3IAchI0+TDWjteNj0Fx39vaMdSsAjHhCJiGM igYMX01i6i+hwWCQSl6vxFA9TMkqXQ4YiaMhb2TMlaJJBHxynur3PNkdrHAmbWJ7mnMe eSsjXdspNb8J12fE8wJKGXYEQi21JkbILzu+fVqyk/d5Az+IhSDG2AoMpDA1gGg6sBr8 fi/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=bKpFYyIFYNZLBFwQ3MuXuBXHHUJPuLK3Le9Fx+iNuq8=; fh=jPIQ3QCzMHY3w84iSpjxErRSsd+KHfYvqfWsgpjZi94=; b=Fh+k3wi7+xhJ+pxQFjL9Eyh5nNgw44wE44I13ft1Bs2Trz9FyaxtN2lutP8IZW7aqu LyytVBrYFqYBKr9sIIgVjfen24W+rgpHIAj65wa7SOBwr8U6VqxFhB4KSEFUo3xoxTD1 lDGx74m207wqP1bNqBglLWJYs68HHDmkwsx76R8+gXH9LV6SHL3efwQsQzq3N6srKo+T IacgpTzlS11S7hU2ORPdgs+sn9hyxOlg6CqwSic0/S0j42gbF2CvlhXZRuctvSjMjHCJ nBuPemZw1MbcXRyBojNvZ27+fX1iHzDMpvNClJKQbLea4rYg4kG7VkNCSSgKasalnzWU dMSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=BNr43lEl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id f14-20020a056a00238e00b006c339527ab8si10137467pfc.192.2023.11.21.01.47.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 01:47:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=BNr43lEl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 01D8280C3A99; Tue, 21 Nov 2023 01:47:29 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233990AbjKUJq5 (ORCPT <rfc822;ouuuleilei@gmail.com> + 99 others); Tue, 21 Nov 2023 04:46:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232257AbjKUJqz (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 21 Nov 2023 04:46:55 -0500 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C59B9C1; Tue, 21 Nov 2023 01:46:51 -0800 (PST) Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1cc9b626a96so39250555ad.2; Tue, 21 Nov 2023 01:46:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700560011; x=1701164811; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bKpFYyIFYNZLBFwQ3MuXuBXHHUJPuLK3Le9Fx+iNuq8=; b=BNr43lEla8YgWfDzQX4WFPkvhie4+0mZzIP16HsqenGv6dyX+4eXvyfYdaCOyefyPi PIvQUvGs5DIGy0VDLb5jDbWpZUXNlJqddwwGkSAtGb2cn/L2PQfxo+E19We9ae7NyMNC NaYb/Hff5KjkaoMDIrT0Zz588wwZSFp6MHUdIn/15y0jMcnE8T0UNi63HY0a2IM7xE8s PSpGabvhWPukjL56bYiOTA756hUCY+T3qk6nRduHVCVE10fnfZZ3eVULL4RPgD2P2TYH xQL01OPKhxvpLn1Yxao7ypECNokJA5pFAH3DQPAdsP/QKoIxaG0c08lgyWmzle9yG3qC lwqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700560011; x=1701164811; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bKpFYyIFYNZLBFwQ3MuXuBXHHUJPuLK3Le9Fx+iNuq8=; b=JZzQFETaGPr/hivIKI6jtL+NCxux08hCxESzDFx6SXJPhEAaO+OpU9wT4brEZLBaf6 YMw/8aOzx6fb+5gkosB/tfnRpvUezKcjaK/M6vgw0sn6U04Q1fzL5ggldU/ROBknOnBb 699iHTw4X0itH40zHosjafBXl1zwuLrRJlQsnJ1rtV1DG2/c3vepudJyCigwx/dQaUuB Tj0zNea3RUrl76UBoA497Hz2dZu/+dX07sufPCQsZV3ALkTMfyQiQBNpG2zuv1feB8M8 jfh3rdiYpkSeWm+IUqf0d2kZAGO5LRGSDwCVQ4ZdDWSwJ/Y4rZLmr+PnOM7NOyp2x+8C cdrQ== X-Gm-Message-State: AOJu0YwoAZ5wMJmGCE9pJi463x/9GzvuhaHJWTcnT3C/rqfF2aLsXR6q 19KNY/2X5bExG/o1iWgpX6Q= X-Received: by 2002:a17:903:24f:b0:1cc:31c4:377b with SMTP id j15-20020a170903024f00b001cc31c4377bmr8998823plh.63.1700560010652; Tue, 21 Nov 2023 01:46:50 -0800 (PST) Received: from localhost ([2404:7ac0:49a7:269c:672a:72f:ab4f:aaab]) by smtp.gmail.com with ESMTPSA id q22-20020a170902bd9600b001c736746d33sm7445768pls.217.2023.11.21.01.46.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 01:46:50 -0800 (PST) From: Jingbao Qiu <qiujingbao.dlmu@gmail.com> To: a.zummo@towertech.it, alexandre.belloni@bootlin.com, krzysztof.kozlowski+dt@linaro.org, chao.wei@sophgo.com, unicorn_wang@outlook.com, conor+dt@kernel.org, robh+dt@kernel.org, conor@kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jingbao Qiu <qiujingbao.dlmu@gmail.com> Subject: [PATCH 1/3] dt-bindings: rtc: add binding for Sophgo CV1800B rtc controller Date: Tue, 21 Nov 2023 17:46:40 +0800 Message-Id: <20231121094642.2973795-2-qiujingbao.dlmu@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231121094642.2973795-1-qiujingbao.dlmu@gmail.com> References: <20231121094642.2973795-1-qiujingbao.dlmu@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 21 Nov 2023 01:47:30 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783166458051016736 X-GMAIL-MSGID: 1783166458051016736 |
Series |
riscv: sophgo: add rtc support for CV1800B
|
|
Commit Message
Jingbao Qiu
Nov. 21, 2023, 9:46 a.m. UTC
Add devicetree binding for Sophgo CV1800B SoC rtc controller.
Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@gmail.com>
---
.../bindings/rtc/sophgo,cv1800b-rtc.yaml | 37 +++++++++++++++++++
1 file changed, 37 insertions(+)
create mode 100644 Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml
Comments
On 21/11/2023 10:46, Jingbao Qiu wrote: > Add devicetree binding for Sophgo CV1800B SoC rtc controller. A nit, subject: drop second/last, redundant "binding for". The "dt-bindings" prefix is already stating that these are bindings. > > Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@gmail.com> > --- > .../bindings/rtc/sophgo,cv1800b-rtc.yaml | 37 +++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml > > diff --git a/Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml b/Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml > new file mode 100644 > index 000000000000..fefb1e70c45c > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml > @@ -0,0 +1,37 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/sophgo,cv1800b-rtc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sophgo CV1800B SoC RTC Controller What is a RTC Controller? You have multiple RTCs there? > + > +maintainers: > + - Jingbao Qiu <qiujingbao.dlmu@gmail.com> > + Missing ref to rtc.yaml. Unless it is not applicable but then why? > +properties: > + compatible: > + enum: > + - sophgo,cv1800b-rtc Blank line > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false unevaluatedProperties instead > + > +examples: > + - | > + rtc-controller@05026000{ The names is always "rtc", unless this is not RTC. If it isn't, please add full description of the hardware. > + compatible = "sophgo,cv800b-rtc"; > + reg = <0x05026000 0x1000>; > + interrupts = <17 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-parent = <&plic0>; > + clocks = <&osc>; Why do you send untested bindings? Review costs significant amount of effort. Code was also not compiled? Warnings not fixed? Best regards, Krzysztof
On Tue, 21 Nov 2023 17:46:40 +0800, Jingbao Qiu wrote: > Add devicetree binding for Sophgo CV1800B SoC rtc controller. > > Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@gmail.com> > --- > .../bindings/rtc/sophgo,cv1800b-rtc.yaml | 37 +++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Error: Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.example.dts:27.28-29 syntax error FATAL ERROR: Unable to parse input tree make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1424: dt_binding_check] Error 2 make: *** [Makefile:234: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231121094642.2973795-2-qiujingbao.dlmu@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Tue, Nov 21, 2023 at 5:57 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 21/11/2023 10:46, Jingbao Qiu wrote: > > Add devicetree binding for Sophgo CV1800B SoC rtc controller. > > A nit, subject: drop second/last, redundant "binding for". The > "dt-bindings" prefix is already stating that these are bindings. will fix. > > > > > Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@gmail.com> > > --- > > .../bindings/rtc/sophgo,cv1800b-rtc.yaml | 37 +++++++++++++++++++ > > 1 file changed, 37 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml > > > > diff --git a/Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml b/Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml > > new file mode 100644 > > index 000000000000..fefb1e70c45c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml > > @@ -0,0 +1,37 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/rtc/sophgo,cv1800b-rtc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Sophgo CV1800B SoC RTC Controller > > What is a RTC Controller? You have multiple RTCs there? > will drop "Controller", as I think RTC is not something like I2C, eMMC, USB, which have the "controller <-> client/device" model. > > + > > +maintainers: > > + - Jingbao Qiu <qiujingbao.dlmu@gmail.com> > > + > > Missing ref to rtc.yaml. Unless it is not applicable but then why? ok, I should ref this file. > > > +properties: > > + compatible: > > + enum: > > + - sophgo,cv1800b-rtc > > Blank line ok > > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + > > +additionalProperties: false > > unevaluatedProperties instead will fix . > > > + > > +examples: > > + - | > > + rtc-controller@05026000{ > > The names is always "rtc", unless this is not RTC. If it isn't, please > add full description of the hardware. I will use "rtc" replace "rtc-controller" . > > > + compatible = "sophgo,cv800b-rtc"; > > + reg = <0x05026000 0x1000>; > > + interrupts = <17 IRQ_TYPE_LEVEL_HIGH>; > > + interrupt-parent = <&plic0>; > > + clocks = <&osc>; > > Why do you send untested bindings? Review costs significant amount of > effort. Code was also not compiled? Warnings not fixed? I will check it. Leading 0 and referencing issues will be fixed. > > Best regards, > Krzysztof > I'm sorry for taking so long to reply. I took a few days off due to being infected with the flu. Thank you again for your patient reply. Best regards, Jingbao Qiu
diff --git a/Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml b/Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml new file mode 100644 index 000000000000..fefb1e70c45c --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml @@ -0,0 +1,37 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/rtc/sophgo,cv1800b-rtc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sophgo CV1800B SoC RTC Controller + +maintainers: + - Jingbao Qiu <qiujingbao.dlmu@gmail.com> + +properties: + compatible: + enum: + - sophgo,cv1800b-rtc + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + +additionalProperties: false + +examples: + - | + rtc-controller@05026000{ + compatible = "sophgo,cv800b-rtc"; + reg = <0x05026000 0x1000>; + interrupts = <17 IRQ_TYPE_LEVEL_HIGH>; + interrupt-parent = <&plic0>; + clocks = <&osc>; + };