From patchwork Tue Nov 21 07:06:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saeed Mahameed X-Patchwork-Id: 167516 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2b07:b0:403:3b70:6f57 with SMTP id io7csp444761vqb; Mon, 20 Nov 2023 23:09:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IEjBNhp1QXE/FzW1M9N7jY2PGVrubdw4eyRi2gBqpzT1otsg0y5zz8tM6/Hn/GPG90+1QRd X-Received: by 2002:a05:6808:1242:b0:3ae:e79d:79a0 with SMTP id o2-20020a056808124200b003aee79d79a0mr9979677oiv.30.1700550546378; Mon, 20 Nov 2023 23:09:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700550546; cv=none; d=google.com; s=arc-20160816; b=fWKw6jNVE8+AXG5Ac0kk8Q4AG7msStk75XwdQwEGcR57F5rrhwC8Ou6SzHXPvZogND brsShjYB0E3pQXsRv4XnXX4A4oj9yyYiGWL0F6VX+Iw0O8Rbwu7NjTa6tppGkPFQOOHD DgqsC94vQJ2Rda9SettNWZgdSkK2oOXP609cYjVI5RNwESzkWVqDu/OVlrGujSaj5mhi cAGyFaGpxKXCmZ2otda1BWUhm61Flwd4MK4Gr4jERqkdLwJfCeTZzGP9svzA1wqUg8sW xRLMmliRp1V/0OpTMJvlSVY64mOCmUS3huMB8F2kkeKH5WTlDw+Te87QW9iw3AxQH/he aPHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0wUzY5SNqZ8lI8WbTPsVddzJpG8JPHdmr367knEM8ig=; fh=X0hOMbpOU1raqJinhHHPFdyR1sBFq2lMGBVOqO0x1pk=; b=SVee1eLohig80YptSGomn7Fd7RyTWR7C1P88hMBwnXYxTj/dj8p82r3wTV1gZk8Q7l Qs2ngAooChixcF017fib9am/ZR4GYPOrDEuS4bHUXdzTCxOhSV62OCNu8VG1Ei9Mc4J1 SW2VJKZWamGPv5RhFcmp3J4nrEdxrUEuohXAPAv/m/bVV3cHUFEoOIxHV5CJ0k4wRlu+ o/AKz0P4vWgZsVweBja8snhfWgal9fKnWEWxYg8IISJx7KQ3l+X03tsFPQ5smro6dcjW 2+FdLPETK89/LdPveFfvOnGlqghoT9AkkmYHIKID9rNEzOvlg/V128rjraLccA4MmNmB Lymg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=A7U2fOEZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id bm22-20020a656e96000000b005bdf5961633si10202786pgb.21.2023.11.20.23.09.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 23:09:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=A7U2fOEZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 8D0A3804ADA0; Mon, 20 Nov 2023 23:08:01 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232043AbjKUHGm (ORCPT + 99 others); Tue, 21 Nov 2023 02:06:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229905AbjKUHGe (ORCPT ); Tue, 21 Nov 2023 02:06:34 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE3DDBC for ; Mon, 20 Nov 2023 23:06:29 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A9CAC433C9; Tue, 21 Nov 2023 07:06:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700550389; bh=p6LbyrzBaLsCjAoS9SsNRnPCnmltE2l6oztiZUD2C0A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A7U2fOEZsuWy1uv4zyWIq1VyTmJWxplU9kRS136V+4Io1AH3nNXv+CKmclItrLpfr 19yb5KBD9b7mh75Tn9Q+Eqzx8TKNi13r2247n/QqBk9qXIIJnqmKE/o3eUKM1ontUg V2WGHNh0s5FXNFaAIuH9hDcqlhsLh9Qd7eEYlHKHCfpI6arJvvgtuZb+Bhawso46IB dX80bOV6gXRQgX+IeribijtPDj1ME5ikTzNDqZDZK8uoPBfbAJog0WEfWooUfDqvs6 EjEFdKrMxq42fiODtzUiNfYwgw5u+TTa3pQz6QgIPQfuyBDiluCSx4mjRScCpGpfks eFK+CDpEUJW5w== From: Saeed Mahameed To: Arnd Bergmann , Greg Kroah-Hartman Cc: Jason Gunthorpe , Leon Romanovsky , Jiri Pirko , Leonid Bloch , Itay Avraham , Jakub Kicinski , linux-kernel@vger.kernel.org, Saeed Mahameed Subject: [PATCH V3 3/5] misc: mlx5ctl: Add info ioctl Date: Mon, 20 Nov 2023 23:06:17 -0800 Message-ID: <20231121070619.9836-4-saeed@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231121070619.9836-1-saeed@kernel.org> References: <20231121070619.9836-1-saeed@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 20 Nov 2023 23:08:01 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783156489740766026 X-GMAIL-MSGID: 1783156489740766026 From: Saeed Mahameed Implement INFO ioctl to return the allocated UID and the capability flags and some other useful device information such as the underlying ConnectX device. Example: $ sudo ./mlx5ctlu mlx5_core.ctl.0 mlx5dev: 0000:00:04.0 UCTX UID: 1 UCTX CAP: 0x3 DEV UCTX CAP: 0x3 USER CAP: 0x1d Reviewed-by: Jiri Pirko Reviewed-by: Leon Romanovsky Signed-off-by: Saeed Mahameed --- .../userspace-api/ioctl/ioctl-number.rst | 1 + drivers/misc/mlx5ctl/main.c | 71 +++++++++++++++++++ include/uapi/misc/mlx5ctl.h | 24 +++++++ 3 files changed, 96 insertions(+) create mode 100644 include/uapi/misc/mlx5ctl.h diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst b/Documentation/userspace-api/ioctl/ioctl-number.rst index 4ea5b837399a..9faf91ffefff 100644 --- a/Documentation/userspace-api/ioctl/ioctl-number.rst +++ b/Documentation/userspace-api/ioctl/ioctl-number.rst @@ -89,6 +89,7 @@ Code Seq# Include File Comments 0x20 all drivers/cdrom/cm206.h 0x22 all scsi/sg.h 0x3E 00-0F linux/counter.h +0x5c all uapi/misc/mlx5ctl.h Nvidia ConnectX control '!' 00-1F uapi/linux/seccomp.h '#' 00-3F IEEE 1394 Subsystem Block for the entire subsystem diff --git a/drivers/misc/mlx5ctl/main.c b/drivers/misc/mlx5ctl/main.c index 8eb150461b80..6a98b40e4300 100644 --- a/drivers/misc/mlx5ctl/main.c +++ b/drivers/misc/mlx5ctl/main.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include @@ -198,10 +199,80 @@ static int mlx5ctl_release(struct inode *inode, struct file *file) return 0; } +static int mlx5ctl_info_ioctl(struct file *file, + struct mlx5ctl_info __user *arg, + size_t usize) +{ + struct mlx5ctl_fd *mfd = file->private_data; + struct mlx5ctl_dev *mcdev = mfd->mcdev; + struct mlx5_core_dev *mdev = mcdev->mdev; + struct mlx5ctl_info *info; + size_t ksize = 0; + int err = 0; + + ksize = max(sizeof(struct mlx5ctl_info), usize); + info = kzalloc(ksize, GFP_KERNEL_ACCOUNT); + if (!info) + return -ENOMEM; + + info->size = sizeof(struct mlx5ctl_info); + + info->dev_uctx_cap = MLX5_CAP_GEN(mdev, uctx_cap); + info->uctx_cap = mfd->uctx_cap; + info->uctx_uid = mfd->uctx_uid; + info->ucap = mfd->ucap; + + strscpy(info->devname, dev_name(&mdev->pdev->dev), + sizeof(info->devname)); + + if (copy_to_user(arg, info, usize)) + err = -EFAULT; + + kfree(info); + return err; +} + +static long mlx5ctl_ioctl(struct file *file, unsigned int cmd, unsigned long arg) +{ + struct mlx5ctl_fd *mfd = file->private_data; + struct mlx5ctl_dev *mcdev = mfd->mcdev; + void __user *argp = (void __user *)arg; + size_t size = _IOC_SIZE(cmd); + int err = 0; + + if (!capable(CAP_SYS_ADMIN)) + return -EPERM; + + mlx5ctl_dbg(mcdev, "ioctl 0x%x type/nr: %d/%d size: %d DIR:%d\n", cmd, + _IOC_TYPE(cmd), _IOC_NR(cmd), _IOC_SIZE(cmd), _IOC_DIR(cmd)); + + down_read(&mcdev->rw_lock); + if (!mcdev->mdev) { + err = -ENODEV; + goto unlock; + } + + switch (cmd) { + case MLX5CTL_IOCTL_INFO: + err = mlx5ctl_info_ioctl(file, argp, size); + break; + + default: + mlx5ctl_dbg(mcdev, "Unknown ioctl %x\n", cmd); + err = -ENOIOCTLCMD; + break; + } +unlock: + up_read(&mcdev->rw_lock); + return err; +} + static const struct file_operations mlx5ctl_fops = { .owner = THIS_MODULE, .open = mlx5ctl_open, .release = mlx5ctl_release, + .unlocked_ioctl = mlx5ctl_ioctl, + .compat_ioctl = compat_ptr_ioctl, }; static int mlx5ctl_probe(struct auxiliary_device *adev, diff --git a/include/uapi/misc/mlx5ctl.h b/include/uapi/misc/mlx5ctl.h new file mode 100644 index 000000000000..37153cc0fc6e --- /dev/null +++ b/include/uapi/misc/mlx5ctl.h @@ -0,0 +1,24 @@ +/* SPDX-License-Identifier: BSD-3-Clause OR GPL-2.0 WITH Linux-syscall-note */ +/* Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. */ + +#ifndef __MLX5CTL_IOCTL_H__ +#define __MLX5CTL_IOCTL_H__ + +struct mlx5ctl_info { + __aligned_u64 flags; + __u32 size; + __u8 devname[64]; /* underlaying ConnectX device */ + __u16 uctx_uid; /* current process allocated UCTX UID */ + __u16 reserved1; + __u32 uctx_cap; /* current process effective UCTX cap */ + __u32 dev_uctx_cap; /* device's UCTX capabilities */ + __u32 ucap; /* process user capability */ + __u32 reserved2; +}; + +#define MLX5CTL_IOCTL_MAGIC 0x5c + +#define MLX5CTL_IOCTL_INFO \ + _IOR(MLX5CTL_IOCTL_MAGIC, 0x0, struct mlx5ctl_info) + +#endif /* __MLX5CTL_IOCTL_H__ */