diff mbox series

[-next] platform/mellanox: Simplify bool conversion

Message ID 20231121005557.69324-1-yang.lee@linux.alibaba.com
State New
Headers
Series [-next] platform/mellanox: Simplify bool conversion |

Commit Message

Yang Li Nov. 21, 2023, 12:55 a.m. UTC 
  ./drivers/platform/mellanox/mlxbf-tmfifo.c:94:41-46: WARNING: conversion to bool not needed here

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7584
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/platform/mellanox/mlxbf-tmfifo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ilpo Järvinen Nov. 21, 2023, 7:59 a.m. UTC | #1 
On Tue, 21 Nov 2023, Yang Li wrote:

> ./drivers/platform/mellanox/mlxbf-tmfifo.c:94:41-46: WARNING: conversion to bool not needed here
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7584
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Thank you for your patch.

This is already fixed by the commit 57eb82ff34e3 ("platform/mellanox: 
mlxbf-tmfifo: Remove unnecessary bool conversion") that is currently 
queued in pdf86.git/review-hans branch.

Also, next time write a better changelog, it's not enough to just quote 
an error message.
diff mbox series

Patch

diff --git a/drivers/platform/mellanox/mlxbf-tmfifo.c b/drivers/platform/mellanox/mlxbf-tmfifo.c
index 5c683b4eaf10..8ba23eb5be0b 100644
--- a/drivers/platform/mellanox/mlxbf-tmfifo.c
+++ b/drivers/platform/mellanox/mlxbf-tmfifo.c
@@ -91,7 +91,7 @@  struct mlxbf_tmfifo_vring {
 /* Check whether vring is in drop mode. */
 #define IS_VRING_DROP(_r) ({ \
 	typeof(_r) (r) = (_r); \
-	(r->desc_head == &r->drop_desc ? true : false); })
+	(r->desc_head == &r->drop_desc); })
 
 /* A stub length to drop maximum length packet. */
 #define VRING_DROP_DESC_MAX_LEN		GENMASK(15, 0)