From patchwork Mon Nov 20 22:28:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 167416 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2b07:b0:403:3b70:6f57 with SMTP id io7csp255638vqb; Mon, 20 Nov 2023 14:28:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IHyYxtV1VEA2JORFLdFp1Wyz9Q8Z5hZ5xaRq8Gg6uQXf+C9sbWrY+Qa74fTFbKuVHWS47mu X-Received: by 2002:a05:6a00:1912:b0:6c4:db03:d20f with SMTP id y18-20020a056a00191200b006c4db03d20fmr11723572pfi.17.1700519335950; Mon, 20 Nov 2023 14:28:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700519335; cv=none; d=google.com; s=arc-20160816; b=JC5GzZJ5xG0OFiumWJBeHH9aldy3xaqFm8NwmVGTYIw2yKrnP0QaY+T2bjzmAwK8P4 kjzGqPHF+x2SWSMeSZBBIHvFaHjzjFLznzd5fsxXBJWDujAM/86wyejTMxq4bFo9y0Nw xGbZteAS5tU83nWm+WeohOHulNqrOGnw3XHRzXpPMSRfyJG8YG2+wb1+D8nwUVLzfvBR FFQ9nNGm6tax2ebWhTsSIdEUcLwEVb+7FHekQo03rcZXODtd7eO7WjX3KvvzUSZe2IuR WHJXA5rhdYE2u6Yn83NtFWFsVoMiMcOQs7v0dz/CpHoBhBbwVJqcX7e7P4hHTtPP3JSz bFWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gX/SjJOpCJYCeQ+0Y6gb03+A86/1jzmynaxqby2BgAo=; fh=HQQk3d4NoxI9SpUlktd+4fu8zJW7NOgR72W71jUdFhg=; b=zz7lNIYa+QC4vUlCZ0Ve6QDBkEfUwwCZW8vbcqmRCcJqUuaQs7oYV1KP3lRyVTM4L3 3Cz7Cq2bEbVT7gChmcERysovGVudMbrV4e820BckV7bNt7rskiAMG9JJKmDHZmwmaYcw Ug2z4epcNr04PabnWGPjKETtZDnBL0EHtp2Xxjs8qqWcIxSgE+um+NmehP/8PO0xJfsb /b5LzY1w0ISZLOvwjpUCZutUCIvhgt6I6K2/h3h3mVQ6+6ggkZhlE4HAPAbbQ/WAcnz8 kcvzBXiqn5T8wKEMvjQmnJRVxOD/DC/mu01mpYVr/1MmZyIfm5KR3/crjrNHe60gevZU D4gg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nJEQgwWO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id cl22-20020a056a02099600b005c1ce3c9609si9789320pgb.889.2023.11.20.14.28.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 14:28:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nJEQgwWO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id D452D80941E7; Mon, 20 Nov 2023 14:28:54 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229902AbjKTW2p (ORCPT + 27 others); Mon, 20 Nov 2023 17:28:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232539AbjKTW2n (ORCPT ); Mon, 20 Nov 2023 17:28:43 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87CCD97 for ; Mon, 20 Nov 2023 14:28:40 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 402C8C433CA; Mon, 20 Nov 2023 22:28:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700519320; bh=lm7/gVjjO8J4rGGfH0O5RParZfMnIY0MkOc5Mwd5oTw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nJEQgwWOw+C7D8EhdvrVMZGCGeW51hRnSqEgzzkovWfmgQZMVejOyWW90TicHb9cR gSuTbi++TH6DeMRHW/0c5TzfwIwNeGFQI1O05cgt+tppgBXm5jGFvRdjVgl7CEQPSG j34REcfh1n/ag9wx3CAbciOYaMpeSuTe626Yp/Sb2pNWrJWSJBYXuFiwTDY4NGDxjh I/i0WB+FRhUzRsrM2jO4NFPJpU4YMC2hdETD5U/ddBm1Ld6E0JV0RSvHSttknPFIbs /rxAFZzE2O7NnLymcPwM08tbl4uXprn6CswuwexRlXliDejuQl35/tfySjABuERuhH KRpgUP7nAUk3A== From: Masahiro Yamada To: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Masahiro Yamada Subject: [PATCH 2/2] pinctrl: pinconf-generic: remove the special handling for no config case Date: Tue, 21 Nov 2023 07:28:32 +0900 Message-Id: <20231120222832.4063882-3-masahiroy@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231120222832.4063882-1-masahiroy@kernel.org> References: <20231120222832.4063882-1-masahiroy@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 20 Nov 2023 14:28:54 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783123763527741790 X-GMAIL-MSGID: 1783123763527741790 To further simplify pinconf_generic_parse_dt_config(), eliminate the handling of the case where no configuration is found. When ncfg is zero, krealloc_array() will set ZERO_SIZE_PTR to *configs, which is a natural approach for managing a zero-size buffer. This should have no impact because none of the callers accesses 'configs' when ncfg is zero. Also, it is safe to pass ZERO_SIZE_PTR to kfree(). Signed-off-by: Masahiro Yamada --- drivers/pinctrl/pinconf-generic.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/pinctrl/pinconf-generic.c b/drivers/pinctrl/pinconf-generic.c index ba4fe2466e78..252d69ee2b68 100644 --- a/drivers/pinctrl/pinconf-generic.c +++ b/drivers/pinctrl/pinconf-generic.c @@ -265,14 +265,6 @@ int pinconf_generic_parse_dt_config(struct device_node *np, parse_dt_cfg(np, pctldev->desc->custom_params, pctldev->desc->num_custom_params, cfg, &ncfg); - /* no configs found at all */ - if (ncfg == 0) { - kfree(cfg); - *configs = NULL; - *nconfigs = 0; - return 0; - } - /* Now resize the array to store the real number of found properties. */ *configs = krealloc_array(cfg, ncfg, sizeof(unsigned long), GFP_KERNEL); if (!*configs)