From patchwork Mon Nov 20 14:42:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 167206 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9910:0:b0:403:3b70:6f57 with SMTP id i16csp2253023vqn; Mon, 20 Nov 2023 06:49:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IGnIGRNWVDz5Z7P7EUFFgozp+ulGQGoCfBsFIYMegS+XcaELO3OZT2elAxy5FA8IsoMXxbN X-Received: by 2002:a9d:4e98:0:b0:6b8:7880:de9 with SMTP id v24-20020a9d4e98000000b006b878800de9mr7835663otk.19.1700491799232; Mon, 20 Nov 2023 06:49:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700491799; cv=none; d=google.com; s=arc-20160816; b=ue6bJuFLD40agOoST2VP6EUmGxpUY2/Fhnpdih9l9lM5ioYbCyvySxWfvFyJblN6ds vVEYHUnhJwR0QV1GP0QHVHpbJNl1GRyaOgj4yPiY7WGriehhKjHTg/sszQO4GTP6tPHP 05TQzUiQnY8kHHIoOnJsBjvYUlPbPOsBY75P+mVi9GczWI2vC61ahMrpQRS1xzPAGn8j 7nhXrr3RjjXQZf0iSizYHEGH5bT/456G4VMgFRhLsicirBP773SbYTmA46A18UmN9+WI 1xXYBnthvJV0PqMI2u+clzC1/5WLl8qj92N0qbTj65nQo0s6sSQxjlJL+eJl5tnSqCiX 3EYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=rPpSVeVkPx9XiO8WvQdBVC78FVKIH1X8jHTdWJOxHKI=; fh=g3amdiifXhwL/mTWljo4oOX/iLvH3RCBC8SWsJqOWek=; b=xvsAzzhMwRooUTfhXssXZZTnB2LBduAag38L7b7CLHH2svsyr8pwfCvFwCW/IEu8Z2 GlfRyU/+mzYVBsz7y1W0TrgIYojS4QAI6JjIZbT1r9aIHe+IezNkpkZKtn9SHC7oc+yl 9dmVUEnmY1tSHXUEYG8u3bJwbeiTsuqG9jvQbDV9/9cmmVvduvMuK3tjaPJJyefMSn1m jP7IWAOTfn27fVwe83mM4dko2l+0jIYwflszpbC1xZpHnZ+7IGwWs6xsDc7MehtnuWpf YMatYIR18DOnwFs8UOBezp8Tvwjt2bctbXvZNabq0NG/x4zYKsVNQRVeSvAesQjWndgC VBvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=M++pXFN1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id e24-20020a656498000000b005a1d88169casi8026146pgv.189.2023.11.20.06.49.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 06:49:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=M++pXFN1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 5FAFF8026AD3; Mon, 20 Nov 2023 06:47:54 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233980AbjKTOrt (ORCPT + 27 others); Mon, 20 Nov 2023 09:47:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233873AbjKTOrH (ORCPT ); Mon, 20 Nov 2023 09:47:07 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A821CD62; Mon, 20 Nov 2023 06:46:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700491619; x=1732027619; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=kTclvOl7vkPey5C16DKDFp42ZZYtPi/iqZTaSSBYP+g=; b=M++pXFN1LpNgHmYcj49Cv3v2wInBrHBHAQ1AJnrZzbgAT4C2ti9eTEl6 lcr+qXh7fuNQjObvByDf9iHru6r+mqPiNWXDwHc6bs2b1seTZq+DdMlsp 4mViOKmzkUgAtY4YCPifga8RGLhhtmRb7WqneqzfdX/uyUdKrgFVvNgpY 5epBpH/JlbxJq6HPwzBCqurAe/gfqNlj2HcekMrS0XB7mnYAuOktw0P6R 7acdb9u8d6e58PYNkp6VuMgKg2zaAgqX6iIhJfVR5Oq9gI7NKjjs/3nGN hl/ZjT4SyGX9Rv1qxLe97LfyT/2a3F+en9RiaElBTyJDgJBEeZNHe+xxI Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10900"; a="382017085" X-IronPort-AV: E=Sophos;i="6.04,214,1695711600"; d="scan'208";a="382017085" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2023 06:46:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10900"; a="832291657" X-IronPort-AV: E=Sophos;i="6.04,214,1695711600"; d="scan'208";a="832291657" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga008.fm.intel.com with ESMTP; 20 Nov 2023 06:46:54 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 4AC0C706; Mon, 20 Nov 2023 16:46:45 +0200 (EET) From: Andy Shevchenko To: Mario Limonciello , Jarkko Nikula , Herbert Xu , Andy Shevchenko , Wolfram Sang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mika Westerberg , Jan Dabros , Andi Shyti , Philipp Zabel Subject: [PATCH v4 23/24] i2c: designware: Get rid of redundant 'else' Date: Mon, 20 Nov 2023 16:42:05 +0200 Message-ID: <20231120144641.1660574-24-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20231120144641.1660574-1-andriy.shevchenko@linux.intel.com> References: <20231120144641.1660574-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 20 Nov 2023 06:47:54 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783094888840160765 X-GMAIL-MSGID: 1783094888840160765 In the snippets like the following if (...) return / goto / break / continue ...; else ... the 'else' is redundant. Get rid of it. Reviewed-by: Andi Shyti Reviewed-by: Mario Limonciello Signed-off-by: Andy Shevchenko --- drivers/i2c/busses/i2c-designware-common.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-common.c b/drivers/i2c/busses/i2c-designware-common.c index 45ced3354eef..b8e5d56473d6 100644 --- a/drivers/i2c/busses/i2c-designware-common.c +++ b/drivers/i2c/busses/i2c-designware-common.c @@ -639,10 +639,10 @@ int i2c_dw_handle_tx_abort(struct dw_i2c_dev *dev) if (abort_source & DW_IC_TX_ARB_LOST) return -EAGAIN; - else if (abort_source & DW_IC_TX_ABRT_GCALL_READ) + if (abort_source & DW_IC_TX_ABRT_GCALL_READ) return -EINVAL; /* wrong msgs[] data */ - else - return -EIO; + + return -EIO; } int i2c_dw_set_fifo_size(struct dw_i2c_dev *dev)