From patchwork Mon Nov 20 14:41:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 167192 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9910:0:b0:403:3b70:6f57 with SMTP id i16csp2252063vqn; Mon, 20 Nov 2023 06:48:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IG1nQyesLWgf0ZM8z6EgIV6wvOb2McyV794+obW9CCMKzC9yaOSru0cuQhUPFg1uW1WZ5Bd X-Received: by 2002:a05:6808:2f1b:b0:3ae:2024:837b with SMTP id gu27-20020a0568082f1b00b003ae2024837bmr11552868oib.34.1700491696898; Mon, 20 Nov 2023 06:48:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700491696; cv=none; d=google.com; s=arc-20160816; b=dka7owoM7vy7D5tm+dQKwru6EJOHFrT7PpTZShlWe57ehZ7WMQdqD0hY+4mHvooCgx pBMAYnZHcapuxn25OvHQTAs8QZWG0mnhaEN637Qvbl88TfI/HUjildhcLaoXs2d4Y+BK l5CPpv7ATPUGWwthNiOvAI6n0BKfewl5Vg9AwmhZvfsF2AbiR1a6b/JsyqxIe6r+Lpit yAHUisayCBF+3s0cvQz2v3qi5NLAwYufigXrC1WLwnoJzChPaxEQovvk7nnWeVIIj+bR NFBTjacrUABGrtvPXRYX5P14SEgys9AJ1A1Ws2EbQxU6gtU/m1Z7C3mJMKfXhMWT7vJK cPZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ngDzefH9wMIoa+2jvkgXPZFShMUnGE/mV8soCPIRNig=; fh=g3amdiifXhwL/mTWljo4oOX/iLvH3RCBC8SWsJqOWek=; b=b7b2Tcixy3cl5ATm35OvKsop4LuThFY30ZdS2IH0WCNj2tpnKabHExnORwdbQkzS3a SU4PYchVhSExzb/X4LlyNhWzb65pdcATdvsTNZ3VPMakMjEVQgWc3AgTp3I+RqJt3O5J 2bhnCDLKDdkxFr0xdjmGXGxRzdCVew1uP4zvTRV3XdY2xj4MXZjZmrlbe9Cd0py7hc5W IDvjBGzDfZYjug0muAhZkARXLDHsECo/0o99Io2l+FbRuUBysoYgxo/pRB2ojwrQUzkd ipIRwjFGQtu7gT/g/kWPecx4488U+L1RgeFzvzIZEOwB4v5UbyJgH0oTgy+cYbF/7BO5 uneA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=HK63N+sN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id j10-20020a63e74a000000b005bdcad0ac5esi7869227pgk.833.2023.11.20.06.48.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 06:48:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=HK63N+sN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 991B68053FB8; Mon, 20 Nov 2023 06:48:03 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233872AbjKTOrb (ORCPT + 27 others); Mon, 20 Nov 2023 09:47:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233804AbjKTOrE (ORCPT ); Mon, 20 Nov 2023 09:47:04 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14151113; Mon, 20 Nov 2023 06:46:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700491616; x=1732027616; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=6LUVSlowxDNf6cmdrMW1TQdrTDFwzR3hLjcQtZFNefI=; b=HK63N+sNE0rIa5v2YuEUCHaRHpa8bI2+MWV2LNtpL1QE6BqwWBZffqFv TLe4E48cx2AmalRd2GPsTvSZyi3Fpv2GRAZL1UsHEDDSjPQCxvrPGnh9S DB4tmx7jzmj+CumDQCqybI6Tve2dLSiQTqbBxp1wUmRy3V+WGIcMenzEl Ar20rSjqDA62lzwuCEvZWCf+CT3y6x3KYYyjN+F4TltmuiuL5zTbmz+4t +mueSCzs0Boiu88gdEq8zpq/5UYBtoNZGT4YZXxaGIH/eycDhMu6BZGCk byx+Z9v7ENE++cEQCKX7wcSUSPxW9wj0yDzeosqQiys0vzzjQskLR/fda A==; X-IronPort-AV: E=McAfee;i="6600,9927,10900"; a="382017038" X-IronPort-AV: E=Sophos;i="6.04,214,1695711600"; d="scan'208";a="382017038" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2023 06:46:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10900"; a="832291644" X-IronPort-AV: E=Sophos;i="6.04,214,1695711600"; d="scan'208";a="832291644" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga008.fm.intel.com with ESMTP; 20 Nov 2023 06:46:50 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id B4B4044A; Mon, 20 Nov 2023 16:46:44 +0200 (EET) From: Andy Shevchenko To: Mario Limonciello , Jarkko Nikula , Herbert Xu , Andy Shevchenko , Wolfram Sang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mika Westerberg , Jan Dabros , Andi Shyti , Philipp Zabel Subject: [PATCH v4 12/24] i2c: designware: Drop return value from dw_i2c_of_configure() Date: Mon, 20 Nov 2023 16:41:54 +0200 Message-ID: <20231120144641.1660574-13-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20231120144641.1660574-1-andriy.shevchenko@linux.intel.com> References: <20231120144641.1660574-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 20 Nov 2023 06:48:03 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783094781307216590 X-GMAIL-MSGID: 1783094781307216590 dw_i2c_of_configure() is called without checking of the returned value, hence just drop it by converting to void. Reviewed-by: Andi Shyti Reviewed-by: Mario Limonciello Acked-by: Jarkko Nikula Signed-off-by: Andy Shevchenko --- drivers/i2c/busses/i2c-designware-platdrv.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c index 15f19ec20b33..7449f1b37ecf 100644 --- a/drivers/i2c/busses/i2c-designware-platdrv.c +++ b/drivers/i2c/busses/i2c-designware-platdrv.c @@ -110,7 +110,7 @@ static int mscc_twi_set_sda_hold_time(struct dw_i2c_dev *dev) return 0; } -static int dw_i2c_of_configure(struct platform_device *pdev) +static void dw_i2c_of_configure(struct platform_device *pdev) { struct dw_i2c_dev *dev = platform_get_drvdata(pdev); @@ -123,8 +123,6 @@ static int dw_i2c_of_configure(struct platform_device *pdev) default: break; } - - return 0; } #else static int bt1_i2c_request_regs(struct dw_i2c_dev *dev) @@ -132,9 +130,8 @@ static int bt1_i2c_request_regs(struct dw_i2c_dev *dev) return -ENODEV; } -static inline int dw_i2c_of_configure(struct platform_device *pdev) +static inline void dw_i2c_of_configure(struct platform_device *pdev) { - return -ENODEV; } #endif