From patchwork Mon Nov 20 14:41:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 167204 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9910:0:b0:403:3b70:6f57 with SMTP id i16csp2253010vqn; Mon, 20 Nov 2023 06:49:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IFwzD9ihbCFqllZAEIQuUc01BAKjx5/WXhU7QjMcKkngN3xFi7MVDFZNPH8Thv7G5tvocdr X-Received: by 2002:a17:90a:e7cd:b0:281:40b:5a7a with SMTP id kb13-20020a17090ae7cd00b00281040b5a7amr8289180pjb.8.1700491797645; Mon, 20 Nov 2023 06:49:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700491797; cv=none; d=google.com; s=arc-20160816; b=yC5S1HqsfHDym/LWSTNjB/6sfNCz+mKeRXHh2Dc56T8lHdsfJIeax3fz3zb6w2q0tR PrWAr506Zs96q6QksyJm3cFhga0rbitSTeOPy/w8WJlEDEOErFkN30aqRE4a5xpx2FtK ReB4MDha3mYvYVgTJz56c2TfvTD7HdAE+thA0JqFHqAtY0LsEUZdCykBoBkTDY3ulMJw /yoZRekvDbxiLfB67PVykTirCPM31ByZskoHFj+6ZwHalayRZEyk0v7E/pvqWOIG9JV9 /6DLrH//vOxHfwr3BvS+K2rysDZEA0TLhFijS3WSJVKtHjLUOin73cJWLGzgdbN29Xql FKuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=A9hHCb8GJAAw33cJGnamiNhUzfN8pbYUfpA2C+SO72U=; fh=g3amdiifXhwL/mTWljo4oOX/iLvH3RCBC8SWsJqOWek=; b=mtvLqCTK+roYmq/gNfWSUMXakqplkAgwnujVjPkpykjlYWdvP2+QyqD3lWDqAU3ugC bqEgpc2RxNIBYv7gQGrPZhmvmfTgo9S5T6t592Ts5Bm4odoaa8oBoHuwIX9B9xDVoRQS O9I2ZlUxBZmjwW6LkII1YNIWYYfzEWAda+UOTccLXW20W305BIXOHSSEm+2n1VsfPWRz HgHrCSPdb8cZ0UdTKE9N9yMPyzM+83X+wJHba6taqKb/J6DGlf+yzdWZ9lwDo669NBuk 5Dc5c8PzQftl0otM6W47+jD8SdssCnTRYTJtswaZB5fZXOFj9+TpF1ctVZIZ+WFxMkt3 0seA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=lksr6iwW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id n15-20020a17090a73cf00b002804438ebcfsi10688933pjk.171.2023.11.20.06.49.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 06:49:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=lksr6iwW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 79BB180A9DFB; Mon, 20 Nov 2023 06:49:43 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233778AbjKTOrU (ORCPT + 27 others); Mon, 20 Nov 2023 09:47:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233761AbjKTOq6 (ORCPT ); Mon, 20 Nov 2023 09:46:58 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E2F4139; Mon, 20 Nov 2023 06:46:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700491615; x=1732027615; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0SVHCxyMs+vlVsjGpSiBU8bWb2RA8tmqrElqqof/mfI=; b=lksr6iwWosrD7HCgwkAm2VIWWKjSB+Xbru0NQrssUI0kfMwQL5rm6y/i DDrkDlw8SXtv1cCc8KOp2g2AVjXGcNkuGDFjdrcWk7NP7gPo3X1ujMUd+ 1OLM9iSqEv8H5H6Y3eybUN0EjxURL6kqLEj3DFNMpvvM/fC511wiz+fxF TN5R9lwxCvMSx+VQgNh9o2xilpQWFIR3cl+nng06JlwCUKL18Mc+kO5cP O/eP7NWMNNLb613EjQ6v4zhX4uwfBx4QpdBHcYPCaZGDIglxOKXoLZp73 e+xY/0F80pZQiZervMhVCsksES7t/XO1B/EAify21V76XmmplT0SA5Qjo A==; X-IronPort-AV: E=McAfee;i="6600,9927,10900"; a="455956474" X-IronPort-AV: E=Sophos;i="6.04,214,1695711600"; d="scan'208";a="455956474" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2023 06:46:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10900"; a="801193156" X-IronPort-AV: E=Sophos;i="6.04,214,1695711600"; d="scan'208";a="801193156" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga001.jf.intel.com with ESMTP; 20 Nov 2023 06:46:49 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id A940242D; Mon, 20 Nov 2023 16:46:44 +0200 (EET) From: Andy Shevchenko To: Mario Limonciello , Jarkko Nikula , Herbert Xu , Andy Shevchenko , Wolfram Sang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mika Westerberg , Jan Dabros , Andi Shyti , Philipp Zabel Subject: [PATCH v4 11/24] i2c: designware: Drop return value from i2c_dw_acpi_configure() Date: Mon, 20 Nov 2023 16:41:53 +0200 Message-ID: <20231120144641.1660574-12-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20231120144641.1660574-1-andriy.shevchenko@linux.intel.com> References: <20231120144641.1660574-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 20 Nov 2023 06:49:43 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783094887367244014 X-GMAIL-MSGID: 1783094887367244014 i2c_dw_acpi_configure() is called without checking of the returned value, hence just drop it by converting to void. Reviewed-by: Andi Shyti Acked-by: Jarkko Nikula Signed-off-by: Andy Shevchenko --- drivers/i2c/busses/i2c-designware-common.c | 4 +--- drivers/i2c/busses/i2c-designware-core.h | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-common.c b/drivers/i2c/busses/i2c-designware-common.c index 35f762872b8a..7a53a732981b 100644 --- a/drivers/i2c/busses/i2c-designware-common.c +++ b/drivers/i2c/busses/i2c-designware-common.c @@ -255,7 +255,7 @@ static void i2c_dw_acpi_params(struct device *device, char method[], kfree(buf.pointer); } -int i2c_dw_acpi_configure(struct device *device) +void i2c_dw_acpi_configure(struct device *device) { struct dw_i2c_dev *dev = dev_get_drvdata(device); struct i2c_timings *t = &dev->timings; @@ -285,8 +285,6 @@ int i2c_dw_acpi_configure(struct device *device) dev->sda_hold_time = fs_ht; break; } - - return 0; } EXPORT_SYMBOL_GPL(i2c_dw_acpi_configure); diff --git a/drivers/i2c/busses/i2c-designware-core.h b/drivers/i2c/busses/i2c-designware-core.h index f8dd87cb0ae9..b7884f15e0e9 100644 --- a/drivers/i2c/busses/i2c-designware-core.h +++ b/drivers/i2c/busses/i2c-designware-core.h @@ -399,7 +399,7 @@ int i2c_dw_validate_speed(struct dw_i2c_dev *dev); void i2c_dw_adjust_bus_speed(struct dw_i2c_dev *dev); #if IS_ENABLED(CONFIG_ACPI) -int i2c_dw_acpi_configure(struct device *device); +void i2c_dw_acpi_configure(struct device *device); #else -static inline int i2c_dw_acpi_configure(struct device *device) { return -ENODEV; } +static inline void i2c_dw_acpi_configure(struct device *device) { } #endif