From patchwork Mon Nov 20 14:10:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 167165 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9910:0:b0:403:3b70:6f57 with SMTP id i16csp2228087vqn; Mon, 20 Nov 2023 06:13:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IGYnHz8Mt8PF0YffoqlCmHHYwz38PTjHytl+vkh1RtsC/9OcS3A+s9vQ5dUue+dKvNkuvoP X-Received: by 2002:a05:6a20:4305:b0:181:a784:67df with SMTP id h5-20020a056a20430500b00181a78467dfmr19285278pzk.20.1700489606946; Mon, 20 Nov 2023 06:13:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700489606; cv=none; d=google.com; s=arc-20160816; b=WtbeQR947EAq+1vlI140z/wdn9O7mhCZ4NNm6q7AZFTclfpXA7rMDkt9sg1HXGDm40 6iHwR2E+t9FuFaBr1+fo2lzSBjrr3nEHcp7gCMIPBJOl0V8le6eFZETYkuZnTTCgi3rU U4L4pAgacbazhNCo6NPeSD8xyZIiYLe9lRlK9rXXglARG/ApD/xuIeFJPyz5g9dTlO9C U2PkYFbHOaXM8mS9Sx9Ohx409ZRoliBBegqfL7jhJTIEOlazkKn05aw3K8X02LIfQmfx vQSos+yl0foWweOpMCNDglqvuV46TSGhEG1SJGDf9JNrSMzTlT06PWosdGWEaHGys2XP PI9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4w7l8+gkL8jy3vFxe/stI/iS+p9FeWAy0tEGqMDjP74=; fh=FKFziR/iyL6nLEsSp1Wcfxi2t3uP2D84uB4BdJKSFcA=; b=Dlsiq/4Jj3gC34n+SJIr2zy/aVIx/5geZPDTb2bEAp+rYdB+Q0EqrnmiuKi5KnzJjK fW3YvGF8cV6N78jv4aZxKbITY6PnPTBlA1RJUARZtCTCW1pbGp9Q4YOxoZsjvUgj2EvW ecCwfEM0Aj3/CRsANoMaNVY5iqmcNfOnH+9m8rat7foawBKeJBbA3hnWaOy7NDpQVje2 DQiZlMOak4e7n+YXEDhqssugqhHUHOL1RAKruehLlA21mhwGKYBbonblicFgqbZ1p5gf /hjlDw4J3MXS6kSqrJTWzAESBxR/UOcacIV12jSGXeG8l1B3h1HHK6pCNbOhU6QHnN3m 4WUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=js7MhCg2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id l123-20020a632581000000b00577f7b6e7b4si8330264pgl.624.2023.11.20.06.13.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 06:13:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=js7MhCg2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 86D2D8035129; Mon, 20 Nov 2023 06:13:20 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232947AbjKTONJ (ORCPT + 27 others); Mon, 20 Nov 2023 09:13:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232759AbjKTONI (ORCPT ); Mon, 20 Nov 2023 09:13:08 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CB21BA; Mon, 20 Nov 2023 06:13:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700489584; x=1732025584; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1DDuOJefk+3o6ygYL1H6D6JOyUtWSGokeA8lulBT4/o=; b=js7MhCg2iKZhxWkxlLu3Q4w5+PoKPgLwl5qDj1TQxAXUiHX9IF+UG9FP z0dKwd792mJbcjZop+9QAsd6jto6ApdG7S03c0TFPu2+M+em/5c0M5Xng 8Mn57W2wHU4NAPYTuqsjGA69e4gWEJuSJIHu6GQa11sc/lnNWEjSYvFAq 1Gl05nxV+cF9l0kRBrqWWr9wcL6HasOme8GB5dSkHcHWqXFY+jEvfPfnd KTO6n7D1ykrzvszKPoZbus/IcLsLODlNEEDlBqA9VTaElOMlFgcEGf6qD c3SGQexN4V+KxlKxpMmkTWx8dj8F72xb0e8CWNPmge8TMx/ek4P4NU5nw Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10900"; a="458121746" X-IronPort-AV: E=Sophos;i="6.04,214,1695711600"; d="scan'208";a="458121746" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2023 06:12:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10900"; a="801184237" X-IronPort-AV: E=Sophos;i="6.04,214,1695711600"; d="scan'208";a="801184237" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga001.jf.intel.com with ESMTP; 20 Nov 2023 06:12:34 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 2BDE72F0; Mon, 20 Nov 2023 16:12:33 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Tony Luck , Borislav Petkov , James Morse , Mauro Carvalho Chehab , Robert Richter , Qiuxu Zhuo Subject: [PATCH v2 3/4] EDAC, pnd2: Correct misleading error message in mk_region_mask() Date: Mon, 20 Nov 2023 16:10:47 +0200 Message-ID: <20231120141231.1638240-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20231120141231.1638240-1-andriy.shevchenko@linux.intel.com> References: <20231120141231.1638240-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 20 Nov 2023 06:13:20 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783092589993242643 X-GMAIL-MSGID: 1783092589993242643 The mask parameter is expected to be of a sequence of the set bits. It does not mean it must be power of two (only single bit set). Correct misleading error message. Suggested-by: Qiuxu Zhuo Signed-off-by: Andy Shevchenko --- v2: new patch as suggested (Qiuxu) drivers/edac/pnd2_edac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c index ee7c9b024354..969fb2465edb 100644 --- a/drivers/edac/pnd2_edac.c +++ b/drivers/edac/pnd2_edac.c @@ -329,7 +329,7 @@ static void mk_region_mask(char *name, struct region *rp, u64 base, u64 mask) return; } if (mask != GENMASK_ULL(PND_MAX_PHYS_BIT, __ffs(mask))) { - pr_info(FW_BUG "MOT mask not power of two\n"); + pr_info(FW_BUG "MOT mask is invalid\n"); return; } if (base & ~mask) {