From patchwork Mon Nov 20 08:15:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xing Tong Wu X-Patchwork-Id: 166971 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9910:0:b0:403:3b70:6f57 with SMTP id i16csp2049268vqn; Mon, 20 Nov 2023 00:16:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IE4PzBOjg1N7NZGD21n5YhAowWytTFPxzKyR5e82HueRgYBXT6GGmOQxptXaeYoPGTdUTDn X-Received: by 2002:a05:6a00:3929:b0:6c4:cfe4:cfd with SMTP id fh41-20020a056a00392900b006c4cfe40cfdmr5424940pfb.31.1700468210452; Mon, 20 Nov 2023 00:16:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700468210; cv=none; d=google.com; s=arc-20160816; b=t9OLXAmDloBq0P226hBwy7sTAq7iWMXhzD/ZrheQGSWbhdrgPjqGAkXyE8DBUUUnrw V708Q2CFj2yzfb87wcc1Cr5jPyZCWjUNPsruVuLD/msMSYJLpapKZdiRZMxEoE6xmKmH p2446SxRjs6k/fpSjn1FCdAz0fZubVUEPFurDNGkwjhQpdr38PmgMnCGtTS4HT/VXA3m YeB9XeU6MByrvDXd97mG9RzLjwWAhpwr+QOYnH4P9cJwNT5AfSFVnrilUHOlq8+b8jae ih21vZJtyQnc1NNsDaCX8JdwC65L3If5Csb5JCeNH9sT/muOj4Y79sGY7E3vmWA8WUdg 7GQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=hgq9ZCjqvMpwCSb1biw4ArBkdPTWEHtoxNKDFAzpN0k=; fh=brTD9uWwHSBEuDMsNSIyrWZVEeJXt4Ae/wkRCvfJiZk=; b=NXP20SJQl0kWvhctWBLeKWfcWupySOIBdfSaopDrT0PFnhz1xeXevOMbdEQCzr1c2Y +ZLCPrSmVEGqngKkpenYSkxnpJTF77tjl84JDpH3CWzZuCMes5AuClvs0q61j9q0akJ4 WL8sc01dgywqOIMlyIm6VeNewrm990P5UZOxel6FG4pqZUq0keE65/4fTgXXOBnMErSM sv9vflWoh8woq7sHu4pfdh+LfXI8gq3WaQ9NczmiyEpSKAHrdc1oFySe7nWR4NfPZ8l7 cSWXmti9NxAcpQ6dRHUKrUFQOjkH0DgG6WdzZKMHrYyoaDDAAwQcjjp74AunzXR6oBp0 W0UQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b="exk3C/Uh"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id h2-20020a056a00170200b006cbb132d46dsi656788pfc.244.2023.11.20.00.16.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 00:16:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b="exk3C/Uh"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id C9CF1807F4AE; Mon, 20 Nov 2023 00:16:47 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232180AbjKTIQa (ORCPT + 27 others); Mon, 20 Nov 2023 03:16:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232143AbjKTIQY (ORCPT ); Mon, 20 Nov 2023 03:16:24 -0500 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.215]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5BC6AED; Mon, 20 Nov 2023 00:16:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=hgq9Z CjqvMpwCSb1biw4ArBkdPTWEHtoxNKDFAzpN0k=; b=exk3C/Uhfftv5amfG00sR AY3Vc7WhJv1YhR6kpFwPbhJ2I8uF5NgpDHqjcw/3MxJpAVK79Z3Zu3F9fgA+6jB+ vgDqDhOopCLYV7XwlKzOYOCJK/y8DK457xb/rOeKVby8av0dup0LsaZ16oHBqO1S HDDQGVhCG/Ef5sJS5uaduc= Received: from localhost.localdomain (unknown [39.144.137.207]) by zwqz-smtp-mta-g3-2 (Coremail) with SMTP id _____wDH52myFVtlTcE1Dg--.30221S4; Mon, 20 Nov 2023 16:15:50 +0800 (CST) From: Xing Tong Wu To: Guenter Roeck , Jean Delvare , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Cc: xingtong.wu@siemens.com, tobias.schaffner@siemens.com, gerd.haeussler.ext@siemens.com Subject: [PATCH v2 2/2] hwmon: (nct6775) Fix fan speed set failure in automatic mode Date: Mon, 20 Nov 2023 16:15:42 +0800 Message-Id: <20231120081542.3174-3-xingtong_wu@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231120081542.3174-1-xingtong_wu@163.com> References: <20231120081542.3174-1-xingtong_wu@163.com> MIME-Version: 1.0 X-CM-TRANSID: _____wDH52myFVtlTcE1Dg--.30221S4 X-Coremail-Antispam: 1Uf129KBjvdXoWrtFWDWr4UXw45ZrykWrWfZrb_yoWfKFb_Ww 4F93s7urs8tF1ak34q9FyFyFy5tFW5WFWxXFnFg3s8Ja4jvw1DAFyvqr9Fqw17CFW29FyD Wa17WrW0934UCjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUeo7K5UUUUU== X-Originating-IP: [39.144.137.207] X-CM-SenderInfo: p0lqw35rqjs4rx6rljoofrz/1tbiEBwu0F8YMmhU7wAAsU X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 20 Nov 2023 00:16:47 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783070154434491015 X-GMAIL-MSGID: 1783070154434491015 From: Xing Tong Wu Setting the fan speed is only valid in manual mode; it is not possible to set the fan's speed in automatic mode. Return error when attempting to set the fan speed in automatic mode. Signed-off-by: Xing Tong Wu --- drivers/hwmon/nct6775-core.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/hwmon/nct6775-core.c b/drivers/hwmon/nct6775-core.c index c24b2c312911..38c2e5b7cfe9 100644 --- a/drivers/hwmon/nct6775-core.c +++ b/drivers/hwmon/nct6775-core.c @@ -2556,6 +2556,13 @@ store_pwm(struct device *dev, struct device_attribute *attr, const char *buf, int err; u16 reg; + /* + * The fan control mode should be set to manual if the user wants to adjust + * the fan speed. Otherwise, it will fail to set. + */ + if (index == 0 && data->pwm_enable[nr] > manual) + return -EBUSY; + err = kstrtoul(buf, 10, &val); if (err < 0) return err;