diff mbox series

[v2,2/2] dt-bindings: usb: snps,dwc3: Add 'xhci-sg-trb-cache-size-quirk'

Message ID 20231120055803.224634-3-quic_prashk@quicinc.com
State New
Headers
Series Add support for xhci-sg-trb-cache-size-quirk |

Commit Message

Prashanth K Nov. 20, 2023, 5:58 a.m. UTC 
  Add a new 'xhci-sg-trb-cache-size-quirk' DT quirk to dwc3 core
for preventing xhci hang issue while using SG buffers.

Cc: <stable@vger.kernel.org> # 5.11
Fixes: bac1ec551434 ("usb: xhci: Set quirk for XHCI_SG_TRB_CACHE_SIZE_QUIRK")
Signed-off-by: Prashanth K <quic_prashk@quicinc.com>
---
 Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Krzysztof Kozlowski Nov. 20, 2023, 9:14 a.m. UTC | #1 
On 20/11/2023 06:58, Prashanth K wrote:
> Add a new 'xhci-sg-trb-cache-size-quirk' DT quirk to dwc3 core
> for preventing xhci hang issue while using SG buffers.

Neither commit msg nor property describes the hardware feature. Please
describe the hardware, not OS behavior, in the property. Both in the
property name and in its description.

> 
> Cc: <stable@vger.kernel.org> # 5.11
> Fixes: bac1ec551434 ("usb: xhci: Set quirk for XHCI_SG_TRB_CACHE_SIZE_QUIRK")
> Signed-off-by: Prashanth K <quic_prashk@quicinc.com>
> ---

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.

Please kindly resend and include all necessary To/Cc entries.

Also, use proper order of patches - first bindings, then their user.

Best regards,
Krzysztof
Krzysztof Kozlowski Nov. 20, 2023, 9:15 a.m. UTC | #2 
On 20/11/2023 06:58, Prashanth K wrote:
> Add a new 'xhci-sg-trb-cache-size-quirk' DT quirk to dwc3 core
> for preventing xhci hang issue while using SG buffers.
> 
> Cc: <stable@vger.kernel.org> # 5.11
> Fixes: bac1ec551434 ("usb: xhci: Set quirk for XHCI_SG_TRB_CACHE_SIZE_QUIRK")

Also, you need to describe the bug to justify backporting. Don't add
useless stable-cc tags just because kernel robot asked you...


Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
index ee5af4b381b1..768fdb5b1f05 100644
--- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
@@ -459,6 +459,13 @@  properties:
     description:
       Enable USB remote wakeup.
 
+  xhci-sg-trb-cache-size-quirk:
+    description:
+      When set, fixes the SNPS xHC hang issue when the data is scattered across
+      small buffers which does not make at least MPS size for given controller
+      TRB cache size.
+    type: boolean
+
 unevaluatedProperties: false
 
 required: