Message ID | 20231119053737.2367955-1-masahiroy@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9910:0:b0:403:3b70:6f57 with SMTP id i16csp1505208vqn; Sat, 18 Nov 2023 21:38:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IHEd7M+M1oa5KrkgoVoR5vQh06dDHeoP4Zoi3yOPLjyp0zN/OEKylIVrzxse09DS5xzeLK9 X-Received: by 2002:a05:6358:63a9:b0:16b:fa63:4f44 with SMTP id k41-20020a05635863a900b0016bfa634f44mr4615675rwh.10.1700372282432; Sat, 18 Nov 2023 21:38:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700372282; cv=none; d=google.com; s=arc-20160816; b=LC0ryaXSLQtJUF7v1m8yW+ryHwTTb2ykr18+7Z0zWnb6RGh7YYu3TZz0kpYm4Gj3Kr PnEeUhHbtAswNpb6H5PprdXUde+g/4766J8GkM/B+1jdtPN5FaQmavF7kB6xxuMzjotL qKhaCbGugDNcX68GYdqYEeMw87BnTxCAf9U6fFsghFUPao4OOTrCtB4EUtb/ERPVFpfb ovkJ7qCTQ6+lcn96LVIdGEbjU5QkMMyg2jKrxou7j9FWfeY5iAjEFKv60xqHxEzcznAG YSjUVfc8OfLgBHra0UiISu6uWaQUTl6PL800eejyYwvFg+bPt4OAvSQV1HjlOcxsTxck 0XSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=MEMIazYSnAoemnNbhPy/wGW1+2E5AwZ7BJwhKDbz3Is=; fh=PypDFbqbxf8g7X3OQuXt51VFJY5lLoE2EaofbNuzFcQ=; b=R6srimhGD+O9l9FLlatxCtYfVp2fAF5nfFJXgm08+MgKNgd2klSIwRm3OYljGbQGdT 1wTNvW+97iHZoUMTj08psU4tEKu8dCjzXxPSgj8HFBNBqXJxAPuCQ115mdFiZeRAcqEy 5m82MysBXBGLgNlVJwbumeQh4z3dUvgbE3Jfpl1rLkS8Qpdv/VThu7yhhdj8RiDUYrD9 JXLgYtPgy7abM7N3lBYynGtKpT9MM9EdsRrKpOJano1buWqtSO00dyupfXyXFG2CGzEX JTxKkAyGK+XiVvrKbmXq+2o6gGuY1NgTaIdgkTgxFlAQJHw+N9Vua/AG+kf/zwrX21hb RCRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fPXthR4S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id c10-20020a631c4a000000b005bdff953b76si5472567pgm.197.2023.11.18.21.38.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 21:38:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fPXthR4S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 3736D80942F3; Sat, 18 Nov 2023 21:37:58 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229703AbjKSFh6 (ORCPT <rfc822;ouuuleilei@gmail.com> + 99 others); Sun, 19 Nov 2023 00:37:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229454AbjKSFhz (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 19 Nov 2023 00:37:55 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7499C192 for <linux-kernel@vger.kernel.org>; Sat, 18 Nov 2023 21:37:52 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24BDDC433C7; Sun, 19 Nov 2023 05:37:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700372271; bh=nCPW9jBGTKyH0lUgrulKPDATJP5U30lWuKcxg55VFaY=; h=From:To:Cc:Subject:Date:From; b=fPXthR4SMxV1YOulnCEOsajU77bv4NJMJaOkL5W2+lOvh8ay5diPw5thg79i2pgab RJGu1pUHfJSwCN4WAOEGNZh69U6h96xhwQ596fTffX5NgvIOZzKtHAqmkveddFi9ze QI7y8x/xj0TuCyfjuLw57bgkdvtAIQ3kLUO+03GDa07HzvIhKFbQeT1FLcA8Pu2iOv zop247siEZyS6ESBv6ES7nxk3AnjaMugRD/FVjAigmHOkPji63sPG1wpEp0GtJjDVX P0s7ZioSbrbL12twnOBgNFB5zYoYZrc0TpoDaqyk3vO8w90vbmh5Ak00jdAU/ztA2l OGMYPXHw1c2VQ== From: Masahiro Yamada <masahiroy@kernel.org> To: Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, linux-riscv@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>, Simon Glass <sjg@chromium.org>, Masahiro Yamada <masahiroy@kernel.org> Subject: [PATCH] riscv: add dependency among Image(.gz), loader(.bin), and vmlinuz.efi Date: Sun, 19 Nov 2023 14:37:37 +0900 Message-Id: <20231119053737.2367955-1-masahiroy@kernel.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Sat, 18 Nov 2023 21:37:58 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782969566740914011 X-GMAIL-MSGID: 1782969566740914011 |
Series |
riscv: add dependency among Image(.gz), loader(.bin), and vmlinuz.efi
|
|
Commit Message
Masahiro Yamada
Nov. 19, 2023, 5:37 a.m. UTC
A common issue in Makefile is a race in parallel building.
You need to be careful to prevent multiple threads from writing to the
same file simultaneously.
Commit 3939f3345050 ("ARM: 8418/1: add boot image dependencies to not
generate invalid images") addressed such a bad scenario.
A similar symptom occurs with the following command:
$ make -j$(nproc) ARCH=riscv Image Image.gz loader loader.bin vmlinuz.efi
[ snip ]
SORTTAB vmlinux
OBJCOPY arch/riscv/boot/Image
OBJCOPY arch/riscv/boot/Image
OBJCOPY arch/riscv/boot/Image
OBJCOPY arch/riscv/boot/Image
OBJCOPY arch/riscv/boot/Image
GZIP arch/riscv/boot/Image.gz
AS arch/riscv/boot/loader.o
AS arch/riscv/boot/loader.o
Kernel: arch/riscv/boot/Image is ready
PAD arch/riscv/boot/vmlinux.bin
GZIP arch/riscv/boot/vmlinuz
Kernel: arch/riscv/boot/loader is ready
OBJCOPY arch/riscv/boot/loader.bin
Kernel: arch/riscv/boot/loader.bin is ready
Kernel: arch/riscv/boot/Image.gz is ready
OBJCOPY arch/riscv/boot/vmlinuz.o
LD arch/riscv/boot/vmlinuz.efi.elf
OBJCOPY arch/riscv/boot/vmlinuz.efi
Kernel: arch/riscv/boot/vmlinuz.efi is ready
The log "OBJCOPY arch/arm64/boot/Image" is displayed 5 times.
(also "AS arch/riscv/boot/loader.o" twice.)
It indicates that 5 threads simultaneously enter arch/riscv/boot/
and write to arch/riscv/boot/Image.
It occasionally leads to a build failure:
$ make -j$(nproc) ARCH=riscv Image Image.gz loader loader.bin vmlinuz.efi
[ snip ]
SORTTAB vmlinux
OBJCOPY arch/riscv/boot/Image
OBJCOPY arch/riscv/boot/Image
OBJCOPY arch/riscv/boot/Image
OBJCOPY arch/riscv/boot/Image
PAD arch/riscv/boot/vmlinux.bin
truncate: Invalid number: 'arch/riscv/boot/vmlinux.bin'
make[2]: *** [drivers/firmware/efi/libstub/Makefile.zboot:13: arch/riscv/boot/vmlinux.bin] Error 1
make[2]: *** Deleting file 'arch/riscv/boot/vmlinux.bin'
make[1]: *** [arch/riscv/Makefile:167: vmlinuz.efi] Error 2
make[1]: *** Waiting for unfinished jobs....
Kernel: arch/riscv/boot/Image is ready
GZIP arch/riscv/boot/Image.gz
AS arch/riscv/boot/loader.o
AS arch/riscv/boot/loader.o
Kernel: arch/riscv/boot/loader is ready
OBJCOPY arch/riscv/boot/loader.bin
Kernel: arch/riscv/boot/loader.bin is ready
Kernel: arch/riscv/boot/Image.gz is ready
make: *** [Makefile:234: __sub-make] Error 2
Image.gz, loader, vmlinuz.efi depend on Image. loader.bin depends
on loader. Such dependencies are not specified in arch/riscv/Makefile.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
arch/riscv/Makefile | 2 ++
1 file changed, 2 insertions(+)
Comments
On Sun, Nov 19, 2023 at 2:37 PM Masahiro Yamada <masahiroy@kernel.org> wrote: > > A common issue in Makefile is a race in parallel building. > > You need to be careful to prevent multiple threads from writing to the > same file simultaneously. > > Commit 3939f3345050 ("ARM: 8418/1: add boot image dependencies to not > generate invalid images") addressed such a bad scenario. > > A similar symptom occurs with the following command: > > $ make -j$(nproc) ARCH=riscv Image Image.gz loader loader.bin vmlinuz.efi > [ snip ] > SORTTAB vmlinux > OBJCOPY arch/riscv/boot/Image > OBJCOPY arch/riscv/boot/Image > OBJCOPY arch/riscv/boot/Image > OBJCOPY arch/riscv/boot/Image > OBJCOPY arch/riscv/boot/Image > GZIP arch/riscv/boot/Image.gz > AS arch/riscv/boot/loader.o > AS arch/riscv/boot/loader.o > Kernel: arch/riscv/boot/Image is ready > PAD arch/riscv/boot/vmlinux.bin > GZIP arch/riscv/boot/vmlinuz > Kernel: arch/riscv/boot/loader is ready > OBJCOPY arch/riscv/boot/loader.bin > Kernel: arch/riscv/boot/loader.bin is ready > Kernel: arch/riscv/boot/Image.gz is ready > OBJCOPY arch/riscv/boot/vmlinuz.o > LD arch/riscv/boot/vmlinuz.efi.elf > OBJCOPY arch/riscv/boot/vmlinuz.efi > Kernel: arch/riscv/boot/vmlinuz.efi is ready > > The log "OBJCOPY arch/arm64/boot/Image" is displayed 5 times. This should be "OBJCOPY arch/riscv/boot/Image". I submitted a similar patch for arm64. I copy-pasted some parts of the commit description, then missed to adjust it. > (also "AS arch/riscv/boot/loader.o" twice.) > > It indicates that 5 threads simultaneously enter arch/riscv/boot/ > and write to arch/riscv/boot/Image. > > It occasionally leads to a build failure: > > $ make -j$(nproc) ARCH=riscv Image Image.gz loader loader.bin vmlinuz.efi > [ snip ] > SORTTAB vmlinux > OBJCOPY arch/riscv/boot/Image > OBJCOPY arch/riscv/boot/Image > OBJCOPY arch/riscv/boot/Image > OBJCOPY arch/riscv/boot/Image > PAD arch/riscv/boot/vmlinux.bin > truncate: Invalid number: 'arch/riscv/boot/vmlinux.bin' > make[2]: *** [drivers/firmware/efi/libstub/Makefile.zboot:13: arch/riscv/boot/vmlinux.bin] Error 1 > make[2]: *** Deleting file 'arch/riscv/boot/vmlinux.bin' > make[1]: *** [arch/riscv/Makefile:167: vmlinuz.efi] Error 2 > make[1]: *** Waiting for unfinished jobs.... > Kernel: arch/riscv/boot/Image is ready > GZIP arch/riscv/boot/Image.gz > AS arch/riscv/boot/loader.o > AS arch/riscv/boot/loader.o > Kernel: arch/riscv/boot/loader is ready > OBJCOPY arch/riscv/boot/loader.bin > Kernel: arch/riscv/boot/loader.bin is ready > Kernel: arch/riscv/boot/Image.gz is ready > make: *** [Makefile:234: __sub-make] Error 2 > > Image.gz, loader, vmlinuz.efi depend on Image. loader.bin depends > on loader. Such dependencies are not specified in arch/riscv/Makefile. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > --- > > arch/riscv/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile > index 5cbe596345c1..1d6ed27e0a2a 100644 > --- a/arch/riscv/Makefile > +++ b/arch/riscv/Makefile > @@ -163,6 +163,8 @@ BOOT_TARGETS := Image Image.gz loader loader.bin xipImage vmlinuz.efi > > all: $(notdir $(KBUILD_IMAGE)) > > +loader.bin: loader > +Image.gz loader vmlinuz.efi: Image > $(BOOT_TARGETS): vmlinux > $(Q)$(MAKE) $(build)=$(boot) $(boot)/$@ > @$(kecho) ' Kernel: $(boot)/$@ is ready' > -- > 2.40.1 >
diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile index 5cbe596345c1..1d6ed27e0a2a 100644 --- a/arch/riscv/Makefile +++ b/arch/riscv/Makefile @@ -163,6 +163,8 @@ BOOT_TARGETS := Image Image.gz loader loader.bin xipImage vmlinuz.efi all: $(notdir $(KBUILD_IMAGE)) +loader.bin: loader +Image.gz loader vmlinuz.efi: Image $(BOOT_TARGETS): vmlinux $(Q)$(MAKE) $(build)=$(boot) $(boot)/$@ @$(kecho) ' Kernel: $(boot)/$@ is ready'