From patchwork Sat Nov 18 17:42:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 166597 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9910:0:b0:403:3b70:6f57 with SMTP id i16csp1295183vqn; Sat, 18 Nov 2023 09:43:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IFCUS/HOaNhuCekz5sttQMF+8NDJr03gwowogzRXdMJcg1MlwxjDf8fHslWeJLIUN2JydMX X-Received: by 2002:a05:6871:80c9:b0:1d5:8fb8:98ef with SMTP id sm9-20020a05687180c900b001d58fb898efmr3433414oab.31.1700329401400; Sat, 18 Nov 2023 09:43:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700329401; cv=none; d=google.com; s=arc-20160816; b=nbKJ6tXR8Pd/Qd5t7QCi8Ytmx4oFqOA/nODhrNC6Y7ikUB7ABK6A5B5FkVuB+p7+4F G07CGFPmkvtS2AxqyMryG5UbxKEAQFAM8+0L3lAZJSpe1wK7VgUsjrXhob6v8im5zOoZ wa+s3h82oxV8Nf9PRl0YRswa9xCHKcpyRUJbn4n51qLSaKEQDQBGdk3GDQDeHOiWcYzW JkLLT7qAFLdMxZIC2QhfZJkms+9zyTm0280TEiEXaeVmUY/URclrt77Q2GuFvQvwM44F t5GOdk76ORWP0cK+bE7L7KR6Q76kiYitbqQ0wrzbx5+FgaRQ/IO8juxvvcW9otaAi+wT k3/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gja50uK+VGu03YOVtNxYd9PQDwE60KteuWGZ1s7ZCqk=; fh=DT8jRdFfyM9b5Anmm4uZ44Cid5FhewSxq8vVVq34ijc=; b=AbNEMmjlNJ3iFQx9cs+T8KRtproqSNj7mBVxPDo3ZJe6Cx2B+lNoe/EOxW47Xd4CJC iLvM8U/JI7jiIGp+GGA4tZKb4eqP56MuWfBXeX87flIUMYgOmIdMxFfPvG4mMmgXulh7 hWvMagIdyM2oO/rrpXWE5ETEJcXUrFsrA5pGdUcEpXVrqXmHaKpn7JTCCdb3fDL/CGjM Mc4wRWhd3/5+Dk4zCSkQB7Agid2M8QoM2UDaQ6BqKn9L7RGq+pRacxN8WktYDLSJ7lOx wE3r+zmOqHNsGihiV4ddvS7S/ZZZzGdLK627a8rxpIQuVZw06NViYByktZbO6kA27Hmh d9cQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ZW5bf1VW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id u21-20020a634715000000b005b55df27b44si4542851pga.340.2023.11.18.09.43.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:43:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ZW5bf1VW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id A2F0C80BC524; Sat, 18 Nov 2023 09:43:20 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230498AbjKRRnM (ORCPT + 29 others); Sat, 18 Nov 2023 12:43:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230361AbjKRRmr (ORCPT ); Sat, 18 Nov 2023 12:42:47 -0500 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D260B10C9; Sat, 18 Nov 2023 09:42:40 -0800 (PST) Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2c83d37a492so38064591fa.3; Sat, 18 Nov 2023 09:42:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700329359; x=1700934159; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gja50uK+VGu03YOVtNxYd9PQDwE60KteuWGZ1s7ZCqk=; b=ZW5bf1VWQ1/6KGSJyA4v8XvNmEqmb/LmWSqeJlq0dhzfvV6Tsx6nywtBvTVW4ONyMj iC5FOzP8rlNRZhXHhOOKcJdI3tNus2IraGqm4fDwSuo4pnM7Vm206feWd+CYli9Eb3Mt P6pEqlwtCMcEmMI2XIIoay4KxWdEdmiiRO071abCDk9CHEEVgaPDyIW65Jb01tuKVZye 4qb7VnCp1ugWEcGIOdOrEV7Ba0G3yyeDh6YWafLGX1DNG+Zk573h6Lyy3n8w4eSDR9C7 D2Xl9phfuuVsud0wDNOsaOIQ3DpovBeepFq6k8y+IZct46sbL0/nOVmYlnXjxFv42bre a8mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700329359; x=1700934159; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gja50uK+VGu03YOVtNxYd9PQDwE60KteuWGZ1s7ZCqk=; b=I4KdM8yM6yUEAxD7MtTRzjc7SOxZNFSpz3/bbmOPYLkFqSA9jxiAppMkXeJUFBLKED Qe0wTCaYQWDyXaFwtvxS/a7jaQ4xOBd6nRjYhz0r+9bmHf/d7hYmXLmDNVeUuMh3zOhN xauMXeUsE8tX0d42R+pXIpZqZKPea/hAePrMENSACg2g1m2yCptqRV4jYNid+1FPoYBI c87r8JRycanqfS1DZcbOZji40BF3qMM0IeAd6MT3ZB975qYR476fNNCJ6nLOyICXmspU mYCEmoIJd0XGfL01k5rfkRBZjPYI2RkBEmuujs0Yp+vCUwpHEZChR8ESBnW8GOUg09Py Yz5g== X-Gm-Message-State: AOJu0YzEoYv08E2IhUHtvvB8AFEBs8kGCSybDamVq5VuimM0tF4UpEnL gBG2nyx19+9OgKm5Kg2axT8= X-Received: by 2002:a2e:80c7:0:b0:2c6:f0a0:8bf3 with SMTP id r7-20020a2e80c7000000b002c6f0a08bf3mr2023765ljg.11.1700329358992; Sat, 18 Nov 2023 09:42:38 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c340a00b004068de50c64sm6964211wmp.46.2023.11.18.09.42.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 09:42:38 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Maik Broemme Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Helge Deller , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 13/20] drivers/video/fbdev/intelfb/intelfb_i2c.c: remove I2C_CLASS_DDC support Date: Sat, 18 Nov 2023 18:42:13 +0100 Message-ID: <20231118174221.851-14-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118174221.851-1-hkallweit1@gmail.com> References: <20231118174221.851-1-hkallweit1@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sat, 18 Nov 2023 09:43:20 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782924602480501789 X-GMAIL-MSGID: 1782924602480501789 After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/video/fbdev/intelfb/intelfb_i2c.c b/drivers/video/fbdev/intelfb/intelfb_i2c.c index 3300bd31d..f24c7cb4c 100644 --- a/drivers/video/fbdev/intelfb/intelfb_i2c.c +++ b/drivers/video/fbdev/intelfb/intelfb_i2c.c @@ -99,8 +99,7 @@ static int intelfb_gpio_getsda(void *data) static int intelfb_setup_i2c_bus(struct intelfb_info *dinfo, struct intelfb_i2c_chan *chan, - const u32 reg, const char *name, - int class) + const u32 reg, const char *name) { int rc; @@ -108,7 +107,6 @@ static int intelfb_setup_i2c_bus(struct intelfb_info *dinfo, chan->reg = reg; snprintf(chan->adapter.name, sizeof(chan->adapter.name), "intelfb %s", name); - chan->adapter.class = class; chan->adapter.owner = THIS_MODULE; chan->adapter.algo_data = &chan->algo; chan->adapter.dev.parent = &chan->dinfo->pdev->dev; @@ -144,8 +142,7 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo) dinfo->output[i].type = INTELFB_OUTPUT_ANALOG; /* setup the DDC bus for analog output */ - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOA, - "CRTDDC_A", I2C_CLASS_DDC); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOA, "CRTDDC_A"); i++; /* need to add the output busses for each device @@ -159,10 +156,8 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo) case INTEL_855GM: case INTEL_865G: dinfo->output[i].type = INTELFB_OUTPUT_DVO; - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, - GPIOD, "DVODDC_D", I2C_CLASS_DDC); - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, - GPIOE, "DVOI2C_E", 0); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOD, "DVODDC_D"); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, GPIOE, "DVOI2C_E"); i++; break; case INTEL_915G: @@ -176,7 +171,7 @@ void intelfb_create_i2c_busses(struct intelfb_info *dinfo) /* SDVO ports have a single control bus - 2 devices */ dinfo->output[i].type = INTELFB_OUTPUT_SDVO; intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, - GPIOE, "SDVOCTRL_E", 0); + GPIOE, "SDVOCTRL_E"); /* TODO: initialize the SDVO */ /* I830SDVOInit(pScrn, i, DVOB); */ i++;