From patchwork Sat Nov 18 07:59:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 166466 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9910:0:b0:403:3b70:6f57 with SMTP id i16csp1047856vqn; Fri, 17 Nov 2023 23:59:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IHytbY43Bay5TXZ3jSfGN9zYiykSpqDVP2zeioaCuDI4eSSK7lsXE3jh2GCrh1MPL8VLmjw X-Received: by 2002:a05:622a:1815:b0:41e:19d5:bdf5 with SMTP id t21-20020a05622a181500b0041e19d5bdf5mr2147645qtc.48.1700294378919; Fri, 17 Nov 2023 23:59:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700294378; cv=none; d=google.com; s=arc-20160816; b=EUoJfkPv5W3Bs2zM2B8VuqbAOTaTaKxwGnlduYQT5cIRAdPBIzPCpSDjtoCD2qzua4 2IubUK0+vHqeR2zcY4H3xoG/heH1wxgQhoeIoPut/BTvxFKxeCJ+DsJQcDYGeaQLzeI1 Zxz1UkogLVXyS276kP4K75if7i/cxbymUusdEbNxEaYWz1AcX/YECucj4s/slaiBq9/5 zqqDuguhCFlczi+zPYgPJDTJKyla1HRK+/meXEyGop7t/M4dXPvrREL/TKi1bbmeGOUb xvX/OsjPBYmabb7kjant60hPDpyEd5MqnOi1orOTh/si9XTmCpUh5pv5bsYdkAhs0ENu Y1JA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6OOyFUkmdgAWrGhzdNXvnGtIyltC2xbRI9/BvC4MpLg=; fh=oQbvuNnOUeIuBT5siQdg+euUHNNdn+CeEwAg69/1RSo=; b=v5orzKVyLjE5u0alPM4iKBd9iIb7FDYKXjh9D12RahlMSvYTyMAKwTkyN1o+lWvw13 aFQq28iHn2G4dnT9I9Ur5Y2EXbmKPfk+SkboCTCfWpWziLKOUUtX6YiplAOTJ97Qyb/T s7gDDv4GegKAIgUTyzhOJ0N6qMehry5y3CZU+sjgHlSkRfwJbjti5XhJbkgKjpbZmXXR sid6mIZscD81/EvIiKEbX6ihtLlOBxvfQH322BezATCupMzUa5EOY3Q0teWga92Rd7yu s88L7pnAzrE4g2LKnfLGpsRAYPBlVbmclQC34HBnylbGy5cxv64TBIuufXUPSkDgzoV+ EH8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dO8nnAy9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id a3-20020a631a43000000b005657ba564bdsi3625936pgm.826.2023.11.17.23.59.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 23:59:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dO8nnAy9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 0ED6882BB546; Fri, 17 Nov 2023 23:59:38 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232611AbjKRH7d (ORCPT + 29 others); Sat, 18 Nov 2023 02:59:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232474AbjKRH7Y (ORCPT ); Sat, 18 Nov 2023 02:59:24 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47698D51 for ; Fri, 17 Nov 2023 23:59:21 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A797C433C9; Sat, 18 Nov 2023 07:59:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700294360; bh=JYJrXNFpHjgM9hzobfa0oay+OYFkHJDCeKRYtYSm0BA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dO8nnAy9OwYrA+7yb/7/G7ZlgLeEt/p5iY39MO0KMnqweiduZpzpDiySsbNtIuris 3XRqXgjRWjdHgJ/yB+xjvPAdfA9KZQ6lk+V33CWAdWFeOFC4Ku25rt1uPTxijl0vFO 3HzJHG3iWTcWokJY1ON/H0qoZQjNL1YMOzOd3LBOlaOdMyfyomdlJUlxI1GP2qd4w8 3I+tv5NxJrGgUIjhD3u872dZjB3kohUSIEYOcGvcYEkrfi3OkFS4c0s+vQURYryrIr td0ypwhWx4E4vvqOn7LEqzCZDhuqpyO/2BS9uTBeLL/zzA+dIfsLiaSS2QGaoJepZ9 qyQJJlqox5B6g== From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Masahiro Yamada Subject: [PATCH 5/6] kconfig: require an exact match for "is not set" to disable CONFIG option Date: Sat, 18 Nov 2023 16:59:11 +0900 Message-Id: <20231118075912.1303509-5-masahiroy@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231118075912.1303509-1-masahiroy@kernel.org> References: <20231118075912.1303509-1-masahiroy@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 17 Nov 2023 23:59:38 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782887878402220092 X-GMAIL-MSGID: 1782887878402220092 Currently, any string starting "is not set" disables a CONFIG option. For example, "# CONFIG_FOO is not settled down" is accepted as valid input, functioning the same as "# CONFIG_FOO is not set". It is a long-standing oddity. Check the line against the exact pattern "is not set". Signed-off-by: Masahiro Yamada --- scripts/kconfig/confdata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c index 795ac6c9378f..958be12cd621 100644 --- a/scripts/kconfig/confdata.c +++ b/scripts/kconfig/confdata.c @@ -454,7 +454,7 @@ int conf_read_simple(const char *name, int def) if (!p) continue; *p++ = 0; - if (strncmp(p, "is not set", 10)) + if (strcmp(p, "is not set")) continue; val = "n";