From patchwork Sat Nov 18 02:48:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Jihong X-Patchwork-Id: 166424 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9910:0:b0:403:3b70:6f57 with SMTP id i16csp955648vqn; Fri, 17 Nov 2023 18:52:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IEPkmq+siddr4q0d1bkvhhGBnyt7ydHJX3nY+gHfUqdFA5Mzfltib/e85oNlmSeR7AMy/qv X-Received: by 2002:a81:5341:0:b0:5c0:8f5e:c900 with SMTP id h62-20020a815341000000b005c08f5ec900mr1733280ywb.19.1700275945629; Fri, 17 Nov 2023 18:52:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700275945; cv=none; d=google.com; s=arc-20160816; b=mqolsw5BpA2GeNbGqU1Ys/TZE3sOfXGyiVbOesIW48czycVg1Pp/X1ktwvvbRPUtad usTLHepXeFH5PVMn3SnzDklnmms+aqxBhI/G8d43GE4H9W3Q5qsntrYigjnZ+68pzfHo QB+C4KVI4I7ouXcAdpIlG+e9ogFC3PXaMlm8sUHLOVniQeNa/jmnWRia4u5BVYnmEzEC qDOcKShHNTns+oIV7L3t52FPS1PfHVY/WVdANRa6RTMQ78iZp1Tfwopxx6nZCo3UCFq+ suIVNoipa9ow+Krl+yVVUjdM43D6JNZF4XEVA8AB4LvTT3JVm4utISwAQiLDZ4CMDYtv 6GcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=WbMspTuyF/1iH+Oas7Zuyq8VC+UiTy3J++p9EDjElSk=; fh=DIzfUWfj21RIAI8ibHhNFjdiKeApGT6CviQ22JnUOaM=; b=GccXcjH0zbf6WjBNZDfpCzadBRHFy5C8IrrVUx1lrEA/KAh54htoQ840aspIB5Kh7+ O89MToS2WNqfTXIUdzvgC/RqD++lvcItlD301Rz9GwwixndSD8YIkXoYEKiYILjnwrAi lRc5KAe4ZET7gyX1f5rvPTkBvV9YEtB/Lsk/XV9sOvsWYyvThHb7FjRoKZ0Uypngf1J+ SrpcNLLkhS2SL0yetKwJ29GhnDe9FZzKeohxLyU+dChnhVx/Ax6C9ccSGcI61A+LaZB+ ETqrzcRaHt6G8hqr3Rlkd1AbncAmtlse2Jglz9X+ELpmf/ZEbNbANCbzHfdVB4Arc1ci LcBA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id m19-20020a056a00081300b006cb4b316df8si840207pfk.6.2023.11.17.18.52.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 18:52:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id A662D804595D; Fri, 17 Nov 2023 18:52:02 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232854AbjKRCvv (ORCPT + 29 others); Fri, 17 Nov 2023 21:51:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229994AbjKRCvu (ORCPT ); Fri, 17 Nov 2023 21:51:50 -0500 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 058C1D6A; Fri, 17 Nov 2023 18:51:42 -0800 (PST) Received: from kwepemm000003.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4SXJ9Y32bmz1P8FM; Sat, 18 Nov 2023 10:48:17 +0800 (CST) Received: from ubuntu2204.huawei.com (10.67.174.22) by kwepemm000003.china.huawei.com (7.193.23.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Sat, 18 Nov 2023 10:51:40 +0800 From: Yang Jihong To: , , , , , , , , , , , , CC: Subject: [PATCH 1/3] perf kwork: Fix a build error on 32-bit Date: Sat, 18 Nov 2023 02:48:56 +0000 Message-ID: <20231118024858.1567039-2-yangjihong1@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231118024858.1567039-1-yangjihong1@huawei.com> References: <20231118024858.1567039-1-yangjihong1@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.67.174.22] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm000003.china.huawei.com (7.193.23.66) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 17 Nov 2023 18:52:02 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782868549805804983 X-GMAIL-MSGID: 1782868549805804983 lkft reported a build error for 32-bit system: builtin-kwork.c: In function 'top_print_work': builtin-kwork.c:1646:28: error: format '%ld' expects argument of type 'long int', but argument 3 has type 'u64' {aka 'long long unsigned int'} [-Werror=format=] 1646 | ret += printf(" %*ld ", PRINT_PID_WIDTH, work->id); | ~~~^ ~~~~~~~~ | | | | long int u64 {aka long long unsigned int} | %*lld cc1: all warnings being treated as errors make[3]: *** [/builds/linux/tools/build/Makefile.build:106: /home/tuxbuild/.cache/tuxmake/builds/1/build/builtin-kwork.o] Error 1 Fix it. Fixes: 55c40e505234 ("perf kwork top: Introduce new top utility") Reported-by: Linux Kernel Functional Testing Signed-off-by: Yang Jihong --- tools/perf/builtin-kwork.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-kwork.c b/tools/perf/builtin-kwork.c index f007a9b27065..0092b9b39611 100644 --- a/tools/perf/builtin-kwork.c +++ b/tools/perf/builtin-kwork.c @@ -1643,7 +1643,7 @@ static int top_print_work(struct perf_kwork *kwork __maybe_unused, struct kwork_ /* * pid */ - ret += printf(" %*ld ", PRINT_PID_WIDTH, work->id); + ret += printf(" %*" PRIu64 " ", PRINT_PID_WIDTH, work->id); /* * tgid