From patchwork Fri Nov 17 14:40:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raag Jadav X-Patchwork-Id: 166207 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9910:0:b0:403:3b70:6f57 with SMTP id i16csp575246vqn; Fri, 17 Nov 2023 06:41:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IG0igWxg/zzQI29pVZlOvuVw+LnmHzRXBCk6O3pga3DxcAOc86zAOLtSD1nc2qoJTYvIqAM X-Received: by 2002:a05:6a00:230f:b0:6be:22db:7a13 with SMTP id h15-20020a056a00230f00b006be22db7a13mr6810183pfh.25.1700232085924; Fri, 17 Nov 2023 06:41:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700232085; cv=none; d=google.com; s=arc-20160816; b=bCkezg55P6b0umNwciZWLuPu1etpuQyixw8CwUMyrd7IxeW9I1u12vm2UqJKBMnv7G /jrw2xWdy6SpJbzoF+1+joGiuE0t7NNdqL23V5YWf0BMG1Or1F2yjaRyH+4RmuNGXE4c UKY/Zb946QbHR+Jg45aFQAdK3o/dE95UpiVOEdwusNvqTY5qjrEL798+i/kASUbAoV3p A7LUqm6cXfbo97UGEE2n+InkqxqbGpZFuZGKyC6p9Q1hwFqK4NZ4tzcwEWcXFzKu0Iwz Ap+jtzC1/WxpwwTkE05kXuMREFdh/icrJvfLQVbHYCuZi4ZmdDP3IqSzO91ogMNmdwj2 WwQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=0cEv2qBDny3yfHE6hsChn1RNEbGvwc6G9pqq9l4cgE8=; fh=2KLYqVwUCPLsFbbChusNuF68x5zsPRDVEW6cyaYUJCU=; b=b5kjk6jdDjXUnwlofwRxi+vE6o+fHgDI416VXlwchttjKH398mfueSfACD5iNyDFGB 1AHpfrN2Cejqc28f98MO25om9Nheuh8SS1AKtgYhMS4tocwsShMJdEkRGyQSVzMndV8D YR+htwnSt7m9wtW10OUH0C4LRxjdCQqXlThehbdHC1BNj7B69gfnyQ+Gmj92pVddQ3MP kN3Dv8SgNs09NrluoSKmD31WLIhUE1434WVGkpeUesfKz3YlaOZ+HQo4JsluA9/7TEtx EACwDKc38yJ+nFLLY06l61jzoEdOHA1irH5aAsDrhlhpTLbcFSOAbHo8l2kDBT9tdXeB 1xGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=arKd14o0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id e24-20020a656498000000b005a1d88169casi1894561pgv.189.2023.11.17.06.41.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 06:41:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=arKd14o0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id C0CA781ECCCD; Fri, 17 Nov 2023 06:41:23 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231491AbjKQOlM (ORCPT + 30 others); Fri, 17 Nov 2023 09:41:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231145AbjKQOlL (ORCPT ); Fri, 17 Nov 2023 09:41:11 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B32E8C5; Fri, 17 Nov 2023 06:41:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700232064; x=1731768064; h=from:to:cc:subject:date:message-id; bh=oJMlxIX+xGl6Bb9PQ7qfp+lKIWOfx1gEg/uC2QjrdSE=; b=arKd14o0v7nbIweOaAPYgdzMIc7MsXFDT2kiUlM3rGXEc/zk3uoNPZeb sizsEy9P9/1Ke5KgyyhPUSx8XR+yo4h7/bSJQzzvR/yIUYr12Z8i0LRTD y8N82ISCYdU3dmmeybiDPpODiPgcOgtSnsPLJWoLPhtMXxGCVaqY8mtMl CVgWoCmOzD8yzzBWPSP0WqOht06xwbwnRr8W+YidkQyqFTxhp/OKZWTVo yHRin+4EYFAO8Z2y4FHjQQe8OPPTSg21/ruh3lu3i4okuLnJfPqhxe49A W+sI6qUkyge6LXqgoL1F/ZPpFeSeGt+bRXGRi06l2K3FcS1YD6dALIyPK w==; X-IronPort-AV: E=McAfee;i="6600,9927,10897"; a="370661074" X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="370661074" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2023 06:41:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10897"; a="742092615" X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="742092615" Received: from inlubt0316.iind.intel.com ([10.191.20.213]) by orsmga006.jf.intel.com with ESMTP; 17 Nov 2023 06:41:01 -0800 From: Raag Jadav To: broonie@kernel.org, mika.westerberg@linux.intel.com, andriy.shevchenko@linux.intel.com Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Raag Jadav Subject: [PATCH v1] spi: intel: make mem_ops comparison unique to opcode match Date: Fri, 17 Nov 2023 20:10:53 +0530 Message-Id: <20231117144053.24005-1-raag.jadav@intel.com> X-Mailer: git-send-email 2.17.1 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 17 Nov 2023 06:41:23 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782822559488734419 X-GMAIL-MSGID: 1782822559488734419 Instead of comparing parameters for every supported mem_ops, only compare on opcode match, which is relatively more efficient. Signed-off-by: Raag Jadav Reviewed-by: Mika Westerberg --- drivers/spi/spi-intel.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/spi/spi-intel.c b/drivers/spi/spi-intel.c index 98ec4dc22b81..3654ae35d2db 100644 --- a/drivers/spi/spi-intel.c +++ b/drivers/spi/spi-intel.c @@ -711,8 +711,7 @@ static bool intel_spi_cmp_mem_op(const struct intel_spi_mem_op *iop, { if (iop->mem_op.cmd.nbytes != op->cmd.nbytes || iop->mem_op.cmd.buswidth != op->cmd.buswidth || - iop->mem_op.cmd.dtr != op->cmd.dtr || - iop->mem_op.cmd.opcode != op->cmd.opcode) + iop->mem_op.cmd.dtr != op->cmd.dtr) return false; if (iop->mem_op.addr.nbytes != op->addr.nbytes || @@ -737,11 +736,12 @@ intel_spi_match_mem_op(struct intel_spi *ispi, const struct spi_mem_op *op) const struct intel_spi_mem_op *iop; for (iop = ispi->mem_ops; iop->mem_op.cmd.opcode; iop++) { - if (intel_spi_cmp_mem_op(iop, op)) - break; + if (iop->mem_op.cmd.opcode == op->cmd.opcode && + intel_spi_cmp_mem_op(iop, op)) + return iop; } - return iop->mem_op.cmd.opcode ? iop : NULL; + return NULL; } static bool intel_spi_supports_mem_op(struct spi_mem *mem,