From patchwork Fri Nov 17 09:44:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 166063 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9910:0:b0:403:3b70:6f57 with SMTP id i16csp412922vqn; Fri, 17 Nov 2023 01:48:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IGBA0VMQbUM1ZaWUJwu9rzndjeCH+8efsh4QxC5J3lhFlLh10MK4M6omoOKSrY2KZY1g9bv X-Received: by 2002:a05:6a20:12d4:b0:172:918b:3907 with SMTP id v20-20020a056a2012d400b00172918b3907mr21254583pzg.54.1700214533839; Fri, 17 Nov 2023 01:48:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700214533; cv=none; d=google.com; s=arc-20160816; b=JvrYAv/QskGwamcq8S6SL4cGflJz9ZVSmMRus44fc3KBMJXfcgqnhHHTXHMl6th1iT o5qwp/BEgbTemvkknexGWikA8qzGT3vIwfg1q0c7u/XAs+iB4lj7nJ2ovuQbQcyaUh50 Jjwe/BIcFN2rf9lJ4WCyOBe03Y9E98KaAaYK61tYRIm/nIQEWtjtohAqMikt+ytCUFR9 kVaBbvjGnvd8JY5W62g0f2nloAgqoLHoDo76x2M/E3y3UM77ADBYbTPKNJJJyjW7AtlJ gt4cbMADLh7kk9kjoLwKJfAPVd8BwPxnurdTPUNmajZekobEuOaQykztVKLHx0vpZJ6Y O5jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8GaSsLDoPz8wCRqBpOMB7EjTrs+p6JOrPUk0hE0LQsM=; fh=W+eSkce8uvUdQ8A1Dj5F8klEXQy967eJmFo02igvYfU=; b=JBNhuRfNPGyG9928q897YK/gx9TYDNu8MG9i7rVjjAJvFdeCbGhi72oe7LtN7I4xoI o+aUIPCJn+m6Z5916LxUJ0NdRGf2Qv/g3CCCmKd4ChvMq685tBgzEE03u3BFxvSWmwOC 2ePBv9zfyrMm0GZYWOVnWYjZhSKRaxkhhHr46P+FK+Pe5JyhFfLM5/w0wIYU66lvl5Tm jTOszj02rqylcMsb/9Db821dn1QFT4F6og+Q/jfJQrkzbmX4ec+P0Rxhc0N/a8Y/xhSO Buv8aQY4UuD6UYIXZ1qBeSjfrMrLlpTxEG2NU7taIn26/Aj+SpK3HB69XZ7/z7BlH+z1 PI8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XcrEsV1V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id y19-20020a17090aa41300b0028008d0edc8si4068060pjp.83.2023.11.17.01.48.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 01:48:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XcrEsV1V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 6A2158269182; Fri, 17 Nov 2023 01:48:52 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345796AbjKQJsn (ORCPT + 30 others); Fri, 17 Nov 2023 04:48:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235816AbjKQJsQ (ORCPT ); Fri, 17 Nov 2023 04:48:16 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FC9B3AB6; Fri, 17 Nov 2023 01:45:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700214337; x=1731750337; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Cuf+QXuL+m32xRWl5bc7WZf9izw1GwzkTLEiiqics7o=; b=XcrEsV1VIJNMVdc3imFuWGLlH4kW/vsCyhuL/MlH5NdW/7k6PSOIFZW1 FrGgWRKCy8bo+Eca9i2xPZcGhaCyOvYep+ZQ9biaWQzfxPOepd73BS5l/ THHuYAZiziW/Du1Vn8ZbXJ3tqOQA9eah8ATDjdsbv9OhMRF90Gy7mmIlv O2ql2BI1bhzIU3Vnleym8Jq/ktmH8Cs2vbuLVF+cpJ3BkzMkjg/ynifJB +RHtSGN9YWIDqdAMS/gt3bMqlhbh3ktJ0b4/SFx9Tswh677qeuRaVuNXC NjWnqjy8XSQiV5jTlutxSR0NvDRBG55EgNocRpQJwDh6P1RER5k63JfQN w==; X-IronPort-AV: E=McAfee;i="6600,9927,10896"; a="390123905" X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="390123905" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2023 01:45:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="6972520" Received: from rvadera-mobl.ger.corp.intel.com (HELO localhost) ([10.251.219.158]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2023 01:45:33 -0800 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= To: "John W. Linville" , Kalle Valo , Larry Finger , linux-wireless@vger.kernel.org, Ping-Ke Shih , Bjorn Helgaas , linux-kernel@vger.kernel.org Cc: =?utf-8?q?Ilpo_J=C3=A4rvinen?= Subject: [PATCH 3/7] rtlwifi: rtl8821ae: Remove unnecessary PME_Status bit set Date: Fri, 17 Nov 2023 11:44:21 +0200 Message-Id: <20231117094425.80477-4-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20231117094425.80477-1-ilpo.jarvinen@linux.intel.com> References: <20231117094425.80477-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 17 Nov 2023 01:48:52 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782804155164244282 X-GMAIL-MSGID: 1782804155164244282 BIT(7) (PME_Status) is first checked and then set unnecessarily. Remove the unnecessary setting for the bit that is already on and adjust the comment related to it. Signed-off-by: Ilpo Järvinen --- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c index 1633328bc3d1..6ae37d61a2a2 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c @@ -2312,9 +2312,7 @@ static void _rtl8821ae_clear_pci_pme_status(struct ieee80211_hw *hw) pci_read_config_byte(rtlpci->pdev, cap_pointer + 5, &pmcs_reg); if (pmcs_reg & BIT(7)) { - /* PME event occured, clear the PM_Status by write 1 */ - pmcs_reg = pmcs_reg | BIT(7); - + /* Clear PME_Status with write */ pci_write_config_byte(rtlpci->pdev, cap_pointer + 5, pmcs_reg); /* Read it back to check */