From patchwork Fri Nov 17 00:37:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shigeru Yoshida X-Patchwork-Id: 165972 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9910:0:b0:403:3b70:6f57 with SMTP id i16csp212196vqn; Thu, 16 Nov 2023 16:37:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IHMoKOnSd8Z9SpkE3AFqSL/ymsF9w8Td9LAS64jw/4ZXAthlyqV2B0xCDqxVxGSFxX7x5ep X-Received: by 2002:a05:6808:290d:b0:3a7:4914:23ce with SMTP id ev13-20020a056808290d00b003a7491423cemr17003617oib.18.1700181460934; Thu, 16 Nov 2023 16:37:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700181460; cv=none; d=google.com; s=arc-20160816; b=H+BpGZ1eQm7RvgSLt9WFhtXY3P5pd7zT5ZXRUNGjpModGi80G6tzb6bdmqOZiR3k2s t78EIcmy/oHM7wPg+l+EBRtUiZiAGdt4xW+JusIXLZhwL4VqfNdItYywWyeeF+1GXQPh oaHqpPqbe55bSkCQ4T90dyAN0vA1QzoVNBIabXfWnBN8AmIADydIpcFVcT+UbfsSW27v sVwSVGZ/NeJjSAQ19QYr4IKByMOTU61eYMyE9U3lQx+25APnmq+ThXFR6j8TihJCa8Kf en/rnHCEXdyp1SgDbXCmfFSUwDVyRkDj7HQD0uZo5qlnNDLPIgPF9VCJiv3+tN1damc1 SqrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=gLq9QND6ayr1x65UPXkRh82Mu4Sx1+2cD2sZ+Ae8qnc=; fh=OjWxN1ZsFMWDVj4vn9cmfza0iojbCgAbYMZGd4CkP64=; b=vmd+F6IB6y3Z2DKKbIPdbVUWKgwSQ9J+Vcsf3eBcM+uw9ANF6dAaMsfGg1Nb6clUg0 hX6k6ESj5roT7zPVLnlEhnIZlJpo6PbtgOx06e38IMYi0S5wyOYo9jSdOjy5TH9D9H3p 311M+6953PtvnQZyuf7BU2LNUkJS28VJ12q5UvpFskAkbVZeEZCRoNS4P89j57AgOanh mZEvO3+1yyqoyjLxWpoJLcWAIMI1sTaQj5to+JAWrpYesMeIF996SQ09bWeM9A40w8W2 gv+vlNTV3YxacTg856BOOHRhfG9tKNROBG0BBaJD6t0U+GeGFElo7NRanYD2U9dniYkJ EDjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="LV/jzk7X"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id h5-20020a636c05000000b005c1cd55beeesi560072pgc.435.2023.11.16.16.37.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 16:37:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="LV/jzk7X"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id A42CD81B9101; Thu, 16 Nov 2023 16:37:38 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345557AbjKQAhY (ORCPT + 30 others); Thu, 16 Nov 2023 19:37:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjKQAhX (ORCPT ); Thu, 16 Nov 2023 19:37:23 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98C001AD for ; Thu, 16 Nov 2023 16:37:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700181439; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=gLq9QND6ayr1x65UPXkRh82Mu4Sx1+2cD2sZ+Ae8qnc=; b=LV/jzk7XPLukx1wWFELwh2yiZ/p/CI0YSY5ytm9beQqSSu0AeAxRtpBOGkkDue6PPd43hA RBcnOiR1XugoFS6Fr5UOjhwN/6dh5JliHkTI/+nXRaA/P2oV/1ySenKO4UjVaQVm2khSdz IdYVfSbg/t4pp45Kdv//NIOTq9h+t/U= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-594-Ozoe3NZhOr-xyr9bW4hygQ-1; Thu, 16 Nov 2023 19:37:18 -0500 X-MC-Unique: Ozoe3NZhOr-xyr9bW4hygQ-1 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-1ce5d31e709so2940295ad.3 for ; Thu, 16 Nov 2023 16:37:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700181437; x=1700786237; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gLq9QND6ayr1x65UPXkRh82Mu4Sx1+2cD2sZ+Ae8qnc=; b=fLseR2p2HKouZ7EL/J4dqQMpH61Dt0luiydCjuP9G0szUAVdh72OKjOmGa/6kemkw9 p1tjHHYBWpXspOn4ebISa2DfSWo9LftdEVxCgspINThcKJ0znlNmGO7u4buCN8BZkyQW sJz/AiWekRg7mLJt9XYnR1y4BMmxVgYf5KiOXHN9IIuJ8bLKn7WxGeRQke6DHuPdRWCG DoXJpz3CX+QeM4tbwkkLcFmi3A3Ln54pW7i19OUoewdYHGeuqwxs6SBJ4Whbr03iXyPq /jPDJS1EmkUK6ROmKdCwrWzcpCXiTGnwtBMEA8Pp324PFqZ5aWUJQCaB6knK8U36lBrd XAFg== X-Gm-Message-State: AOJu0YxRV/Z86PCxm/UXJylKJvo8sGMSjDOZ4uxBH0P6UxI1/zpkqnN1 EMkaNwUrWrJBljlcAuOPGWWkIQO9VrAN0cWuOvnQAnhKavRQ5NIy/eS03n/CTM3zLOPOr6dUK5D 1G8oqlabtKSy2qX94Qao5laqO X-Received: by 2002:a17:902:ab47:b0:1c9:dfb8:a5a0 with SMTP id ij7-20020a170902ab4700b001c9dfb8a5a0mr9979182plb.10.1700181437143; Thu, 16 Nov 2023 16:37:17 -0800 (PST) X-Received: by 2002:a17:902:ab47:b0:1c9:dfb8:a5a0 with SMTP id ij7-20020a170902ab4700b001c9dfb8a5a0mr9979170plb.10.1700181436840; Thu, 16 Nov 2023 16:37:16 -0800 (PST) Received: from kernel-devel.local ([240d:1a:c0d:9f00:245e:16ff:fe87:c960]) by smtp.gmail.com with ESMTPSA id p7-20020a170902a40700b001ca4cc783b6sm256213plq.36.2023.11.16.16.37.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 16:37:16 -0800 (PST) From: Shigeru Yoshida To: jmaloy@redhat.com, ying.xue@windriver.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org, Shigeru Yoshida Subject: [PATCH net-next v2] tipc: Remove redundant call to TLV_SPACE() Date: Fri, 17 Nov 2023 09:37:04 +0900 Message-ID: <20231117003704.1738094-1-syoshida@redhat.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 16 Nov 2023 16:37:38 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782550935563867648 X-GMAIL-MSGID: 1782769475159288243 The purpose of TLV_SPACE() is to add the TLV descriptor size to the size of the TLV value passed as argument and align the resulting size to TLV_ALIGNTO. tipc_tlv_alloc() calls TLV_SPACE() on its argument. In other words, tipc_tlv_alloc() takes its argument as the size of the TLV value. So the call to TLV_SPACE() in tipc_get_err_tlv() is redundant. Let's remove this redundancy. Acked-by: Paolo Abeni Signed-off-by: Shigeru Yoshida --- v1->v2: - Re-submit to net-next https://lore.kernel.org/all/20231114144336.1714364-1-syoshida@redhat.com/ --- net/tipc/netlink_compat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c index 5bc076f2fa74..db0365c9b8bd 100644 --- a/net/tipc/netlink_compat.c +++ b/net/tipc/netlink_compat.c @@ -167,7 +167,7 @@ static struct sk_buff *tipc_get_err_tlv(char *str) int str_len = strlen(str) + 1; struct sk_buff *buf; - buf = tipc_tlv_alloc(TLV_SPACE(str_len)); + buf = tipc_tlv_alloc(str_len); if (buf) tipc_add_tlv(buf, TIPC_TLV_ERROR_STRING, str, str_len);